* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
@ 2021-12-28 2:25 ` ifreund
2021-12-28 2:53 ` ifreund
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2021-12-28 2:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2402 bytes --]
From 012a5260d2fb4f824380b205f50e35ba1c2bce18 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 1/2] New package: dumb_runtime_dir-1.0.0
---
srcpkgs/dumb_runtime_dir/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..3ade10c5bd22
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,17 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=93b751a29de025c27343d2f86675afc17862b731f3712fa241b11bbd627f3637
+
+post_install() {
+ vlicense LICENSE
+ vdoc README.md
+}
From 4ec8e14db8ae4e332ef153d1bcdc4b458055673e Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 2/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
2021-12-28 2:25 ` [PR PATCH] [Updated] " ifreund
@ 2021-12-28 2:53 ` ifreund
2021-12-31 3:39 ` ifreund
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2021-12-28 2:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2384 bytes --]
From 64ef0b02155d074187e40095326bf068d29639d8 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 1/2] New package: dumb_runtime_dir-1.0.0
---
srcpkgs/dumb_runtime_dir/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..3f00fee0b2f4
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,16 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=93b751a29de025c27343d2f86675afc17862b731f3712fa241b11bbd627f3637
+
+post_install() {
+ vlicense LICENSE
+}
From 3aa016c69b0d0b61eac5c9b897a056b6201c2126 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 2/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
2021-12-28 2:25 ` [PR PATCH] [Updated] " ifreund
2021-12-28 2:53 ` ifreund
@ 2021-12-31 3:39 ` ifreund
2022-01-17 12:00 ` ifreund
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2021-12-31 3:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2384 bytes --]
From 38de7570d17df7c29a0133352ed898fb9a34caa2 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 1/2] New package: dumb_runtime_dir-1.0.1
---
srcpkgs/dumb_runtime_dir/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..cbc35a29f0d8
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,16 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=4bc570750d9d1d4c13211b9e511661b01693305340168dfbf3e4a6fba005abb5
+
+post_install() {
+ vlicense LICENSE
+}
From 27e73b3c7b367f24311322b50b33440eb3bad9a3 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 2/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (2 preceding siblings ...)
2021-12-31 3:39 ` ifreund
@ 2022-01-17 12:00 ` ifreund
2022-01-17 15:41 ` tornaria
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-17 12:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2414 bytes --]
From fce2b68bd5db442ab644dd06777a81ab34e934b1 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 1/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
From 09efc3d3ebc37b987646b1dd297b7355fe325aa4 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 2/2] New package: dumb_runtime_dir-1.0.1
---
srcpkgs/dumb_runtime_dir/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..b78e222db178
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,17 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+depends="pam-base>=0.4.0_2"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=4bc570750d9d1d4c13211b9e511661b01693305340168dfbf3e4a6fba005abb5
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (3 preceding siblings ...)
2022-01-17 12:00 ` ifreund
@ 2022-01-17 15:41 ` tornaria
2022-01-17 15:58 ` ifreund
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: tornaria @ 2022-01-17 15:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1014673551
Comment:
I've read the PR and the upstream code and everything LGTM.
I built and installed on my desktop, and works ok. Before I had `pam_rundir` which I replaced by this. I like that it comes preconfigured in pam-base. Even if both elogind and this are installed, it doesn't seem a problem at least when run in the order specified in this PR (but I haven't and won't test that).
I wonder if the package name should be `pam-dumb_runtime_dir` for consistency with other pam modules, or have the words "pam" and/or "rundir" somewhere for the benefit of searching.
In any case, other than the package name (on which I have no clear opinion), this is positive review from me.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (4 preceding siblings ...)
2022-01-17 15:41 ` tornaria
@ 2022-01-17 15:58 ` ifreund
2022-01-17 16:04 ` tornaria
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-17 15:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1014687684
Comment:
> I wonder if the package name should be `pam-dumb_runtime_dir` for consistency with other pam modules, or have the words "pam" and/or "rundir" somewhere for the benefit of searching.
The variable this sets is `XDG_RUNTIME_DIR`, "rundir" seems to be a name invented by `pam_rundir`. I think having `XDG_RUNTIME_DIR` in the package's description should be sufficient.
Anyhow, the policy stated in the [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#namingconventions) is to follow upstream naming, which I don't plan on changing at this point.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (5 preceding siblings ...)
2022-01-17 15:58 ` ifreund
@ 2022-01-17 16:04 ` tornaria
2022-01-17 16:37 ` ifreund
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: tornaria @ 2022-01-17 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1014693240
Comment:
> The variable this sets is `XDG_RUNTIME_DIR`, "rundir" seems to be a name invented by `pam_rundir`. I think having `XDG_RUNTIME_DIR` in the package's description should be sufficient.
`xrs rundir` shows two packages with this purpose (`pam_rundir` and `rundird`)
> Anyhow, the policy stated in the [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#namingconventions) is to follow upstream naming, which I don't plan on changing at this point.
Cf python packages, and for pam see `pam_zfscrypt`. I'm still don't have a clear opinion on the name.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (6 preceding siblings ...)
2022-01-17 16:04 ` tornaria
@ 2022-01-17 16:37 ` ifreund
2022-01-18 12:33 ` tornaria
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-17 16:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1014721762
Comment:
> `xrs rundir` shows two packages with this purpose (`pam_rundir` and `rundird`)
`rundird` is also my fault and is deprecated, I intend to open a PR removing it once this one is merged.
> Cf python packages, and for pam see `pam_zfscrypt`. I'm still don't have a clear opinion on the name.
Python packages follow the Language Modules section of the manual. PAM isn't exactly a language, but perhaps a similar convention should be applied. I'll defer to the void maintainers here.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (7 preceding siblings ...)
2022-01-17 16:37 ` ifreund
@ 2022-01-18 12:33 ` tornaria
2022-01-18 15:03 ` ifreund
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: tornaria @ 2022-01-18 12:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1015367717
Comment:
I've been running this since yesterday on several boxes (local and remote). Uneventful, it just works as expected.
This fixes an issue I had when using `pam_rundir`: if I log in to a remote box, run something in screen, detach and log out, the runtime dir would be removed, in spite of my user still being active.
Therefore I would favor recommending this for runtime dir on the absence of elogind. It is activated just by installing, it is zero maintenance and multi-user. Since `/run/user` is created at boot by `core-services/00-pseudofs.sh` on a tmpfs, there's no cleanup needed.
Maybe a mention can be added to the manual at https://docs.voidlinux.org/config/session-management.html#xdg_runtime_dir
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (8 preceding siblings ...)
2022-01-18 12:33 ` tornaria
@ 2022-01-18 15:03 ` ifreund
2022-01-18 15:03 ` ifreund
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-18 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1015499782
Comment:
> I've been running this since yesterday on several boxes (local and remote). Uneventful, it just works as expected.
Excellent! Uneventful was is the goal :)
> Therefore I would favor recommending this for runtime dir on the absence of elogind. It is activated just by installing, it is zero maintenance and multi-user. Since `/run/user` is created at boot by `core-services/00-pseudofs.sh` on a tmpfs, there's no cleanup needed.
>
> Maybe a mention can be added to the manual at https://docs.voidlinux.org/config/session-management.html#xdg_runtime_dir
There is some discussion on this subject ongoing here: https://github.com/void-linux/void-docs/issues/635
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (9 preceding siblings ...)
2022-01-18 15:03 ` ifreund
@ 2022-01-18 15:03 ` ifreund
2022-01-29 18:49 ` [PR PATCH] [Updated] " ifreund
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-18 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1015499782
Comment:
> I've been running this since yesterday on several boxes (local and remote). Uneventful, it just works as expected.
Excellent! Uneventful was the goal :)
> Therefore I would favor recommending this for runtime dir on the absence of elogind. It is activated just by installing, it is zero maintenance and multi-user. Since `/run/user` is created at boot by `core-services/00-pseudofs.sh` on a tmpfs, there's no cleanup needed.
>
> Maybe a mention can be added to the manual at https://docs.voidlinux.org/config/session-management.html#xdg_runtime_dir
There is some discussion on this subject ongoing here: https://github.com/void-linux/void-docs/issues/635
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (10 preceding siblings ...)
2022-01-18 15:03 ` ifreund
@ 2022-01-29 18:49 ` ifreund
2022-01-29 18:57 ` ifreund
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-29 18:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2414 bytes --]
From 9ab06de1d5ed54b1bc38dbe20e09e64ec278d59b Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 1/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
From f6d882536e2e72a8a37a4f7d512946e5d4234bdc Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 2/2] New package: dumb_runtime_dir-1.0.1
---
srcpkgs/dumb_runtime_dir/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..b78e222db178
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,17 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+depends="pam-base>=0.4.0_2"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=4bc570750d9d1d4c13211b9e511661b01693305340168dfbf3e4a6fba005abb5
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.0
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (11 preceding siblings ...)
2022-01-29 18:49 ` [PR PATCH] [Updated] " ifreund
@ 2022-01-29 18:57 ` ifreund
2022-01-29 18:59 ` New package: dumb_runtime_dir-1.0.2 ifreund
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-29 18:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 2414 bytes --]
From 9ab06de1d5ed54b1bc38dbe20e09e64ec278d59b Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 1/2] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
From b0203f392f4a03e9ba3ee4dd329cf68386511f55 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 2/2] New package: dumb_runtime_dir-1.0.2
---
srcpkgs/dumb_runtime_dir/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..b78e222db178
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,17 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.1
+revision=1
+build_style=gnu-makefile
+makedepends="pam-devel"
+depends="pam-base>=0.4.0_2"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=4bc570750d9d1d4c13211b9e511661b01693305340168dfbf3e4a6fba005abb5
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.2
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (12 preceding siblings ...)
2022-01-29 18:57 ` ifreund
@ 2022-01-29 18:59 ` ifreund
2022-01-29 19:53 ` [PR PATCH] [Updated] " ifreund
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-29 18:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1024967887
Comment:
I just released a new version of `dumb_runtime_dir` that uses `pkg-config` at the request of a user. Diffing the 1.0.1 and 1.0.2 binaries produced by xbps-src showed no difference.
Using pkg-config to link pam has highlight something weird about our pam packaging though, the `.pc` files are in the `pam` package instead of `pam-devel`. If you like I'd be happy to move them as part of this PR.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Updated] New package: dumb_runtime_dir-1.0.2
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (13 preceding siblings ...)
2022-01-29 18:59 ` New package: dumb_runtime_dir-1.0.2 ifreund
@ 2022-01-29 19:53 ` ifreund
2022-01-29 19:54 ` ifreund
2022-01-29 20:02 ` [PR PATCH] [Merged]: " leahneukirchen
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-29 19:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
There is an updated pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages dumb_runtime_dir
https://github.com/void-linux/void-packages/pull/34724
New package: dumb_runtime_dir-1.0.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34724.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dumb_runtime_dir-34724.patch --]
[-- Type: text/x-diff, Size: 3230 bytes --]
From 58b79ea621e5da8e92d3e963729a74abf8587513 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Sat, 29 Jan 2022 20:46:51 +0100
Subject: [PATCH 1/3] pam: move pkgconfig files to pam-devel
---
srcpkgs/pam/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam/template b/srcpkgs/pam/template
index bc15bef7c8f1..235f671d0de4 100644
--- a/srcpkgs/pam/template
+++ b/srcpkgs/pam/template
@@ -1,7 +1,7 @@
# Template file for 'pam'
pkgname=pam
version=1.5.2
-revision=1
+revision=2
wrksrc="Linux-PAM-$version"
build_style=gnu-configure
configure_args="
@@ -53,6 +53,7 @@ pam-devel_package() {
vmove usr/share/man/man3
vmove usr/share/doc
vmove usr/lib/*.so
+ vmove usr/lib/pkgconfig
}
}
pam-libs_package() {
From ab3b58a267ac126cf5c0dcded5aee4504f2741d6 Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:24:11 +0000
Subject: [PATCH 2/3] pam-base: load pam_dumb_runtime_dir.so if present
---
srcpkgs/pam-base/files/system-login | 1 +
srcpkgs/pam-base/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/pam-base/files/system-login b/srcpkgs/pam-base/files/system-login
index 978527109364..2275deba480d 100644
--- a/srcpkgs/pam-base/files/system-login
+++ b/srcpkgs/pam-base/files/system-login
@@ -15,4 +15,5 @@ session include system-auth
session optional pam_motd.so motd=/etc/motd
session optional pam_mail.so dir=/var/mail standard quiet
-session optional pam_elogind.so
+-session optional pam_dumb_runtime_dir.so
session required pam_env.so
diff --git a/srcpkgs/pam-base/template b/srcpkgs/pam-base/template
index 621b1da44129..70dfab9fa996 100644
--- a/srcpkgs/pam-base/template
+++ b/srcpkgs/pam-base/template
@@ -1,7 +1,7 @@
# Template file for 'pam-base'
pkgname=pam-base
version=0.4
-revision=1
+revision=2
short_desc="PAM base configuration files"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="Public Domain"
From f5c2c873d59f64e3898ea4a59072b71977dc274f Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 28 Dec 2021 02:09:14 +0000
Subject: [PATCH 3/3] New package: dumb_runtime_dir-1.0.2
---
srcpkgs/dumb_runtime_dir/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/dumb_runtime_dir/template
diff --git a/srcpkgs/dumb_runtime_dir/template b/srcpkgs/dumb_runtime_dir/template
new file mode 100644
index 000000000000..c57ddcf5c620
--- /dev/null
+++ b/srcpkgs/dumb_runtime_dir/template
@@ -0,0 +1,18 @@
+# Template file for 'dumb_runtime_dir'
+pkgname=dumb_runtime_dir
+version=1.0.2
+revision=1
+build_style=gnu-makefile
+hostmakedepends="pkg-config"
+makedepends="pam-devel"
+depends="pam-base>=0.4.0_2"
+short_desc="Creates an XDG_RUNTIME_DIR on login and never removes it"
+maintainer="Isaac Freund <mail@isaacfreund.com>"
+license="0BSD"
+homepage="https://github.com/ifreund/dumb_runtime_dir"
+distfiles="${homepage}/releases/download/v${version}/dumb_runtime_dir-${version}.tar.gz"
+checksum=884f955fbf1e11810ef1530495916eb62c0093f2d851545b8e80a25fd80a4d3f
+
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: New package: dumb_runtime_dir-1.0.2
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (14 preceding siblings ...)
2022-01-29 19:53 ` [PR PATCH] [Updated] " ifreund
@ 2022-01-29 19:54 ` ifreund
2022-01-29 20:02 ` [PR PATCH] [Merged]: " leahneukirchen
16 siblings, 0 replies; 18+ messages in thread
From: ifreund @ 2022-01-29 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
New comment by ifreund on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1024967887
Comment:
I just released a new version of `dumb_runtime_dir` that uses `pkg-config` at the request of a user. Diffing the 1.0.1 and 1.0.2 binaries produced by xbps-src showed no difference.
~~Using pkg-config to link pam has highlighted something weird about our pam packaging though, the `.pc` files are in the `pam` package instead of `pam-devel`. If you like I'd be happy to move them as part of this PR.~~
This PR also moves the PAM pkgconfig files to the `pam-devel` package where they belong.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Merged]: New package: dumb_runtime_dir-1.0.2
2021-12-28 2:10 [PR PATCH] New package: dumb_runtime_dir-1.0.0 ifreund
` (15 preceding siblings ...)
2022-01-29 19:54 ` ifreund
@ 2022-01-29 20:02 ` leahneukirchen
16 siblings, 0 replies; 18+ messages in thread
From: leahneukirchen @ 2022-01-29 20:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
There's a merged pull request on the void-packages repository
New package: dumb_runtime_dir-1.0.2
https://github.com/void-linux/void-packages/pull/34724
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 18+ messages in thread