* Re: [PR REVIEW] geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
@ 2022-01-27 17:42 ` paper42
2022-01-28 12:18 ` paper42
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-01-27 17:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35254#discussion_r793853257
Comment:
```suggestion
if ! [ ${XBPS_TARGET_MACHINE} = "x86_64" ]; then
```
but on aarch64 systems, it will default to aarch64, so this doesn't really make sense for native compilation, so
a) change this to run only when cross compiling and trust them to detect the architecture correctly
b) set it in configure_args every the time
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
2022-01-27 17:42 ` [PR REVIEW] " paper42
@ 2022-01-28 12:18 ` paper42
2022-02-06 0:03 ` [PR PATCH] [Updated] " teldra
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-01-28 12:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35254#discussion_r794455682
Comment:
This is interesting, do you remember why you added this? "No target to ninja test" is just a harmless warning, this doesn't really make sense to me.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
2022-01-27 17:42 ` [PR REVIEW] " paper42
2022-01-28 12:18 ` paper42
@ 2022-02-06 0:03 ` teldra
2022-02-06 0:34 ` teldra
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: teldra @ 2022-02-06 0:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-geonkick
https://github.com/void-linux/void-packages/pull/35254
geonkick: update to 2.8.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35254.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-geonkick-35254.patch --]
[-- Type: text/x-diff, Size: 2332 bytes --]
From eb9becd88147373902f290e6dd500e28a478bdca Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 22 Jan 2022 11:17:39 +0100
Subject: [PATCH 1/2] geonkick: update to 2.8.1.
---
srcpkgs/geonkick/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/geonkick/template b/srcpkgs/geonkick/template
index e3acec2aa4a0..6929fdab1b68 100644
--- a/srcpkgs/geonkick/template
+++ b/srcpkgs/geonkick/template
@@ -1,6 +1,6 @@
# Template file for 'geonkick'
pkgname=geonkick
-version=2.8.0
+version=2.8.1
revision=1
build_style=cmake
hostmakedepends="pkg-config tar xz"
@@ -9,9 +9,10 @@ makedepends="jack-devel libsndfile-devel rapidjson
short_desc="Free software percussion synthesizer"
maintainer="teldra <teldra@rotce.de>"
license="GPL-3.0-or-later"
-homepage="https://github.com/iurie-sw/geonkick"
-distfiles="https://github.com/iurie-sw/geonkick/archive/v${version}.tar.gz"
-checksum=ec656e76df13ae1226bba6eeb8146c4f0ddbae2c34d28a89db473c16497eaff4
+homepage="https://github.com/free-sm/geonkick"
+changelog="https://github.com/free-sm/geonkick/blob/main/NEWS.md"
+distfiles="https://github.com/free-sm/geonkick/archive/refs/tags/v${version}.tar.gz"
+checksum=813fb10709136ed79403c8baf3d847fce9fbf717fea3c194ad2952e0172e6d45
make_check=extended # No target to "ninja test".
if [[ ! ${XBPS_TARGET_MACHINE} == "x86_64" ]]; then
From 7ffe19044b92d1765d9220f2e956c0a761f00c10 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sun, 30 Jan 2022 08:31:29 +0100
Subject: [PATCH 2/2] geonkick: update to 2.8.1.
---
srcpkgs/geonkick/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/geonkick/template b/srcpkgs/geonkick/template
index 6929fdab1b68..79f8ba451959 100644
--- a/srcpkgs/geonkick/template
+++ b/srcpkgs/geonkick/template
@@ -13,9 +13,8 @@ homepage="https://github.com/free-sm/geonkick"
changelog="https://github.com/free-sm/geonkick/blob/main/NEWS.md"
distfiles="https://github.com/free-sm/geonkick/archive/refs/tags/v${version}.tar.gz"
checksum=813fb10709136ed79403c8baf3d847fce9fbf717fea3c194ad2952e0172e6d45
-make_check=extended # No target to "ninja test".
-if [[ ! ${XBPS_TARGET_MACHINE} == "x86_64" ]]; then
+if [ ${CROSS_BUILD} ]; then
configure_args+=" -DGKICK_ARCHITECTURE=$XBPS_TARGET_MACHINE"
fi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
` (2 preceding siblings ...)
2022-02-06 0:03 ` [PR PATCH] [Updated] " teldra
@ 2022-02-06 0:34 ` teldra
2022-02-06 19:15 ` paper42
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: teldra @ 2022-02-06 0:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-geonkick
https://github.com/void-linux/void-packages/pull/35254
geonkick: update to 2.8.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35254.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-geonkick-35254.patch --]
[-- Type: text/x-diff, Size: 2332 bytes --]
From eb9becd88147373902f290e6dd500e28a478bdca Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 22 Jan 2022 11:17:39 +0100
Subject: [PATCH 1/2] geonkick: update to 2.8.1.
---
srcpkgs/geonkick/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/geonkick/template b/srcpkgs/geonkick/template
index e3acec2aa4a0..6929fdab1b68 100644
--- a/srcpkgs/geonkick/template
+++ b/srcpkgs/geonkick/template
@@ -1,6 +1,6 @@
# Template file for 'geonkick'
pkgname=geonkick
-version=2.8.0
+version=2.8.1
revision=1
build_style=cmake
hostmakedepends="pkg-config tar xz"
@@ -9,9 +9,10 @@ makedepends="jack-devel libsndfile-devel rapidjson
short_desc="Free software percussion synthesizer"
maintainer="teldra <teldra@rotce.de>"
license="GPL-3.0-or-later"
-homepage="https://github.com/iurie-sw/geonkick"
-distfiles="https://github.com/iurie-sw/geonkick/archive/v${version}.tar.gz"
-checksum=ec656e76df13ae1226bba6eeb8146c4f0ddbae2c34d28a89db473c16497eaff4
+homepage="https://github.com/free-sm/geonkick"
+changelog="https://github.com/free-sm/geonkick/blob/main/NEWS.md"
+distfiles="https://github.com/free-sm/geonkick/archive/refs/tags/v${version}.tar.gz"
+checksum=813fb10709136ed79403c8baf3d847fce9fbf717fea3c194ad2952e0172e6d45
make_check=extended # No target to "ninja test".
if [[ ! ${XBPS_TARGET_MACHINE} == "x86_64" ]]; then
From 7ffe19044b92d1765d9220f2e956c0a761f00c10 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sun, 30 Jan 2022 08:31:29 +0100
Subject: [PATCH 2/2] geonkick: update to 2.8.1.
---
srcpkgs/geonkick/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/geonkick/template b/srcpkgs/geonkick/template
index 6929fdab1b68..79f8ba451959 100644
--- a/srcpkgs/geonkick/template
+++ b/srcpkgs/geonkick/template
@@ -13,9 +13,8 @@ homepage="https://github.com/free-sm/geonkick"
changelog="https://github.com/free-sm/geonkick/blob/main/NEWS.md"
distfiles="https://github.com/free-sm/geonkick/archive/refs/tags/v${version}.tar.gz"
checksum=813fb10709136ed79403c8baf3d847fce9fbf717fea3c194ad2952e0172e6d45
-make_check=extended # No target to "ninja test".
-if [[ ! ${XBPS_TARGET_MACHINE} == "x86_64" ]]; then
+if [ ${CROSS_BUILD} ]; then
configure_args+=" -DGKICK_ARCHITECTURE=$XBPS_TARGET_MACHINE"
fi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
` (3 preceding siblings ...)
2022-02-06 0:34 ` teldra
@ 2022-02-06 19:15 ` paper42
2022-02-06 21:04 ` [PR PATCH] [Updated] " teldra
2022-02-10 0:14 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-02-06 19:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35254#issuecomment-1030895744
Comment:
please squash the commits
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
` (4 preceding siblings ...)
2022-02-06 19:15 ` paper42
@ 2022-02-06 21:04 ` teldra
2022-02-10 0:14 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: teldra @ 2022-02-06 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by teldra against master on the void-packages repository
https://github.com/teldra/void-packages update-geonkick
https://github.com/void-linux/void-packages/pull/35254
geonkick: update to 2.8.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35254.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-geonkick-35254.patch --]
[-- Type: text/x-diff, Size: 1486 bytes --]
From 26b11b1ffd3214093518977f4bdb3e9fa4b9aa91 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 22 Jan 2022 11:17:39 +0100
Subject: [PATCH] geonkick: update to 2.8.1.
---
srcpkgs/geonkick/template | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/geonkick/template b/srcpkgs/geonkick/template
index e3acec2aa4a0..79f8ba451959 100644
--- a/srcpkgs/geonkick/template
+++ b/srcpkgs/geonkick/template
@@ -1,6 +1,6 @@
# Template file for 'geonkick'
pkgname=geonkick
-version=2.8.0
+version=2.8.1
revision=1
build_style=cmake
hostmakedepends="pkg-config tar xz"
@@ -9,12 +9,12 @@ makedepends="jack-devel libsndfile-devel rapidjson
short_desc="Free software percussion synthesizer"
maintainer="teldra <teldra@rotce.de>"
license="GPL-3.0-or-later"
-homepage="https://github.com/iurie-sw/geonkick"
-distfiles="https://github.com/iurie-sw/geonkick/archive/v${version}.tar.gz"
-checksum=ec656e76df13ae1226bba6eeb8146c4f0ddbae2c34d28a89db473c16497eaff4
-make_check=extended # No target to "ninja test".
+homepage="https://github.com/free-sm/geonkick"
+changelog="https://github.com/free-sm/geonkick/blob/main/NEWS.md"
+distfiles="https://github.com/free-sm/geonkick/archive/refs/tags/v${version}.tar.gz"
+checksum=813fb10709136ed79403c8baf3d847fce9fbf717fea3c194ad2952e0172e6d45
-if [[ ! ${XBPS_TARGET_MACHINE} == "x86_64" ]]; then
+if [ ${CROSS_BUILD} ]; then
configure_args+=" -DGKICK_ARCHITECTURE=$XBPS_TARGET_MACHINE"
fi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Merged]: geonkick: update to 2.8.1.
2022-01-26 21:42 [PR PATCH] geonkick: update to 2.8.1 teldra
` (5 preceding siblings ...)
2022-02-06 21:04 ` [PR PATCH] [Updated] " teldra
@ 2022-02-10 0:14 ` paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-02-10 0:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
There's a merged pull request on the void-packages repository
geonkick: update to 2.8.1.
https://github.com/void-linux/void-packages/pull/35254
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 8+ messages in thread