* [PR PATCH] nsxiv: update to 29.
@ 2022-03-05 21:04 MouadCharradi
2022-03-05 21:05 ` paper42
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: MouadCharradi @ 2022-03-05 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
There is a new pull request by MouadCharradi against master on the void-packages repository
https://github.com/MouadCharradi/void-packages nsxiv
https://github.com/void-linux/void-packages/pull/35998
nsxiv: update to 29.
#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/35998.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nsxiv-35998.patch --]
[-- Type: text/x-diff, Size: 1024 bytes --]
From 58331abe104033cac3d1d844ff2fca36b20d21a4 Mon Sep 17 00:00:00 2001
From: MouadCharradi <charradimouad58@gmail.com>
Date: Sat, 5 Mar 2022 22:03:52 +0100
Subject: [PATCH] nsxiv: update to 29.
---
srcpkgs/nsxiv/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/nsxiv/template b/srcpkgs/nsxiv/template
index 6ef4a1e207d2..ec561cc9e3b3 100644
--- a/srcpkgs/nsxiv/template
+++ b/srcpkgs/nsxiv/template
@@ -1,6 +1,6 @@
# Template file for 'nsxiv'
pkgname=nsxiv
-version=28
+version=29
revision=1
build_style=gnu-makefile
make_install_target=install-all
@@ -11,7 +11,7 @@ maintainer="Sanjay Pavan <tsppavan7@gmail.com>"
license="GPL-2.0-or-later"
homepage="https://github.com/nsxiv/nsxiv"
distfiles="https://github.com/nsxiv/nsxiv/archive/v${version}.tar.gz"
-checksum=38047f60e51854363dd98fb7b3bc9f1cfa9b7d6f9e8788508b6f1e317328dd75
+checksum=564a17d921172336f7cd463bf313e39f84e4bcf4fdc789326f4112f848aad039
CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2"
pre_build() {
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PR PATCH] nsxiv: update to 29
@ 2022-03-03 13:43 WitherCubes
2022-03-03 14:05 ` tibequadorian
` (12 more replies)
0 siblings, 13 replies; 17+ messages in thread
From: WitherCubes @ 2022-03-03 13:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
There is a new pull request by WitherCubes against master on the void-packages repository
https://github.com/WitherCubes/void-packages master
https://github.com/void-linux/void-packages/pull/35944
nsxiv: update to 29
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/35944.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35944.patch --]
[-- Type: text/x-diff, Size: 1244 bytes --]
From cba3484cc5a589ac3301f58f3bab5bc43a02e1be Mon Sep 17 00:00:00 2001
From: Sanjay Pavan <withercubes@protonmail.com>
Date: Thu, 3 Mar 2022 19:11:30 +0530
Subject: [PATCH] nsxiv: update to 29
---
srcpkgs/nsxiv/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/nsxiv/template b/srcpkgs/nsxiv/template
index 6ef4a1e207d2..bedd29bec9e1 100644
--- a/srcpkgs/nsxiv/template
+++ b/srcpkgs/nsxiv/template
@@ -1,17 +1,17 @@
# Template file for 'nsxiv'
pkgname=nsxiv
-version=28
+version=29
revision=1
build_style=gnu-makefile
make_install_target=install-all
makedepends="libX11-devel imlib2-devel giflib-devel libexif-devel libXft-devel
libwebp-devel"
short_desc="Neo (or New or Not) Simple (or Small or Suckless) X Image Viewer"
-maintainer="Sanjay Pavan <tsppavan7@gmail.com>"
+maintainer="Sanjay Pavan <withercubes@protonmail.com>"
license="GPL-2.0-or-later"
homepage="https://github.com/nsxiv/nsxiv"
distfiles="https://github.com/nsxiv/nsxiv/archive/v${version}.tar.gz"
-checksum=38047f60e51854363dd98fb7b3bc9f1cfa9b7d6f9e8788508b6f1e317328dd75
+checksum="564a17d921172336f7cd463bf313e39f84e4bcf4fdc789326f4112f848aad039"
CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2"
pre_build() {
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
@ 2022-03-03 14:05 ` tibequadorian
2022-03-03 14:12 ` WitherCubes
` (11 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: tibequadorian @ 2022-03-03 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058074635
Comment:
Build error is probably not architecture related, but fails due to cross compiling. Specify `nocross=yes` instead of restricting archs. But preferably you should figure out how to fix cross builds.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
2022-03-03 14:05 ` tibequadorian
@ 2022-03-03 14:12 ` WitherCubes
2022-03-03 14:14 ` paper42
` (10 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: WitherCubes @ 2022-03-03 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by WitherCubes on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058081522
Comment:
I will change it to `nocross=yes` for the moment, I will look into fixing cross builds after discussing with the nsxiv dev team.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
2022-03-03 14:05 ` tibequadorian
2022-03-03 14:12 ` WitherCubes
@ 2022-03-03 14:14 ` paper42
2022-03-03 18:56 ` tibequadorian
` (9 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2022-03-03 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058083358
Comment:
Do not add nocross=yes and remove the architecture restriction, so we can see what's happening.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (2 preceding siblings ...)
2022-03-03 14:14 ` paper42
@ 2022-03-03 18:56 ` tibequadorian
2022-03-03 20:49 ` N-R-K
` (8 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: tibequadorian @ 2022-03-03 18:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058382131
Comment:
This could be relevant: https://github.com/nsxiv/nsxiv/issues/237
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (3 preceding siblings ...)
2022-03-03 18:56 ` tibequadorian
@ 2022-03-03 20:49 ` N-R-K
2022-03-03 21:23 ` paper42
` (7 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: N-R-K @ 2022-03-03 20:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
New comment by N-R-K on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058484119
Comment:
> This could be relevant: [nsxiv/nsxiv#237](https://github.com/nsxiv/nsxiv/issues/237)
Seems to be the case from the [logs](https://github.com/void-linux/void-packages/runs/5407965374?check_suite_focus=true), it compiled fine but then failed when trying to install.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (4 preceding siblings ...)
2022-03-03 20:49 ` N-R-K
@ 2022-03-03 21:23 ` paper42
2022-03-03 22:31 ` tibequadorian
` (6 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2022-03-03 21:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058507680
Comment:
> Seems to be the case from the [logs](https://github.com/void-linux/void-packages/runs/5407965374?check_suite_focus=true), it compiled fine but then failed when trying to install.
For some reason it tries to create options.o and fails before do_install doesn't set cross flags.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (5 preceding siblings ...)
2022-03-03 21:23 ` paper42
@ 2022-03-03 22:31 ` tibequadorian
2022-03-03 22:34 ` N-R-K
` (5 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: tibequadorian @ 2022-03-03 22:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058573487
Comment:
With your patch from https://github.com/nsxiv/nsxiv/pull/238 it does work @N-R-K
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (6 preceding siblings ...)
2022-03-03 22:31 ` tibequadorian
@ 2022-03-03 22:34 ` N-R-K
2022-03-13 22:47 ` paper42
` (4 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: N-R-K @ 2022-03-03 22:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
New comment by N-R-K on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058576790
Comment:
Just removing `all` from the `install` prerequisite should work as well. This is what I do on the gentoo::guru package: `sed -i -e '/^install: / s|: all|:|' Makefile`.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (7 preceding siblings ...)
2022-03-03 22:34 ` N-R-K
@ 2022-03-13 22:47 ` paper42
2022-03-14 12:36 ` WitherCubes
` (3 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2022-03-13 22:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066198097
Comment:
Give the patch an appropriate name and a description, this doesn't tell us anything.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (8 preceding siblings ...)
2022-03-13 22:47 ` paper42
@ 2022-03-14 12:36 ` WitherCubes
2022-03-14 12:37 ` WitherCubes
` (2 subsequent siblings)
12 siblings, 0 replies; 17+ messages in thread
From: WitherCubes @ 2022-03-14 12:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
New comment by WitherCubes on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066735344
Comment:
> Give the patch an appropriate name and a description, this doesn't tell us anything.
I can't come up with a proper name and description, could you please recommend something?
_BTW the issue that is fixed by the patch is [this](https://github.com/nsxiv/nsxiv/issues/237)_
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (9 preceding siblings ...)
2022-03-14 12:36 ` WitherCubes
@ 2022-03-14 12:37 ` WitherCubes
2022-03-15 11:44 ` N-R-K
2022-03-18 1:50 ` WitherCubes
12 siblings, 0 replies; 17+ messages in thread
From: WitherCubes @ 2022-03-14 12:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
New comment by WitherCubes on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066735344
Comment:
> Give the patch an appropriate name and a description, this doesn't tell us anything.
I can't come up with a proper name and description, could you please recommend something?
_BTW the issue that is fixed by the patch is [this](https://github.com/nsxiv/nsxiv/issues/237)._
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (10 preceding siblings ...)
2022-03-14 12:37 ` WitherCubes
@ 2022-03-15 11:44 ` N-R-K
2022-03-18 1:50 ` WitherCubes
12 siblings, 0 replies; 17+ messages in thread
From: N-R-K @ 2022-03-15 11:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New comment by N-R-K on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1067893315
Comment:
Description: "Don't rebuild options.o when installing" (?)
Name: idk, "Fix install" maybe.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: nsxiv: update to 29
2022-03-03 13:43 [PR PATCH] " WitherCubes
` (11 preceding siblings ...)
2022-03-15 11:44 ` N-R-K
@ 2022-03-18 1:50 ` WitherCubes
12 siblings, 0 replies; 17+ messages in thread
From: WitherCubes @ 2022-03-18 1:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
New comment by WitherCubes on void-packages repository
https://github.com/void-linux/void-packages/pull/35944#issuecomment-1071942593
Comment:
I have added the proper patch name and description.
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-03-18 1:50 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-05 21:04 [PR PATCH] nsxiv: update to 29 MouadCharradi
2022-03-05 21:05 ` paper42
2022-03-06 14:51 ` [PR PATCH] [Closed]: " MouadCharradi
2022-03-06 14:51 ` MouadCharradi
-- strict thread matches above, loose matches on Subject: below --
2022-03-03 13:43 [PR PATCH] " WitherCubes
2022-03-03 14:05 ` tibequadorian
2022-03-03 14:12 ` WitherCubes
2022-03-03 14:14 ` paper42
2022-03-03 18:56 ` tibequadorian
2022-03-03 20:49 ` N-R-K
2022-03-03 21:23 ` paper42
2022-03-03 22:31 ` tibequadorian
2022-03-03 22:34 ` N-R-K
2022-03-13 22:47 ` paper42
2022-03-14 12:36 ` WitherCubes
2022-03-14 12:37 ` WitherCubes
2022-03-15 11:44 ` N-R-K
2022-03-18 1:50 ` WitherCubes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).