[PR PATCH] neovim: remove alternatives.

[PR PATCH] neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

There is a new pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages neovim
https://github.com/void-linux/void-packages/pull/36165

neovim: remove alternatives.
Closes #36164

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36165.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovim-36165.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From 8c4fde7084afc83b111487485c33874905fbf0d7 Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Wed, 16 Mar 2022 09:03:57 +1100
Subject: [PATCH] neovim: remove alternatives.

closes #36164
---
 srcpkgs/neovim/template | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index 28cbc7e363cb..2855af09f669 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,7 +1,7 @@
 # Template file for 'neovim'
 pkgname=neovim
 version=0.6.1
-revision=1
+revision=2
 build_style=cmake
 build_helper="qemu"
 configure_args="-DCMAKE_BUILD_TYPE=Release"
@@ -16,14 +16,6 @@ homepage="https://neovim.io"
 distfiles="https://github.com/neovim/neovim/archive/v${version}.tar.gz"
 checksum=dd882c21a52e5999f656cae3f336b5fc702d52addd4d9b5cd3dc39cfff35e864
 
-alternatives="
- vi:vi:/usr/bin/nvim
- vi:vi.1:/usr/share/man/man1/nvim.1
- vi:view:/usr/bin/nvim
- vi:view.1:/usr/share/man/man1/nvim.1
- vim:vim:/usr/bin/nvim
- vim:vim.1:/usr/share/man/man1/nvim.1"
-
 pre_configure() {
 	vsed -i runtime/CMakeLists.txt \
 		-e "s|\".*/bin/nvim|\${CMAKE_CROSSCOMPILING_EMULATOR} &|g"

Re: neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068754834

Comment:
> If we have bash as sh and vim as vi

If Neovim can be Vim, Bash can be Dash.

```bash
# Template file for 'dash'
alternatives="
 sh:sh:/usr/bin/dash
 sh:sh.1:/usr/share/man/man1/dash.1"

# Template file for 'bash'
alternatives="
 sh:sh:/usr/bin/bash
 sh:sh.1:/usr/share/man/man1/bash.1"

# Template file for 'neovim'
alternatives="
  vi:vi:/usr/bin/nvim
  vi:vi.1:/usr/share/man/man1/nvim.1
```

The above would be logically consistent.

Re: neovim: remove alternatives.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068782911

Comment:
Making dash bash breaks all scripts with bash shebang, installing nvim before vim makes it the default provider for the vim alternative group which you can easily fix and doesn't break half the system, all it does is make the cursor werid on your system.

Re: neovim: remove alternatives.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068782911

Comment:
Making dash bash breaks all scripts with bash shebang, installing nvim before vim makes it the default provider for the vim alternative group which you can easily fix with xbps-alternatives, avoid by installing vim first (instead of alphabetically sorting xbps-install arguments or by just not installing nvim. It also doesn't break half the system, all it does is make the cursor werid on your system.

Re: neovim: remove alternatives.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068782911

Comment:
Making dash bash breaks all scripts with bash shebang, installing nvim before vim makes it the default provider for the vim alternative group which you can easily fix with xbps-alternatives, avoid by installing vim first (instead of alphabetically sorting xbps-install arguments or by just not installing nvim. It also doesn't break half the system, all it does is make the cursor werid on your system.

There would be no point in alternatives, if the requirement would be that they are 100% compatible, some things have stricter requirements than others, like shells, while other more interactive programs don't.

Re: neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068878584

Comment:
> There would be no point in alternatives, if the requirement would be that they are 100% compatible

That’s fair, but what if we just did away with the symlink to `vim`? Neovim can have the `vi` symlink, and the result would be equal to how `alternatives` is handled in the shells.

It violates user expectation for `vim`, when typed out on any terminal in any circumstance, to *ever* result in Neovim being opened, unless the environment is specifically configured for such a thing.

IIRC, Void isn’t the only distro which symlinks `dash` to `/bin/sh`. Void, however, *is* (literally) the only distro which symlinks `nvim` to `vim`. It makes about as much sense as symlinking `bash` to `dash`.

Re: neovim: remove alternatives.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068903816

Comment:
> > There would be no point in alternatives, if the requirement would be that they are 100% compatible
> 
> That’s fair, but what if we just did away with the symlink to `vim`? Neovim can have the `vi` symlink, and the result would be equal to how `alternatives` is handled in the shells.

I already explained in https://github.com/void-linux/void-packages/issues/36164#issuecomment-1068583988 why this is not without a problem. Having vim point to nvim can only happen in specific circumstances:
a) you manually modified alternatives
b) you installed neovim first

`b` can be a bit surprising, but it doesn't matter, people often don't even notice they are using nvim and not vim. 

> It violates user expectation for `vim`, when typed out on any terminal in any circumstance, to _ever_ result in Neovim being opened, unless the environment is specifically configured for such a thing.

And as we already discussed, it doesn't matter to regular users. neovim and vim are basically drop in replacements of each other.

Re: [PR PATCH] [Updated] neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

There is an updated pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages neovim
https://github.com/void-linux/void-packages/pull/36165

neovim: remove alternatives.
Closes #36164

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36165.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovim-36165.patch --]
[-- Type: text/x-diff, Size: 1046 bytes --]

From 3fd93c3d4080d2bfe7f0ed15757233fe6beeef13 Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Wed, 16 Mar 2022 09:03:57 +1100
Subject: [PATCH] neovim: remove alternatives.

closes #36164
---
 srcpkgs/neovim/template | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index 28cbc7e363cb..8137a88f9ef8 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,7 +1,7 @@
 # Template file for 'neovim'
 pkgname=neovim
 version=0.6.1
-revision=1
+revision=2
 build_style=cmake
 build_helper="qemu"
 configure_args="-DCMAKE_BUILD_TYPE=Release"
@@ -18,11 +18,7 @@ checksum=dd882c21a52e5999f656cae3f336b5fc702d52addd4d9b5cd3dc39cfff35e864
 
 alternatives="
  vi:vi:/usr/bin/nvim
- vi:vi.1:/usr/share/man/man1/nvim.1
- vi:view:/usr/bin/nvim
- vi:view.1:/usr/share/man/man1/nvim.1
- vim:vim:/usr/bin/nvim
- vim:vim.1:/usr/share/man/man1/nvim.1"
+ vi:vi.1:/usr/share/man/man1/nvim.1"
 
 pre_configure() {
 	vsed -i runtime/CMakeLists.txt \

Re: neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1069799662

Comment:
Yesterday, I suggested [doing](https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068754834):

```bash
# Template file for 'dash'
alternatives="
 sh:sh:/usr/bin/dash
 sh:sh.1:/usr/share/man/man1/dash.1"

# Template file for 'bash'
alternatives="
 sh:sh:/usr/bin/bash
 sh:sh.1:/usr/share/man/man1/bash.1"

# Template file for 'neovim'
alternatives="
  vi:vi:/usr/bin/nvim
  vi:vi.1:/usr/share/man/man1/nvim.1
```

I’ve updated the PR accordingly, to minimize any confusion.

I simply don’t recognize any level of logical consistency in the way Neovim is allowed to easily override `vim` on Void systems. There is no logical difference between allowing this and allowing `bash` to override `dash`. It’s simply not what most users want or expect, edge cases from Debian aside.

Re: neovim: remove alternatives.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

New comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1069799662

Comment:
Yesterday, I suggested [doing](https://github.com/void-linux/void-packages/pull/36165#issuecomment-1068754834):

```bash
# Template file for 'dash'
alternatives="
 sh:sh:/usr/bin/dash
 sh:sh.1:/usr/share/man/man1/dash.1"

# Template file for 'bash'
alternatives="
 sh:sh:/usr/bin/bash
 sh:sh.1:/usr/share/man/man1/bash.1"

# Template file for 'neovim'
alternatives="
  vi:vi:/usr/bin/nvim
  vi:vi.1:/usr/share/man/man1/nvim.1
```

I’ve updated the PR accordingly, to minimize any confusion.

I simply don’t recognize any level of logical consistency in the way Neovim is allowed to easily override `vim` on Void systems. There is no logical difference between allowing this and allowing `bash` to override `dash`. It’s simply not what most users want or expect, edge cases from Debian aside.

Re: [PR PATCH] [Closed]: neovim: remove alternatives.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

There's a closed pull request on the void-packages repository

neovim: remove alternatives.
https://github.com/void-linux/void-packages/pull/36165

Description:
Closes #36164

#### Testing the changes
- I tested the changes in this PR: **YES**

Re: [RFC] neovim: remove alternatives.

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1079989675

Comment:
I think this is wrong. :+1: for closing.

Re: [RFC] neovim: remove alternatives.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36165#issuecomment-1080014046

Comment:
I agree with @Vaelatern and because there 3 team members agree on this, I am closing this PR.

Re: [PR PATCH] [Closed]: [RFC] neovim: remove alternatives.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

There's a closed pull request on the void-packages repository

[RFC] neovim: remove alternatives.
https://github.com/void-linux/void-packages/pull/36165

Description:
Closes #36164

#### Testing the changes
- I tested the changes in this PR: **YES**