[PR PATCH] gawk: fix tests

[PR PATCH] gawk: fix tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages gawk-fix-tests
https://github.com/void-linux/void-packages/pull/31497

gawk: fix tests
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-fix-tests-31497.patch --]
[-- Type: text/x-diff, Size: 660 bytes --]

From 1cc121ec759beab6576688bda2c6e0f7146b5dbf Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 17 May 2021 21:15:23 +0200
Subject: [PATCH] gawk: fix tests

---
 srcpkgs/gawk/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index 0a79c2ca2c5e..793e94a1e03c 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -20,6 +20,8 @@ alternatives="
 
 pre_check() {
 	vsed -i 's/done | more/done/g' test/Makefile
+	vsed -i 's/en_US.ISO-8859-1//' test/localenl.sh
+	vsed -i '/^LC_ALL=en_US.ISO-8859-1 passed$/d' test/localenl.ok
 
 	case "$XBPS_TARGET_MACHINE" in
 		*-musl)

Re: gawk: fix tests

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-860885081

Comment:
Is this necessary on glibc and musl?

Re: gawk: fix tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-860919381

Comment:
tests that this PR fixes are skipped on musl:
```
======== Done with machine-specific tests ========
/bin/sh: line 5: locale: command not found
%%%%%%%%%% Inadequate locale support: skipping charset tests.
%%%%%%%%%% At least en_US.UTF-8, fr_FR.UTF-8, ru_RU.UTF-8 and ja_JP.UTF-8 are needed.
```

Re: gawk: fix tests

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-861530470

Comment:
If we merge #26142 or similar we can look into improving this. Can you leave a comment in the commit message or template about this?

Re: [PR PATCH] [Updated] gawk: fix tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages gawk-fix-tests
https://github.com/void-linux/void-packages/pull/31497

gawk: fix tests
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-fix-tests-31497.patch --]
[-- Type: text/x-diff, Size: 816 bytes --]

From ccad6b9cca302dc86d0a39f5a19ba8f5ed0bd19e Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 17 May 2021 21:15:23 +0200
Subject: [PATCH] gawk: fix tests

---
 srcpkgs/gawk/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index 0a79c2ca2c5e..b922097b01f7 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -21,6 +21,11 @@ alternatives="
 pre_check() {
 	vsed -i 's/done | more/done/g' test/Makefile
 
+	# This fixes tests on glibc, relevant tests on musl are disabled
+	# because the locale command doesn't exist.
+	vsed -i 's/en_US.ISO-8859-1//' test/localenl.sh
+	vsed -i '/^LC_ALL=en_US.ISO-8859-1 passed$/d' test/localenl.ok
+
 	case "$XBPS_TARGET_MACHINE" in
 		*-musl)
 			vsed -i '/testext/d' test/Makefile

Re: gawk: fix tests

[sgn]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-862837941

Comment:
Hm, on musl, with:
```
cat >some-bin/locale <<\EOF
#!/bin/sh
printf '%s.UTF-8\n' C en_US fr_FR ru_RU
EOF
```

a test failed because musl doesn't consider `U+1680` as space character.

Re: gawk: fix tests

[sgn]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-862837941

Comment:
Hm, on musl, with:
```sh
cat >some-bin/locale <<\EOF
#!/bin/sh
printf '%s.UTF-8\n' C en_US fr_FR ru_RU
EOF
```

a test failed because musl doesn't consider `U+1680` as space character.

Re: gawk: fix tests

[sgn]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31497#issuecomment-862837941

Comment:
Hm, on musl, with:
```sh
cat >some-bin/locale <<\EOF
#!/bin/sh
printf '%s.UTF-8\n' C en_US fr_FR ru_RU ja_JP
EOF
```

a test failed because musl doesn't consider `U+1680` as space character.

Re: [PR PATCH] [Updated] gawk: fix tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages gawk-fix-tests
https://github.com/void-linux/void-packages/pull/31497

gawk: fix tests
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-fix-tests-31497.patch --]
[-- Type: text/x-diff, Size: 821 bytes --]

From e3e8545b12c0d18ba38c8e69112a9e4464050110 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 29 Mar 2022 23:12:55 +0200
Subject: [PATCH] gawk: fix tests

---
 srcpkgs/gawk/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index 0a79c2ca2c5e..b922097b01f7 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -21,6 +21,11 @@ alternatives="
 pre_check() {
 	vsed -i 's/done | more/done/g' test/Makefile
 
+	# This fixes tests on glibc, relevant tests on musl are disabled
+	# because the locale command doesn't exist.
+	vsed -i 's/en_US.ISO-8859-1//' test/localenl.sh
+	vsed -i '/^LC_ALL=en_US.ISO-8859-1 passed$/d' test/localenl.ok
+
 	case "$XBPS_TARGET_MACHINE" in
 		*-musl)
 			vsed -i '/testext/d' test/Makefile

Re: [PR PATCH] [Merged]: gawk: fix tests

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

There's a merged pull request on the void-packages repository

gawk: fix tests
https://github.com/void-linux/void-packages/pull/31497

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->