Re: [PR PATCH] [Updated] python3: enable bluetooth sockets

[tornaria <tornaria@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages python3-enable-bluetooth
https://github.com/void-linux/void-packages/pull/36640

python3: enable bluetooth sockets
#### Testing the changes
- I tested the changes in this PR: **YES**

I've been using `python3-bluez` for bluetooth sockets, but this package was removed because it was not compatible with python 3.10 (this has been fixed upstream, but not released yet, see #33626)

TIL that bluetooth sockets are available in python stdlib. However, they need to be enabled. That's what this PR does.

Note, however, that this seems to create a circular build dependency, since `bluez` hostmakedepends on `python3-docutils`for its `rst2man` tool. I don't know if this would cause any trouble, and if so what is the standard solution. The tarball of `bluez`contains prebuilt manpages; although a couple would need to be patched for paths, this ought to be easy (I could do it).

CC: @ahesford

A patch file from https://github.com/void-linux/void-packages/pull/36640.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-enable-bluetooth-36640.patch --]
[-- Type: text/x-diff, Size: 3717 bytes --]

From 8e3b6848c94c9ebed0c236327ec5e996dc626854 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Apr 2022 10:25:40 -0300
Subject: [PATCH 1/2] python3: enable bluetooth sockets

---
 srcpkgs/python3/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3/template b/srcpkgs/python3/template
index ed15b88359ff..3bb66e6f5d14 100644
--- a/srcpkgs/python3/template
+++ b/srcpkgs/python3/template
@@ -4,7 +4,7 @@
 #
 pkgname=python3
 version=3.10.4
-revision=1
+revision=2
 wrksrc="Python-${version}"
 build_style="gnu-configure"
 configure_args="--enable-shared --enable-ipv6
@@ -14,7 +14,8 @@ configure_args="--enable-shared --enable-ipv6
 pycompile_dirs="usr/lib/python${version%.*}"
 hostmakedepends="pkgconf"
 makedepends="libffi-devel readline-devel gdbm-devel openssl-devel
- expat-devel sqlite-devel bzip2-devel zlib-devel liblzma-devel"
+ expat-devel sqlite-devel bzip2-devel zlib-devel liblzma-devel
+ libbluetooth-devel"
 depends="ca-certificates"
 checkdepends="$depends iana-etc"
 short_desc="Python programming language (${version%.*} series)"

From 9cc17e3b5c27ddf7df70fa7f6a9b026eaa9794e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Apr 2022 17:17:39 -0300
Subject: [PATCH 2/2] bluez: remove makedepends on python3-docutils

---
 .../patches/0010-dont-require-rst2man.patch   | 32 +++++++++++++++++++
 srcpkgs/bluez/template                        |  2 +-
 2 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/bluez/patches/0010-dont-require-rst2man.patch

diff --git a/srcpkgs/bluez/patches/0010-dont-require-rst2man.patch b/srcpkgs/bluez/patches/0010-dont-require-rst2man.patch
new file mode 100644
index 000000000000..b05dfec21793
--- /dev/null
+++ b/srcpkgs/bluez/patches/0010-dont-require-rst2man.patch
@@ -0,0 +1,32 @@
+--- a/configure.ac	2022-03-16 12:06:20.000000000 -0300
++++ b/configure.ac	2022-04-11 09:27:53.726166927 -0300
+@@ -335,9 +335,6 @@
+ 					[enable_manpages=${enableval}])
+ if (test "${enable_manpages}" != "no"); then
+ 	AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no")
+-	if (test "${RST2MAN}" = "no" ); then
+-		AC_MSG_ERROR([rst2man is required])
+-	fi
+ fi
+ AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" != "no")
+ AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" &&
+--- a/src/bluetoothd.8	2022-03-16 12:17:56.000000000 -0300
++++ b/src/bluetoothd.8	2022-04-11 17:11:10.093067361 -0300
+@@ -56,7 +56,7 @@
+ .TP
+ .B \-f\fP,\fB  \-\-configfile
+ Specifies an explicit config file path instead of relying
+-on the default path(\fI/usr/local/etc/bluetooth/main.conf\fP)
++on the default path(\fI/etc/bluetooth/main.conf\fP)
+ for the config file.
+ .UNINDENT
+ .INDENT 0.0
+@@ -90,7 +90,7 @@
+ .SH FILES
+ .INDENT 0.0
+ .TP
+-.B \fI/usr/local/etc/bluetooth/main.conf\fP
++.B \fI/etc/bluetooth/main.conf\fP
+ Location of the global configuration file.
+ .UNINDENT
+ .SH RESOURCES
diff --git a/srcpkgs/bluez/template b/srcpkgs/bluez/template
index e9827e8e1d95..43a6404079b7 100644
--- a/srcpkgs/bluez/template
+++ b/srcpkgs/bluez/template
@@ -7,7 +7,7 @@ configure_args="--with-udevdir=/usr/lib/udev --disable-systemd
  --enable-sixaxis --enable-threads --enable-library --enable-deprecated
  --enable-external-ell $(vopt_enable mesh) $(vopt_enable nfc)
  $(vopt_enable experimental)"
-hostmakedepends="automake flex libtool pkg-config python3-docutils"
+hostmakedepends="automake flex libtool pkg-config"
 makedepends="cups-devel eudev-libudev-devel libglib-devel libical-devel
  readline-devel ell-devel $(vopt_if mesh json-c-devel)"
 short_desc="Bluetooth tools and daemons"