Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3: enable bluetooth sockets
Date: Wed, 13 Apr 2022 17:22:15 +0200	[thread overview]
Message-ID: <20220413152215.pGeJcL-GBwzMD26MlqSFOr_u3MB6PKHZV3du2WNXXBw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36640@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1930 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/36640#issuecomment-1098184798

Comment:
> I don't think we should vender these headers here. My hope was that kernel-libc-headers would be easy to modify to add those headers, but looking through the kernel headers has convinced me that we don't want the trouble.

I'm sorry, I pushed without commenting. That was meant as a PoC only, indeed only a few structs and defines are needed. Everything seems to be part of the stable kernel ABI (because come on, they can't change these numbers or struct layout without breaking user space), but they are not exported as a kernel API (that's why they are not in kernel-llibc-headers) and as you say they don't look like they are meant for use in user space; the bluez project seems to have equal named but different headers on the kernel side and on the user side.

> I think you should drop the most recent two commits and go back to pulling in `libbluetooth-devel` in `python3` and breaking the (default) cycle in `bluez`.

Sure, that seems an easy option here.

----

About the circular dependency: https://wiki.gentoo.org/wiki/User:Sam/Portage_help/Circular_dependencies#Python_and_bluez

I wonder if there is a different (more general) way to break dependency cycles like this. Some packages have `chroot-*` versions for bootstrapping. Either `bluez` or `python` could have bootstrap packages, etc. although that could be a maintainance burden.

What about having a "bootstrap" build option (as opposed to a separate template) which has fewer dependencies, then have xbps-src use the bootstrap option to break circular dependencies. In this case, for instance, the difference for bootstrap bluez would be just removing `python3-docutils` from `hostmakedepends` and the difference for bootstrap python3 would be just removing `libbluetooth-devel` from `makedepends`.

  parent reply	other threads:[~2022-04-13 15:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 19:10 [PR PATCH] " tornaria
2022-04-11 19:31 ` paper42
2022-04-11 19:32 ` paper42
2022-04-11 20:20 ` [PR PATCH] [Updated] " tornaria
2022-04-11 20:36 ` tornaria
2022-04-12  4:33 ` classabbyamp
2022-04-12 21:33 ` tornaria
2022-04-12 23:01 ` ahesford
2022-04-12 23:01 ` ahesford
2022-04-13  4:21 ` [PR PATCH] [Updated] " tornaria
2022-04-13 13:34 ` ahesford
2022-04-13 15:22 ` tornaria [this message]
2022-04-13 15:57 ` [PR PATCH] [Updated] " tornaria
2022-04-13 16:11 ` tornaria
2022-04-14 15:56 ` ahesford
2022-06-08  2:08 ` ahesford
2022-09-06  2:16 ` github-actions
2022-09-06  2:19 ` classabbyamp
2022-09-18 19:46 ` [PR PATCH] [Closed]: " ahesford
2022-09-18 19:46 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413152215.pGeJcL-GBwzMD26MlqSFOr_u3MB6PKHZV3du2WNXXBw@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).