[PR PATCH] New package: ncspot-0.1.4

[PR PATCH] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

There is a new pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]

From 3e64cc2c710f960fff68b7f424cfd9d31a421b31 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..d3f48c9d0a2
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,18 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config python3"
+makedepends="pulseaudio-devel dbus-devel libressl-devel ncurses-devel"
+depends="pulseaudio dbus libxcb libssl48 ncurses"
+short_desc="Cross-platform ncurses Spotify client written in Rust."
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="https://github.com/hrkfdn/${pkgname}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-654218144

Comment:
Apparently not as cross-platform as advertised...

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1178 bytes --]

From b12ef86fef285824931fe9b8baa26ffafc688e66 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..e6e8b9a12c0
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,19 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config python3"
+makedepends="pulseaudio-devel dbus-devel libressl-devel ncurses-devel"
+depends="pulseaudio dbus libxcb libssl48 ncurses"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+archs="i686 x86_64 x86_64-musl"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="https://github.com/hrkfdn/${pkgname}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-654218144

Comment:
[Apparently not as cross-platform as advertised](https://travis-ci.org/github/void-linux/void-packages/builds/705378524)...

Re: [PR REVIEW] New package: ncspot-0.1.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450204612

Comment:
All of these `depends` should be detected automatically as dynamic libraries that this package is linked to, so you don't need to list it here. You might want to have `libxcb-devel` in `makedepends` as well.

Re: [PR REVIEW] New package: ncspot-0.1.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450204865

Comment:
Why is it restricted to these? If cross compiling isn't working, you probably want `nocross=yes`, instead.

Re: [PR REVIEW] New package: ncspot-0.1.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450205394

Comment:
`distfiles="${homepage}/...`

Re: [PR REVIEW] New package: ncspot-0.1.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450204612

Comment:
All of these `depends` should be detected automatically as dynamic libraries that this package is linked to, so you don't need to list them here. You might want to have `libxcb-devel` in `makedepends` as well.

Re: [PR REVIEW] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New review comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450208867

Comment:
[The other archs fail](https://travis-ci.org/github/void-linux/void-packages/builds/705378524), I could also use the same construct as spotifyd if that's desired?
```
case "$XBPS_TARGET_MACHINE" in
	aarch64-musl) broken="https://travis-ci.org/void-linux/void-packages/jobs/..." ;;
esac
``` 

Re: [PR REVIEW] New package: ncspot-0.1.4

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450212734

Comment:
If it's broken specifically for one arch that's fine, but if it works when compiling natively, but not when cross compiling, it should be marked as nocross. Usually you use archs only when it's a platform or ISA level support thing. If it's broken on all cross compiling cases, the issue is likely with the "cross" part

Re: [PR REVIEW] New package: ncspot-0.1.4

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450407541

Comment:
Error is `Os { code: 8, kind: Other, message: "Exec format error" }`, so this *is* cross build issue, and have good chance to be build natively on arm. Please mark nocross.

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1550 bytes --]

From 30b97d231e7b0dee8be1057e4de0a92eeeaf3e75 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..92956bcae5d
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,31 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config python3"
+configure_ars="--no-default-features"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+archs="nocross"
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1546 bytes --]

From 17f59798952f0f2e38e4221ee9ae04efeb0c7e35 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..93572feed12
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,31 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config python3"
+configure_ars="--no-default-features"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+nocross=yes
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1547 bytes --]

From 3f7f5c14071b81f90f4c3686f1f5ea650c9eaeee Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..3b782e35c43
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,31 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config python3"
+configure_args="--no-default-features"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+nocross=yes
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1547 bytes --]

From b81ace51dd6b0bf8c16a43491d8c4d299dcf8ed8 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.1.4

---
 srcpkgs/ncspot/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..7744917d141
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,31 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.1.4
+revision=1
+build_style=cargo
+configure_args="--no-default-features"
+hostmakedepends="pkg-config python3"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=bcc4026f51fe4be7351b6e6cd124a5fd4b3af8b6a58f23a0599ce5f34fc4416e
+nocross=yes
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New review comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#discussion_r450809736

Comment:
Done.

Re: New package: ncspot-0.1.4

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-663925299

Comment:
Conflicts with #23817

Re: [PR PATCH] [Updated] New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.1.4
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1572 bytes --]

From fc8dc3562a0ba02ab505cb3f721f3549250d2167 Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.2.0

---
 srcpkgs/ncspot/template | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..223c31afda8
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,31 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.2.0
+revision=1
+build_style=cargo
+configure_args="--no-default-features"
+hostmakedepends="pkg-config python3"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=876553020e53b8bbf7dac1ddf18f69115d622b302506ce5dc1c3bac1b59ef39b
+nocross="ncurses exec format error"
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ncspot-0.1.4

[rien]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-664286896

Comment:
Updated to 0.2.0

Re: New package: ncspot-0.2.0

[rien]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-664331618

Comment:
@Chocimier @ericonr this PR is ready for a new review; I've updated ncspot to 0.2.0 and confirmed it builds on my machine.

What is the default behavior for the `vopt_if` statements? Which options will be enabled in the binary repositories? If none are enabled, then this package is a bit useless (the default configuration will print the raw audio to stdout instead of playing trough pulse or alsa).

Re: [PR PATCH] [Updated] New package: ncspot-0.2.0

[rien]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by rien against master on the void-packages repository

https://github.com/rien/void-packages new/ncspot-0.1.4
https://github.com/void-linux/void-packages/pull/23415

New package: ncspot-0.2.0
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

A patch file from https://github.com/void-linux/void-packages/pull/23415.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/ncspot-0.1.4-23415.patch --]
[-- Type: text/x-diff, Size: 1736 bytes --]

From 4bdc2b15c3a3713449c8ed85f9c9f0ef865eba5b Mon Sep 17 00:00:00 2001
From: Rien Maertens <rien.maertens@posteo.be>
Date: Mon, 6 Jul 2020 14:08:31 +0200
Subject: [PATCH] New package: ncspot-0.2.0

---
 srcpkgs/ncspot/template | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 00000000000..e080712be44
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,35 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.2.0
+revision=1
+build_style=cargo
+configure_args="--no-default-features"
+hostmakedepends="pkg-config python3"
+makedepends="libressl-devel ncurses-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client written in Rust"
+maintainer="Rien Maertens <rien.maertens@posteo.be>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot/"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=876553020e53b8bbf7dac1ddf18f69115d622b302506ce5dc1c3bac1b59ef39b
+nocross="ncurses exec format error"
+
+build_options="libxcb dbus alsa pulseaudio"
+build_options_default="libxcb dbus alsa pulseaudio"
+desc_option_libxcb="Enable support for X clipboard access"
+
+_features="cursive/pancurses-backend"
+_features+="$(vopt_if libxcb ',share_clipboard')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if dbus ',mpris')"
+
+if [ "$_features" ]; then
+	configure_args+=" --features $_features"
+fi
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: ncspot-0.2.0

[rien]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-664390787

Comment:
After looking at the `spotifyd` template, I've seen you can specify `build_options_default` to enable suggested features. I've enabled both `alsa` and `pulse` by default (as is the case with `spotifyd`).

Re: New package: ncspot-0.2.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/23415#issuecomment-1100787101

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: ncspot-0.2.0

[rien]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There's a closed pull request on the void-packages repository

New package: ncspot-0.2.0
https://github.com/void-linux/void-packages/pull/23415

Description:
This packages [ncspot](https://github.com/hrkfdn/ncspot), a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: `ncspot-pulseaudio` and `ncspot-alsa`?

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-674384189

Comment:
I'm going to close this PR in hopes that #23415 will be merged.

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-674384189

Comment:
I'm going close this PR in hopes that #23415 will be merged.

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-664248243

Comment:
Hey! Yeh, your template is quite nice, I tend to write my templates from the ground up, and leave optional features up to the user to figure out, If you were to update it to `0.2.0` that wouldn't be a bad Idea, sad that it got lost and never got merged, I'd recommend you, re-request review and see what happens from there, if and when you update your PR to `0.2.0` I'll close this PR

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-664248243

Comment:
Hey! Yeh, you template is quite nice, I tend to write my template from the ground up, and leave optional features up to the user to figure out, If you were to update it to `0.2.0` that wouldn't be a bad Idea, sad that it got lost and never got merged, I'd recommend you, re-request review and see what happens from there, if and when you update your PR to `0.2.0` I'll close this PR

Re: New Package: ncspot-0.2.0.

[rien]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by rien on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-664212884

Comment:
Hi there! ncspot has different audio backends (alsa, pulse, ...) that's why my PR has the `vopt_if` statements in them (just like the `spotifyd` template, which is very similar).

I can update my PR if you'd like. It was ready for review but I guess it disappeared into he backlog :)

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-663932384

Comment:
For now I'll just make the requested edits

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-663932030

Comment:
Understandable, although, #23415 seems to have a much nicer template, I'm a bit new so I figured it would be, I don't know if I'll close this PR or not yet, but if #23415 got updated for `"0.2.0"` I most likely would, seeing as "`0.2.0`" is the stable release for everything other than `nixpkgs` and `DPorts`

Re: New Package: ncspot-0.2.0.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-663925289

Comment:
Also, conflicts with #23415

Re: New Package: ncspot-0.2.0.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-663925237

Comment:
No, the issue here is not restricted archs, it is that the package is nocross (ie, will need some fiddling with `qemu-user-static` and stuff to generate the offending data). Please change the `archs=` line to `nocross="ncurses exec format error"` or something of that nature.

Re: New Package: ncspot-0.2.0.

[ThatGeekyWeeb]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

New comment by ThatGeekyWeeb on void-packages repository

https://github.com/void-linux/void-packages/pull/23817#issuecomment-663806559

Comment:
Builds on arm based aches fail due to
> `thread 'main' panicked at '/builddir/ncspot-0.2.0/target/aarch64-unknown-linux-gnu/release/build/ncurses-00645f4d6448e2e2/out/chtype_size failed: Os { code: 8, kind: Other, message: "Exec format error" }', /host/cargo/registry/src/github.com-1ecc6299db9ec823/ncurses-5.99.0/build.rs:106:20`

I cannot confirm the cause of this, nor can I figure out how to fix it,
even cloning `makedepends` and `hostmakedepends` did not resolve the issue, thus I am restricting the arches
> `makedepends="${hostmakedepends}"`