* [PR PATCH] qView: update to 5.0
@ 2022-03-28 9:42 mustaqimM
2022-03-28 18:13 ` newbluemoon
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: mustaqimM @ 2022-03-28 9:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
There is a new pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages update_qview
https://github.com/void-linux/void-packages/pull/36391
qView: update to 5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/36391.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_qview-36391.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]
From a915afa2bb2402d59ef67940c945ef6272e08331 Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Mon, 28 Mar 2022 11:41:06 +0200
Subject: [PATCH] qView: update to 5.0
---
srcpkgs/qView/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qView/template b/srcpkgs/qView/template
index 1048d033ab57..6c014d9d3ad0 100644
--- a/srcpkgs/qView/template
+++ b/srcpkgs/qView/template
@@ -1,6 +1,6 @@
# Template file for 'qView'
pkgname=qView
-version=4.0
+version=5.0
revision=1
build_style=qmake
hostmakedepends="qt5-host-tools qt5-qmake"
@@ -10,4 +10,4 @@ maintainer="newbluemoon <blaumolch@mailbox.org>"
license="GPL-3.0-or-later"
homepage="https://interversehq.com/qview/"
distfiles="https://github.com/jurplel/qView/archive/${version}.tar.gz"
-checksum=04f986a03bff1b957ac72f266f58a8a7fd403e4606a5bc00ad4a3130d14f11c3
+checksum=c43a69f31c7b5011721c4509093044203fd81edb9046eafa32aa0a6e0846787a
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
@ 2022-03-28 18:13 ` newbluemoon
2022-03-28 18:38 ` newbluemoon
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: newbluemoon @ 2022-03-28 18:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1080981852
Comment:
I haven't updated qView, because I found a little bug which I didn't have the time to investigate, yet: when toggling through a list of pictures (just keep the right or left arrow key pressed) it crashes.
I guess this isn't a show stopper, but it's worth mentioning and not the case with 4.0.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
2022-03-28 18:13 ` newbluemoon
@ 2022-03-28 18:38 ` newbluemoon
2022-03-30 9:47 ` mustaqimM
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: newbluemoon @ 2022-03-28 18:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1080981852
Comment:
I haven't updated qView, because I found a little bug which I didn't have the time to investigate, yet: when toggling through a list of pictures (just keep the right or left arrow key pressed) it crashes.
I guess this isn't a show stopper, but it's worth mentioning and not the case with 4.0.
Edit: issue upstream https://github.com/jurplel/qView/issues/490
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
2022-03-28 18:13 ` newbluemoon
2022-03-28 18:38 ` newbluemoon
@ 2022-03-30 9:47 ` mustaqimM
2022-03-30 14:06 ` newbluemoon
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mustaqimM @ 2022-03-30 9:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1082867806
Comment:
@newbluemoon Oh, I see. What do you mean by toggling though? Scrolling next through images? Because I can't reproduce that
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (2 preceding siblings ...)
2022-03-30 9:47 ` mustaqimM
@ 2022-03-30 14:06 ` newbluemoon
2022-04-27 20:07 ` notramo
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: newbluemoon @ 2022-03-30 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1083184847
Comment:
I mean when I view a picture and there are more pictures in the directory in which the current picture resides I can move to the next or previous one with the arrow keys. When I keep changing to the next, to the next, etc. picture a crash occurs after a while (sooner when you keep the arrow key pressed).
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (3 preceding siblings ...)
2022-03-30 14:06 ` newbluemoon
@ 2022-04-27 20:07 ` notramo
2022-04-27 20:21 ` newbluemoon
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: notramo @ 2022-04-27 20:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
New comment by notramo on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111432149
Comment:
@newbluemoon 4.0 is segfaulting on `musl`. I think it should be updated to 5.0. It's better when crashing due to unusual usage than not being able to use it at all.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (4 preceding siblings ...)
2022-04-27 20:07 ` notramo
@ 2022-04-27 20:21 ` newbluemoon
2022-04-27 20:25 ` notramo
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: newbluemoon @ 2022-04-27 20:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111444393
Comment:
@notramo Did you test 5.0 on musl and verify that the segfault is gone?
I have no objections to updating qView to 5.0, just stated what I found. But it's not in my power to merge this PR ;)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (5 preceding siblings ...)
2022-04-27 20:21 ` newbluemoon
@ 2022-04-27 20:25 ` notramo
2022-04-27 20:28 ` notramo
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: notramo @ 2022-04-27 20:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by notramo on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111447767
Comment:
5.0 works on musl.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (6 preceding siblings ...)
2022-04-27 20:25 ` notramo
@ 2022-04-27 20:28 ` notramo
2022-04-28 20:06 ` newbluemoon
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: notramo @ 2022-04-27 20:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New comment by notramo on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111450303
Comment:
Also, I can't reproduce the quick navigating bug (keeping the arrow keys pressed) bug on musl with small and medium (15-20 megapixels) images.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (7 preceding siblings ...)
2022-04-27 20:28 ` notramo
@ 2022-04-28 20:06 ` newbluemoon
2022-04-30 11:40 ` notramo
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: newbluemoon @ 2022-04-28 20:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1112608229
Comment:
Just tested 4.0 and 5.0 on musl. Both run fine without problems and I can confirm that the bug isn't present on musl -- seems to be a problem only on glibc.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (8 preceding siblings ...)
2022-04-28 20:06 ` newbluemoon
@ 2022-04-30 11:40 ` notramo
2022-07-30 2:14 ` github-actions
2022-08-14 2:14 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: notramo @ 2022-04-30 11:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New comment by notramo on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1113973134
Comment:
I used 4.0 on musl with Wayland (Sway). But I can't test if 4.0 crashes on Xorg too as I have 5.0 installed now.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (9 preceding siblings ...)
2022-04-30 11:40 ` notramo
@ 2022-07-30 2:14 ` github-actions
2022-08-14 2:14 ` [PR PATCH] [Closed]: " github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-07-30 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/36391#issuecomment-1200066490
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: qView: update to 5.0
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
` (10 preceding siblings ...)
2022-07-30 2:14 ` github-actions
@ 2022-08-14 2:14 ` github-actions
11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-08-14 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
There's a closed pull request on the void-packages repository
qView: update to 5.0
https://github.com/void-linux/void-packages/pull/36391
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-08-14 2:14 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 9:42 [PR PATCH] qView: update to 5.0 mustaqimM
2022-03-28 18:13 ` newbluemoon
2022-03-28 18:38 ` newbluemoon
2022-03-30 9:47 ` mustaqimM
2022-03-30 14:06 ` newbluemoon
2022-04-27 20:07 ` notramo
2022-04-27 20:21 ` newbluemoon
2022-04-27 20:25 ` notramo
2022-04-27 20:28 ` notramo
2022-04-28 20:06 ` newbluemoon
2022-04-30 11:40 ` notramo
2022-07-30 2:14 ` github-actions
2022-08-14 2:14 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).