Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gthumb: fix to run on wlroots compositor
@ 2021-02-05 14:17 gspe
  2021-02-05 19:05 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: gspe @ 2021-02-05 14:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

There is a new pull request by gspe against master on the void-packages repository

https://github.com/gspe/void-packages gthumb
https://github.com/void-linux/void-packages/pull/28520

gthumb: fix to run on wlroots compositor
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

Actually gthumb doesn't run on wlroots based compositor.
After asking on #sway irc channel they told me that this is a `clutter` problem https://gitlab.gnome.org/GNOME/clutter/-/merge_requests/5 and for now as workaround I can run gthumb with this command `CLUTTER_BACKEND=gdk gthumb`
I've tested this with wayland compositor and with X11 and it works in both cases.

So this PR just add this environmental variable to the gthumb .desktop file, obvious this only works if gthumb is launched by menu/launcher of file manager not if it is run by terminal.


A patch file from https://github.com/void-linux/void-packages/pull/28520.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gthumb-28520.patch --]
[-- Type: text/x-diff, Size: 1121 bytes --]

From f9635d127b8a02b348cd75f748d1ee8974e9caa5 Mon Sep 17 00:00:00 2001
From: Giuseppe Fierro <gspe@ae-design.ws>
Date: Fri, 5 Feb 2021 15:05:57 +0100
Subject: [PATCH] gthumb: fix to run on wlroots compositor

---
 srcpkgs/gthumb/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gthumb/template b/srcpkgs/gthumb/template
index cc2a53d0796..79abeb14fc5 100644
--- a/srcpkgs/gthumb/template
+++ b/srcpkgs/gthumb/template
@@ -1,7 +1,7 @@
 # Template file for 'gthumb'
 pkgname=gthumb
 version=3.10.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="gettext pkg-config itstool glib-devel"
 makedepends="webkit2gtk-devel json-glib-devel libsecret-devel librsvg-devel
@@ -24,6 +24,10 @@ desc_option_clutter="Enable clutter (for slideshows)"
 desc_option_soup="Enable webservices"
 build_options_default="clutter gstreamer soup"
 
+post_configure() {
+	vsed -e 's:Exec=gthumb %U:Exec=env CLUTTER_BACKEND=gdk gthumb %U:' -i data/org.gnome.gThumb.desktop.in.in
+}
+
 gthumb-devel_package() {
 	short_desc+=" - development files"
 	depends="${sourcepkg}>=${version}_${revision}"

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-17  2:14 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 14:17 [PR PATCH] gthumb: fix to run on wlroots compositor gspe
2021-02-05 19:05 ` ericonr
2021-02-05 19:09 ` gspe
2021-02-06  7:47 ` travankor
2021-02-06  7:47 ` travankor
2021-02-10  1:11 ` ericonr
2022-05-03  2:14 ` github-actions
2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).