[PR PATCH] python3-text-unidecode: update to 1.3

[PR PATCH] python3-text-unidecode: update to 1.3

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages text-unidecode
https://github.com/void-linux/void-packages/pull/38131

python3-text-unidecode: update to 1.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38131.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-text-unidecode-38131.patch --]
[-- Type: text/x-diff, Size: 1366 bytes --]

From bf5a06b199163e5ea1071dad57137d2d8fc00982 Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 18 Jul 2022 16:54:57 +0200
Subject: [PATCH] python3-text-unidecode: update to 1.3

---
 srcpkgs/python3-text-unidecode/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-text-unidecode/template b/srcpkgs/python3-text-unidecode/template
index 78b3b84e2234..a9a23b14707c 100644
--- a/srcpkgs/python3-text-unidecode/template
+++ b/srcpkgs/python3-text-unidecode/template
@@ -1,18 +1,17 @@
 # Template file for 'python3-text-unidecode'
 pkgname=python3-text-unidecode
-version=1.2
-revision=4
+version=1.3
+revision=1
 wrksrc="text-unidecode-${version}"
 build_style=python3-module
-pycompile_module="text_unidecode"
 hostmakedepends="python3-setuptools"
-depends="python3"
+checkdepends="python3-pytest"
 short_desc="Most basic Text::Unidecode port"
 maintainer="Enno Boland <gottox@voidlinux.org>"
-license="Artistic-1.0"
+license="Artistic-1.0, GPL-2.0-or-later"
 homepage="https://github.com/kmike/text-unidecode/"
 distfiles="${PYPI_SITE}/t/text-unidecode/text-unidecode-${version}.tar.gz"
-checksum=5a1375bb2ba7968740508ae38d92e1f889a0832913cb1c447d5e2046061a396d
+checksum=bad6603bb14d279193107714b288be206cac565dfa49aa5b105294dd5c4aab93
 
 post_install() {
 	vlicense LICENSE

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923675666

Comment:
Did you remove this by mistake?

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923677207

Comment:
I noticed this isn't usually included, and the packages still get the depends automatically.

If that's wrong I can bring it back.

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923682865

Comment:
I am not sure what you mean, $depends are often autodetected from the ELF header, but python packages are just scripts that obviously don't have ELF headers.

Python packages often include depends="python3-something" which depends on python3 transitively, so python3 doesn't need to be explicitly mentioned.

A few months ago I went over all python packages that were missing the python3 dependency and added it. You can check dependencies of the resulting package with xbps-query -x or a diff from the last version with xpkgdiff -x or in the CI (which runs xpkgdiff).

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923682865

Comment:
I am not sure what you mean, `$depends` is often autodetected from the ELF header, but python packages are just scripts that obviously don't have ELF headers.

Python packages often include depends="python3-something" which depends on python3 transitively, so python3 doesn't need to be explicitly mentioned.

A few months ago I went over all python packages that were missing the python3 dependency and added it. You can check dependencies of the resulting package with xbps-query -x or a diff from the last version with xpkgdiff -x or in the CI (which runs xpkgdiff).

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923682865

Comment:
I am not sure what you mean, `$depends` is often autodetected from the ELF header, but python packages are just scripts that are not in the ELF format.

Python packages often include depends="python3-something" which depends on python3 transitively, so python3 doesn't need to be explicitly mentioned.

A few months ago I went over all python packages that were missing the python3 dependency and added it. You can check dependencies of the resulting package with xbps-query -x or a diff from the last version with xpkgdiff -x or in the CI (which runs xpkgdiff).

Re: [PR REVIEW] python3-text-unidecode: update to 1.3

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/38131#discussion_r923687009

Comment:
Then I misinterpreted the whole python3 build style, my bad. I'll bring it back.

Re: [PR PATCH] [Updated] python3-text-unidecode: update to 1.3

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

There is an updated pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages text-unidecode
https://github.com/void-linux/void-packages/pull/38131

python3-text-unidecode: update to 1.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38131.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-text-unidecode-38131.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]

From 0919ae598beb2dfb9c7931945959c41018a7591b Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 18 Jul 2022 16:54:57 +0200
Subject: [PATCH] python3-text-unidecode: update to 1.3

---
 srcpkgs/python3-text-unidecode/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-text-unidecode/template b/srcpkgs/python3-text-unidecode/template
index 78b3b84e2234..1769601f2f3f 100644
--- a/srcpkgs/python3-text-unidecode/template
+++ b/srcpkgs/python3-text-unidecode/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-text-unidecode'
 pkgname=python3-text-unidecode
-version=1.2
-revision=4
+version=1.3
+revision=1
 wrksrc="text-unidecode-${version}"
 build_style=python3-module
-pycompile_module="text_unidecode"
 hostmakedepends="python3-setuptools"
 depends="python3"
+checkdepends="python3-pytest"
 short_desc="Most basic Text::Unidecode port"
 maintainer="Enno Boland <gottox@voidlinux.org>"
-license="Artistic-1.0"
+license="Artistic-1.0, GPL-2.0-or-later"
 homepage="https://github.com/kmike/text-unidecode/"
 distfiles="${PYPI_SITE}/t/text-unidecode/text-unidecode-${version}.tar.gz"
-checksum=5a1375bb2ba7968740508ae38d92e1f889a0832913cb1c447d5e2046061a396d
+checksum=bad6603bb14d279193107714b288be206cac565dfa49aa5b105294dd5c4aab93
 
 post_install() {
 	vlicense LICENSE

Re: [PR PATCH] [Merged]: python3-text-unidecode: update to 1.3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

There's a merged pull request on the void-packages repository

python3-text-unidecode: update to 1.3
https://github.com/void-linux/void-packages/pull/38131

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->