[PR PATCH] python3-jsonschema: update to 4.7.2.

[PR PATCH] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-jsonschema-4.7.2_1
https://github.com/void-linux/void-packages/pull/38172

python3-jsonschema: update to 4.7.2.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38172.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-jsonschema-4.7.2_1-38172.patch --]
[-- Type: text/x-diff, Size: 1243 bytes --]

From 4d58848d93123e716573edd1f0bed4bbc1c423e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Thu, 21 Jul 2022 10:29:53 +0200
Subject: [PATCH] python3-jsonschema: update to 4.7.2.

---
 srcpkgs/python3-jsonschema/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-jsonschema/template b/srcpkgs/python3-jsonschema/template
index a1dd7ff5d073..1bc8fa32290b 100644
--- a/srcpkgs/python3-jsonschema/template
+++ b/srcpkgs/python3-jsonschema/template
@@ -1,6 +1,6 @@
 # Template file for 'python3-jsonschema'
 pkgname=python3-jsonschema
-version=4.6.1
+version=4.7.2
 revision=1
 wrksrc="jsonschema-${version}"
 build_style=python3-pep517
@@ -12,7 +12,7 @@ license="MIT"
 homepage="https://github.com/Julian/jsonschema"
 changelog="https://raw.githubusercontent.com/Julian/jsonschema/master/CHANGELOG.rst"
 distfiles="${PYPI_SITE}/j/jsonschema/jsonschema-${version}.tar.gz"
-checksum=ec2802e6a37517f09d47d9ba107947589ae1d25ff557b925d83a321fc2aa5d3b
+checksum=73764f461d61eb97a057c929368610a134d1d1fffd858acfe88864ee94f1f1d3
 # Tests require jsonschema to be installed already. Setting PYTHONPATH doesn't seem to do trick
 make_check=no
 

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r926488721

Comment:
But I am not sure if it's worth the setup. Is this common in pep517 packages? If yes, could we add something like this to the build style?
```suggestion

do_check() {
	rm -rf *.dist-info tmp # remove artifacts from previous unsuccessful check run
	pip install --no-deps --target tmp ./jsonschema-$version-py3-none-any.whl
	mv tmp/*.dist-info .
	PYTHONPATH=. pytest
	rm -rf *.dist-info tmp
}
```

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r926503671

Comment:
I've seen it a few times, not sure if it's enough to call it common but I've definitely seen it a few times. Other distros handle this in a similar way, so if we could include it in the build style that'd be great, although I don't feel confident enough in quite a bit of this python stuff, so I'd appreciate it if someone else could look into the check/build-style stuff.

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r926506647

Comment:
Aside of that, in this specific case: I ran the test cases of ansible-lint, which depends on this, and I've run ansible-lint on my local repositories, to test that this release works.

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r926508584

Comment:
Aside of that, in this specific case: I ran the test cases of ansible-lint, which depends on this, and I've run ansible-lint on my local repositories, to test that this release works.

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r927298838

Comment:
would this be something that could be done as a conditional in the buildstyle?

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r927884327

Comment:
Let's add this for now, we can easily remove it if/when we figure out how to do this (if we can and want to) universally.

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r927884327

Comment:
Let's add this fix for now, we can easily remove it if/when we figure out how to do this (if we can and want to) universally.

Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r934035492

Comment:
Okay, so I'm back on this, and as it is right now it doesn't work. With a few more changes the tests now do run successfully, and I'm currently running the tests for everything depending on python3-jsonschema. ooi: is there a nice way to do this with xtools or xbps-src? I'm looping over all packages returned by `grep python3-jsonschema -r -l srcpkgs | cut -d/ -f2` right now, but that seems like a common enough usecase for checking whether something breaks when updating a library package.

Re: [PR PATCH] [Updated] python3-jsonschema: update to 4.7.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-jsonschema-4.7.2_1
https://github.com/void-linux/void-packages/pull/38172

python3-jsonschema: update to 4.7.2.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38172.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-jsonschema-4.7.2_1-38172.patch --]
[-- Type: text/x-diff, Size: 1835 bytes --]

From 457c17bb7e1f3eebc0e83b8b967d57239066ac81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Thu, 21 Jul 2022 10:29:53 +0200
Subject: [PATCH] python3-jsonschema: update to 4.9.0.

---
 srcpkgs/python3-jsonschema/template | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-jsonschema/template b/srcpkgs/python3-jsonschema/template
index a1dd7ff5d073..173a5d1cc78c 100644
--- a/srcpkgs/python3-jsonschema/template
+++ b/srcpkgs/python3-jsonschema/template
@@ -1,20 +1,28 @@
 # Template file for 'python3-jsonschema'
 pkgname=python3-jsonschema
-version=4.6.1
+version=4.9.0
 revision=1
 wrksrc="jsonschema-${version}"
 build_style=python3-pep517
 hostmakedepends="hatchling hatch-vcs"
 depends="python3-attrs python3-pyrsistent"
+checkdepends="${depends} python3-pytest"
 short_desc="Implementation of JSON Schema for Python3"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/Julian/jsonschema"
 changelog="https://raw.githubusercontent.com/Julian/jsonschema/master/CHANGELOG.rst"
 distfiles="${PYPI_SITE}/j/jsonschema/jsonschema-${version}.tar.gz"
-checksum=ec2802e6a37517f09d47d9ba107947589ae1d25ff557b925d83a321fc2aa5d3b
-# Tests require jsonschema to be installed already. Setting PYTHONPATH doesn't seem to do trick
-make_check=no
+checksum=df10e65c8f3687a48e93d0d348ce0ce5f897b5a28e9bbcbbe8f7c7eaf019e850
+
+do_check() {
+	rm -rf *.dist-info tmp # remove artifacts from previous unsuccessful check run
+	pip install --no-deps --target tmp ./jsonschema-$version-py3-none-any.whl
+	rm tmp/jsonschema/tests -rf
+	mv tmp/*.dist-info .
+	PYTHONPATH=. pytest
+	rm -rf *.dist-info tmp
+}
 
 pre_build() {
 	export SETUPTOOLS_SCM_PRETEND_VERSION="${version}"

Re: [PR PATCH] [Updated] python3-jsonschema: update to 4.7.2.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages python3-jsonschema-4.7.2_1
https://github.com/void-linux/void-packages/pull/38172

python3-jsonschema: update to 4.7.2.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38172.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-jsonschema-4.7.2_1-38172.patch --]
[-- Type: text/x-diff, Size: 1835 bytes --]

From 457c17bb7e1f3eebc0e83b8b967d57239066ac81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Thu, 21 Jul 2022 10:29:53 +0200
Subject: [PATCH] python3-jsonschema: update to 4.9.0.

---
 srcpkgs/python3-jsonschema/template | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-jsonschema/template b/srcpkgs/python3-jsonschema/template
index a1dd7ff5d073..173a5d1cc78c 100644
--- a/srcpkgs/python3-jsonschema/template
+++ b/srcpkgs/python3-jsonschema/template
@@ -1,20 +1,28 @@
 # Template file for 'python3-jsonschema'
 pkgname=python3-jsonschema
-version=4.6.1
+version=4.9.0
 revision=1
 wrksrc="jsonschema-${version}"
 build_style=python3-pep517
 hostmakedepends="hatchling hatch-vcs"
 depends="python3-attrs python3-pyrsistent"
+checkdepends="${depends} python3-pytest"
 short_desc="Implementation of JSON Schema for Python3"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/Julian/jsonschema"
 changelog="https://raw.githubusercontent.com/Julian/jsonschema/master/CHANGELOG.rst"
 distfiles="${PYPI_SITE}/j/jsonschema/jsonschema-${version}.tar.gz"
-checksum=ec2802e6a37517f09d47d9ba107947589ae1d25ff557b925d83a321fc2aa5d3b
-# Tests require jsonschema to be installed already. Setting PYTHONPATH doesn't seem to do trick
-make_check=no
+checksum=df10e65c8f3687a48e93d0d348ce0ce5f897b5a28e9bbcbbe8f7c7eaf019e850
+
+do_check() {
+	rm -rf *.dist-info tmp # remove artifacts from previous unsuccessful check run
+	pip install --no-deps --target tmp ./jsonschema-$version-py3-none-any.whl
+	rm tmp/jsonschema/tests -rf
+	mv tmp/*.dist-info .
+	PYTHONPATH=. pytest
+	rm -rf *.dist-info tmp
+}
 
 pre_build() {
 	export SETUPTOOLS_SCM_PRETEND_VERSION="${version}"

Re: [PR REVIEW] python3-jsonschema: update to 4.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r937202234

Comment:
I don't think there is a tool for that

Re: [PR PATCH] [Merged]: python3-jsonschema: update to 4.9.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

There's a merged pull request on the void-packages repository

python3-jsonschema: update to 4.9.0.
https://github.com/void-linux/void-packages/pull/38172

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->