[PR PATCH] docker-credential-pass: Fix broken post_install

[PR PATCH] docker-credential-pass: Fix broken post_install

[MarleDK]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

There is a new pull request by MarleDK against master on the void-packages repository

https://github.com/MarleDK/void-packages docker-credential-pass-fix-post_install
https://github.com/void-linux/void-packages/pull/38267

docker-credential-pass: Fix broken post_install
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**
  - Only checked that `xls` shows the right binary after packaging

A patch file from https://github.com/void-linux/void-packages/pull/38267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-docker-credential-pass-fix-post_install-38267.patch --]
[-- Type: text/x-diff, Size: 1170 bytes --]

From cc8da9d39f80c237d2f28e75636e3b859e572667 Mon Sep 17 00:00:00 2001
From: Jakob Rydhof <jry@famly.co>
Date: Mon, 25 Jul 2022 11:23:50 +0200
Subject: [PATCH] docker-credential-pass: Fix broken post_install

There cannot be two `post_install` hooks in the template, it made the
second hook overwrite the first, which meant /usr/bin/cmd was never
moved.
---
 srcpkgs/docker-credential-pass/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/docker-credential-pass/template b/srcpkgs/docker-credential-pass/template
index 18daf0c1dd1f..f50da0c94b23 100644
--- a/srcpkgs/docker-credential-pass/template
+++ b/srcpkgs/docker-credential-pass/template
@@ -1,7 +1,7 @@
 # Template file for 'docker-credential-pass'
 pkgname=docker-credential-pass
 version=0.6.4
-revision=1
+revision=2
 wrksrc="docker-credential-helpers-${version}"
 build_style=go
 go_import_path="github.com/docker/docker-credential-helpers"
@@ -16,8 +16,5 @@ checksum=b97d27cefb2de7a18079aad31c9aef8e3b8a38313182b73aaf8b83701275ac83
 
 post_install() {
 	mv ${DESTDIR}/usr/bin/cmd ${DESTDIR}/usr/bin/docker-credential-pass
-}
-
-post_install() {
 	vlicense LICENSE
 }

Re: docker-credential-pass: Fix broken post_install

[paper42]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38267#issuecomment-1193815211

Comment:
That's my mistake, thanks for catching it!

Re: [PR PATCH] [Merged]: docker-credential-pass: Fix broken post_install

[paper42]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

There's a merged pull request on the void-packages repository

docker-credential-pass: Fix broken post_install
https://github.com/void-linux/void-packages/pull/38267

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**
  - Only checked that `xls` shows the right binary after packaging

This was broken [here](https://github.com/void-linux/void-packages/pull/38108/files#diff-7d968ebeea41e0a809c2ac3582c3d263703f1af61ec5b0d5a164660fad3638d9) because a `do_install` was renamed to `post_install` without merging the other `post_install`