* Re: [PR PATCH] [Updated] ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
@ 2022-08-23 23:35 ` oreo639
2022-08-23 23:47 ` oreo639
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-23 23:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages ario
https://github.com/void-linux/void-packages/pull/38869
ario: remove unused dependency on libunique1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
cc: @leahneukirchen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38869.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ario-38869.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]
From 457dfe8d694458d96679ff381db8935359a07114 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:32:20 -0700
Subject: [PATCH] ario: remove unused dependency on libunique1
---
srcpkgs/ario/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/ario/template b/srcpkgs/ario/template
index c9fc6f3cd9b7..508c86907211 100644
--- a/srcpkgs/ario/template
+++ b/srcpkgs/ario/template
@@ -6,10 +6,10 @@ build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="pkg-config intltool"
makedepends="avahi-glib-libs-devel dbus-glib-devel gnutls-devel gtk+3-devel
- libcurl-devel libmpdclient-devel libnotify-devel libunique1-devel taglib-devel"
+ libcurl-devel libmpdclient-devel libnotify-devel taglib-devel"
short_desc="GTK client for MPD"
maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://ario-player.sourceforge.net/?en"
distfiles="${SOURCEFORGE_SITE}/${pkgname}-player/${pkgname}-${version}.tar.gz"
checksum=1442ede8eef994384489d72d028d7f7b1a1c81efe737f7147587dd02c772d09a
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
2022-08-23 23:35 ` [PR PATCH] [Updated] " oreo639
@ 2022-08-23 23:47 ` oreo639
2022-08-23 23:49 ` oreo639
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-23 23:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/38869#issuecomment-1224999274
Comment:
The tests are failing due to trayicon-prefs.ui being missing.
It was removed in this commit, what should I do about that:
https://sourceforge.net/p/ario-player/code/801/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
2022-08-23 23:35 ` [PR PATCH] [Updated] " oreo639
2022-08-23 23:47 ` oreo639
@ 2022-08-23 23:49 ` oreo639
2022-08-23 23:49 ` oreo639
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-23 23:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/38869#issuecomment-1224999274
Comment:
The tests are failing due to trayicon-prefs.ui being missing. (this doesn't appear to have been fixed upstream)
It was removed in this commit, what should I do about that:
https://sourceforge.net/p/ario-player/code/801/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (2 preceding siblings ...)
2022-08-23 23:49 ` oreo639
@ 2022-08-23 23:49 ` oreo639
2022-08-24 1:45 ` [PR PATCH] [Updated] " oreo639
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-23 23:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/38869#issuecomment-1224999274
Comment:
The tests are failing due to trayicon-prefs.ui being missing however it is still pulled in by the makefile for the tests. (this doesn't appear to have been fixed upstream)
It was removed in this commit, what should I do about that:
https://sourceforge.net/p/ario-player/code/801/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (3 preceding siblings ...)
2022-08-23 23:49 ` oreo639
@ 2022-08-24 1:45 ` oreo639
2022-08-24 1:45 ` oreo639
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-24 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages ario
https://github.com/void-linux/void-packages/pull/38869
ario: remove unused dependency on libunique1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
cc: @leahneukirchen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38869.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ario-38869.patch --]
[-- Type: text/x-diff, Size: 1393 bytes --]
From e4d4e8d689293eedb122f854534b832f3eaa2ef7 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:32:20 -0700
Subject: [PATCH] ario: remove unused dependency on libunique1
---
srcpkgs/ario/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/ario/template b/srcpkgs/ario/template
index c9fc6f3cd9b7..9e6bfe547847 100644
--- a/srcpkgs/ario/template
+++ b/srcpkgs/ario/template
@@ -6,15 +6,17 @@ build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="pkg-config intltool"
makedepends="avahi-glib-libs-devel dbus-glib-devel gnutls-devel gtk+3-devel
- libcurl-devel libmpdclient-devel libnotify-devel libunique1-devel taglib-devel"
+ libcurl-devel libmpdclient-devel libnotify-devel taglib-devel"
short_desc="GTK client for MPD"
maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://ario-player.sourceforge.net/?en"
distfiles="${SOURCEFORGE_SITE}/${pkgname}-player/${pkgname}-${version}.tar.gz"
checksum=1442ede8eef994384489d72d028d7f7b1a1c81efe737f7147587dd02c772d09a
+make_check=no # Tests still depend on build files that have been removed upstream
-post_extract() {
+
+post_patch() {
vsed -i 's,<glib/gi18n.h>,<glib.h>,g' src/ario-profiles.c
vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (4 preceding siblings ...)
2022-08-24 1:45 ` [PR PATCH] [Updated] " oreo639
@ 2022-08-24 1:45 ` oreo639
2022-08-24 1:46 ` oreo639
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-24 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages ario
https://github.com/void-linux/void-packages/pull/38869
ario: remove unused dependency on libunique1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
cc: @leahneukirchen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38869.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ario-38869.patch --]
[-- Type: text/x-diff, Size: 1390 bytes --]
From 2da856247c972a02cd0657e1e50fc1cd47cda440 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:32:20 -0700
Subject: [PATCH] ario: remove unused dependency on libunique1
---
srcpkgs/ario/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/ario/template b/srcpkgs/ario/template
index c9fc6f3cd9b7..9f800b393dc7 100644
--- a/srcpkgs/ario/template
+++ b/srcpkgs/ario/template
@@ -6,15 +6,16 @@ build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="pkg-config intltool"
makedepends="avahi-glib-libs-devel dbus-glib-devel gnutls-devel gtk+3-devel
- libcurl-devel libmpdclient-devel libnotify-devel libunique1-devel taglib-devel"
+ libcurl-devel libmpdclient-devel libnotify-devel taglib-devel"
short_desc="GTK client for MPD"
maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://ario-player.sourceforge.net/?en"
distfiles="${SOURCEFORGE_SITE}/${pkgname}-player/${pkgname}-${version}.tar.gz"
checksum=1442ede8eef994384489d72d028d7f7b1a1c81efe737f7147587dd02c772d09a
+make_check=no # Tests still depend on build files that have been removed upstream
-post_extract() {
+post_patch() {
vsed -i 's,<glib/gi18n.h>,<glib.h>,g' src/ario-profiles.c
vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (5 preceding siblings ...)
2022-08-24 1:45 ` oreo639
@ 2022-08-24 1:46 ` oreo639
2022-08-24 2:11 ` oreo639
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-24 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages ario
https://github.com/void-linux/void-packages/pull/38869
ario: remove unused dependency on libunique1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
cc: @leahneukirchen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38869.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ario-38869.patch --]
[-- Type: text/x-diff, Size: 1393 bytes --]
From fd81469af7600c7d6b25307a15866077d30a89eb Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:32:20 -0700
Subject: [PATCH] ario: remove unused dependency on libunique1
---
srcpkgs/ario/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/ario/template b/srcpkgs/ario/template
index c9fc6f3cd9b7..ce6c01e518ce 100644
--- a/srcpkgs/ario/template
+++ b/srcpkgs/ario/template
@@ -6,15 +6,16 @@ build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="pkg-config intltool"
makedepends="avahi-glib-libs-devel dbus-glib-devel gnutls-devel gtk+3-devel
- libcurl-devel libmpdclient-devel libnotify-devel libunique1-devel taglib-devel"
+ libcurl-devel libmpdclient-devel libnotify-devel taglib-devel"
short_desc="GTK client for MPD"
maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
homepage="http://ario-player.sourceforge.net/?en"
distfiles="${SOURCEFORGE_SITE}/${pkgname}-player/${pkgname}-${version}.tar.gz"
checksum=1442ede8eef994384489d72d028d7f7b1a1c81efe737f7147587dd02c772d09a
+make_check=no # Tests still depend on build files that have been removed by upstream
-post_extract() {
+post_patch() {
vsed -i 's,<glib/gi18n.h>,<glib.h>,g' src/ario-profiles.c
vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (6 preceding siblings ...)
2022-08-24 1:46 ` oreo639
@ 2022-08-24 2:11 ` oreo639
2022-08-24 3:29 ` classabbyamp
2022-08-24 3:29 ` [PR PATCH] [Closed]: " classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2022-08-24 2:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/38869#issuecomment-1224999274
Comment:
The tests are failing due to trayicon-prefs.ui being missing however it is still pulled in by the makefile for the tests. (this doesn't appear to have been fixed upstream)
It was removed in this commit, what should I do about that:
https://sourceforge.net/p/ario-player/code/801/
Edit: I just disabled them, even patching out that test resulted in more test build failures also due to old code being removed. The tests clearly haven't been updated in a while.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (7 preceding siblings ...)
2022-08-24 2:11 ` oreo639
@ 2022-08-24 3:29 ` classabbyamp
2022-08-24 3:29 ` [PR PATCH] [Closed]: " classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-24 3:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38869#issuecomment-1225137593
Comment:
combining with #38873
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Closed]: ario: remove unused dependency on libunique1
2022-08-23 23:32 [PR PATCH] ario: remove unused dependency on libunique1 oreo639
` (8 preceding siblings ...)
2022-08-24 3:29 ` classabbyamp
@ 2022-08-24 3:29 ` classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-24 3:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
There's a closed pull request on the void-packages repository
ario: remove unused dependency on libunique1
https://github.com/void-linux/void-packages/pull/38869
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
cc: @leahneukirchen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 11+ messages in thread