* Re: [PR REVIEW] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
@ 2022-09-01 17:10 ` classabbyamp
2022-09-01 18:44 ` TinfoilSubmarine
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-09-01 17:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#discussion_r960908918
Comment:
@Francesco149 can they adopt this from you?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
2022-09-01 17:10 ` [PR REVIEW] " classabbyamp
@ 2022-09-01 18:44 ` TinfoilSubmarine
2022-09-01 18:53 ` williamdes
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: TinfoilSubmarine @ 2022-09-01 18:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234651157
Comment:
If you'd like to adopt, could you include my fixed update check from https://github.com/void-linux/void-packages/pull/38984.
I don't use phpMyAdmin, so I was also curious about which PHP version should be used. PHP 7.4 is EOL in November, and at that point the `php` package will become a package depending on `php8.1`, effectively upgrading everyone with PHP 7.4 installed to 8.1. I'm tracking the progress of catching any errors that might happen from this in https://github.com/void-linux/void-packages/pull/38536.
All that said, if `phpMyAdmin` needs PHP 8.0 and not PHP 8.1, it might be a good idea to change the `php` dependency to `php8.0` to avoid an error state.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
2022-09-01 17:10 ` [PR REVIEW] " classabbyamp
2022-09-01 18:44 ` TinfoilSubmarine
@ 2022-09-01 18:53 ` williamdes
2022-09-01 19:18 ` TinfoilSubmarine
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: williamdes @ 2022-09-01 18:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
New comment by williamdes on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234659318
Comment:
> If you'd like to adopt, could you include my fixed update check from https://github.com/void-linux/void-packages/pull/38984.
Sure, but I would prefer that you include my change on your PR
See: https://github.com/void-linux/void-packages/pull/38984/files#r960994211
> All that said, if `phpMyAdmin` needs PHP 8.0 and not PHP 8.1, it might be a good idea to change the `php` dependency to `php8.0` to avoid an error state.
phpMyAdmin needs any PHP version between 7.1 and 8.2 ;)
Does void linux need packages to switch from `php` to `php8.1` ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
` (2 preceding siblings ...)
2022-09-01 18:53 ` williamdes
@ 2022-09-01 19:18 ` TinfoilSubmarine
2022-09-01 21:16 ` williamdes
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: TinfoilSubmarine @ 2022-09-01 19:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234684967
Comment:
> phpMyAdmin needs any PHP version between 7.1 and 8.2 ;)
>
> Does void linux need packages to switch from `php` to `php8.1` ?
No, the `php` package isn't going anywhere, so leaving it as is should be fine.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
` (3 preceding siblings ...)
2022-09-01 19:18 ` TinfoilSubmarine
@ 2022-09-01 21:16 ` williamdes
2022-09-01 21:16 ` [PR PATCH] [Closed]: " williamdes
2022-09-01 21:42 ` [PR REVIEW] " Francesco149
6 siblings, 0 replies; 8+ messages in thread
From: williamdes @ 2022-09-01 21:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by williamdes on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234791941
Comment:
Replaced by #38984
Thanks @TinfoilSubmarine
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Closed]: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
` (4 preceding siblings ...)
2022-09-01 21:16 ` williamdes
@ 2022-09-01 21:16 ` williamdes
2022-09-01 21:42 ` [PR REVIEW] " Francesco149
6 siblings, 0 replies; 8+ messages in thread
From: williamdes @ 2022-09-01 21:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
There's a closed pull request on the void-packages repository
phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
https://github.com/void-linux/void-packages/pull/39030
Description:
#### Testing the changes
- I tested the changes in this PR: NO
I am trying to understand how void linux works, until now I can not figure out how to start nginx or apache
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
2022-09-01 15:19 [PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer williamdes
` (5 preceding siblings ...)
2022-09-01 21:16 ` [PR PATCH] [Closed]: " williamdes
@ 2022-09-01 21:42 ` Francesco149
6 siblings, 0 replies; 8+ messages in thread
From: Francesco149 @ 2022-09-01 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New review comment by Francesco149 on void-packages repository
https://github.com/void-linux/void-packages/pull/39030#discussion_r961125693
Comment:
ok to adopt, I am not maintaining my void packages these days
^ permalink raw reply [flat|nested] 8+ messages in thread