[PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[PR PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[williamdes]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

There is a new pull request by williamdes against master on the void-packages repository

https://github.com/williamdes/void-packages phpmyadmin-update
https://github.com/void-linux/void-packages/pull/39030

phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
#### Testing the changes
- I tested the changes in this PR: NO

I am trying to understand how void linux works, until now I can not figure out how to start nginx or apache



A patch file from https://github.com/void-linux/void-packages/pull/39030.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpmyadmin-update-39030.patch --]
[-- Type: text/x-diff, Size: 1281 bytes --]

From b619a957f748f383f6faa5a70e719810f8988366 Mon Sep 17 00:00:00 2001
From: William Desportes <williamdes@wdes.fr>
Date: Thu, 1 Sep 2022 17:17:50 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index a55d2b5dfe2e..58c95e7af698 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,16 +1,16 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.0.4
+version=5.2.0
 revision=1
 wrksrc="phpMyAdmin-${version}-all-languages"
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php mysql"
+depends="php mariadb"
 short_desc="Web interface for MySQL and MariaDB"
-maintainer="Franc[e]sco <lolisamurai@tfwno.gf>"
+maintainer="William Desportes <williamdes@wdes.fr>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=1578c1a08e594da4f4f62e676ccbdbd17784c3de769b094ba42c35bf05c057db
+checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
 
 do_install() {
 	vmkdir usr/share/webapps/

Re: [PR REVIEW] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#discussion_r960908918

Comment:
@Francesco149 can they adopt this from you? 

Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234651157

Comment:
If you'd like to adopt, could you include my fixed update check from https://github.com/void-linux/void-packages/pull/38984.

I don't use phpMyAdmin, so I was also curious about which PHP version should be used. PHP 7.4 is EOL in November, and at that point the `php` package will become a package depending on `php8.1`, effectively upgrading everyone with PHP 7.4 installed to 8.1. I'm tracking the progress of catching any errors that might happen from this in https://github.com/void-linux/void-packages/pull/38536.

All that said, if `phpMyAdmin` needs PHP 8.0 and not PHP 8.1, it might be a good idea to change the `php` dependency to `php8.0` to avoid an error state.

Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[williamdes]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234659318

Comment:
> If you'd like to adopt, could you include my fixed update check from https://github.com/void-linux/void-packages/pull/38984.

Sure, but I would prefer that you include my change on your PR
See: https://github.com/void-linux/void-packages/pull/38984/files#r960994211

> All that said, if `phpMyAdmin` needs PHP 8.0 and not PHP 8.1, it might be a good idea to change the `php` dependency to `php8.0` to avoid an error state.

phpMyAdmin needs any PHP version between 7.1 and 8.2 ;)

Does void linux need packages to switch from `php` to `php8.1` ?

Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234684967

Comment:
> phpMyAdmin needs any PHP version between 7.1 and 8.2 ;)
> 
> Does void linux need packages to switch from `php` to `php8.1` ?

No, the `php` package isn't going anywhere, so leaving it as is should be fine.

Re: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[williamdes]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#issuecomment-1234791941

Comment:
Replaced by #38984
Thanks @TinfoilSubmarine 

Re: [PR PATCH] [Closed]: phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[williamdes]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

There's a closed pull request on the void-packages repository

phpMyAdmin: update to 5.2.0, use mariadb, change maintainer
https://github.com/void-linux/void-packages/pull/39030

Description:
#### Testing the changes
- I tested the changes in this PR: NO

I am trying to understand how void linux works, until now I can not figure out how to start nginx or apache

Re: [PR REVIEW] phpMyAdmin: update to 5.2.0, use mariadb, change maintainer

[Francesco149]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by Francesco149 on void-packages repository

https://github.com/void-linux/void-packages/pull/39030#discussion_r961125693

Comment:
ok to adopt, I am not maintaining my void packages these days