* [PR PATCH] New package: noise-suppression-for-voice-0.91
@ 2022-05-19 17:30 optlink
2022-09-02 2:16 ` github-actions
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: optlink @ 2022-05-19 17:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
There is a new pull request by optlink against master on the void-packages repository
https://github.com/optlink/void-packages noise-suppression-for-voice
https://github.com/void-linux/void-packages/pull/37198
New package: noise-suppression-for-voice-0.91
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/37198.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-noise-suppression-for-voice-37198.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]
From 7744f9486cd8d838353a5990a98e847bd3ae6cae Mon Sep 17 00:00:00 2001
From: Kelsey Maes <kelsey@maes.one>
Date: Mon, 16 May 2022 21:49:31 -0700
Subject: [PATCH] New package: noise-suppression-for-voice-0.91
---
srcpkgs/noise-suppression-for-voice/template | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 srcpkgs/noise-suppression-for-voice/template
diff --git a/srcpkgs/noise-suppression-for-voice/template b/srcpkgs/noise-suppression-for-voice/template
new file mode 100644
index 000000000000..e45fe9b20193
--- /dev/null
+++ b/srcpkgs/noise-suppression-for-voice/template
@@ -0,0 +1,11 @@
+# Template file for 'noise-suppression-for-voice'
+pkgname=noise-suppression-for-voice
+version=0.91
+revision=1
+build_style=cmake
+short_desc="Noise suppression plugin based on Xiph's RNNoise"
+maintainer="Kelsey Maes <kelsey@maes.one>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/werman/noise-suppression-for-voice"
+distfiles="https://github.com/werman/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=4f3a112534d4abb5ee2b6c328cde89193dbdb2146cffc98505972c3b5397a35e
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PR PATCH] New package: noise-suppression-for-voice-0.91
@ 2022-04-03 6:12 mustaqimM
2022-04-06 22:01 ` prez
` (9 more replies)
0 siblings, 10 replies; 14+ messages in thread
From: mustaqimM @ 2022-04-03 6:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
There is a new pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages new_package_noise-suppression-for-voice
https://github.com/void-linux/void-packages/pull/36491
New package: noise-suppression-for-voice-0.91
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, `(x86_64-glibc)`
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/36491.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package_noise-suppression-for-voice-36491.patch --]
[-- Type: text/x-diff, Size: 1186 bytes --]
From f99b0294e5f8bf5a723ddf95c00c06acf051cf7f Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Sun, 3 Apr 2022 08:09:37 +0200
Subject: [PATCH] New package: noise-suppression-for-voice-0.91
---
srcpkgs/noise-suppression-for-voice/template | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 srcpkgs/noise-suppression-for-voice/template
diff --git a/srcpkgs/noise-suppression-for-voice/template b/srcpkgs/noise-suppression-for-voice/template
new file mode 100644
index 000000000000..de9cc7ac50de
--- /dev/null
+++ b/srcpkgs/noise-suppression-for-voice/template
@@ -0,0 +1,12 @@
+# Template file for 'noise-suppression-for-voice'
+pkgname=noise-suppression-for-voice
+version=0.91
+revision=1
+build_style=cmake
+configure_args="-DBUILD_LV2_PLUGIN=OFF -DBUILD_VST_PLUGIN=OFF -DBUILD_LADSPA_PLUGIN=ON"
+short_desc="Noise suppression plugin based on Xiph's RNNoise"
+maintainer="mustaqim <git@mustaqim.ml>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/werman/noise-suppression-for-voice"
+distfiles="https://github.com/werman/${pkgname}/archive/v${version}.tar.gz"
+checksum=4f3a112534d4abb5ee2b6c328cde89193dbdb2146cffc98505972c3b5397a35e
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
@ 2022-04-06 22:01 ` prez
2022-04-07 15:06 ` mustaqimM
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: prez @ 2022-04-06 22:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New comment by prez on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1090853320
Comment:
>`DBUILD_LV2_PLUGIN=OFF`
very questionable decision. I'd argue LV2 is what you want to have, the others are optional.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
2022-04-06 22:01 ` prez
@ 2022-04-07 15:06 ` mustaqimM
2022-04-07 17:15 ` prez
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: mustaqimM @ 2022-04-07 15:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1091856157
Comment:
Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
2022-04-06 22:01 ` prez
2022-04-07 15:06 ` mustaqimM
@ 2022-04-07 17:15 ` prez
2022-07-07 2:14 ` github-actions
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: prez @ 2022-04-07 17:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
New comment by prez on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1091998384
Comment:
> Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink
The same goes for LV2. I suggest building LV2 only for now.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (2 preceding siblings ...)
2022-04-07 17:15 ` prez
@ 2022-07-07 2:14 ` github-actions
2022-07-08 1:31 ` cinerea0
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: github-actions @ 2022-07-07 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1176964689
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (3 preceding siblings ...)
2022-07-07 2:14 ` github-actions
@ 2022-07-08 1:31 ` cinerea0
2022-09-05 8:42 ` JamiKettunen
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: cinerea0 @ 2022-07-08 1:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1178436678
Comment:
I think this one is worth keeping open.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (4 preceding siblings ...)
2022-07-08 1:31 ` cinerea0
@ 2022-09-05 8:42 ` JamiKettunen
2022-12-05 1:59 ` github-actions
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: JamiKettunen @ 2022-09-05 8:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1236708557
Comment:
@mustaqimM Could this be bumped to [v1.03](https://github.com/werman/noise-suppression-for-voice/releases/tag/v1.03)?
> The same goes for LV2. I suggest building LV2 only for now.
@prez Why not both? I'm using this as a PipeWire LADSPA plugin as [documented on the README](https://github.com/werman/noise-suppression-for-voice#pipewire) and just tried to make it use the LV2 plugin but was unsuccessful.
I checked `lv2ls` (from `lilv`) and this could be problematic:
```
$ lv2ls
lilv_world_add_plugin(): warning: Duplicate plugin <https://github.com/werman/noise-suppression-for-voice>
lilv_world_add_plugin(): warning: ... found in file:///usr/lib64/lv2/rnnoise_stereo.lv2/
lilv_world_add_plugin(): warning: ... and file:///usr/lib64/lv2/rnnoise_mono.lv2/ (ignored)
...
https://github.com/werman/noise-suppression-for-voice
```
Considering the README itself mentions `It also would consume 2x resources` with regards to using the `stereo` plugin as compared to the `mono` one (which I know my microphone only is mono channel).
https://docs.pipewire.org/page_module_filter_chain.html mentions `For LV2, this is the plugin URI obtained with lv2ls` but I couldn't get it working. I'm very much a newbie when it comes to PipeWire configuration so if someone has a working LV2 `mono` plugin config I wouldn't mind LADSPA wasn't present in this package; I just want a working configuration with the `mono` plugin that's all.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (5 preceding siblings ...)
2022-09-05 8:42 ` JamiKettunen
@ 2022-12-05 1:59 ` github-actions
2022-12-05 2:12 ` JamiKettunen
` (2 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: github-actions @ 2022-12-05 1:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336624338
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (6 preceding siblings ...)
2022-12-05 1:59 ` github-actions
@ 2022-12-05 2:12 ` JamiKettunen
2022-12-05 2:12 ` JamiKettunen
2022-12-05 3:51 ` mustaqimM
9 siblings, 0 replies; 14+ messages in thread
From: JamiKettunen @ 2022-12-05 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336635479
Comment:
My last comment is still relevant, I'm also still using this daily for so it would be rather great to have this in the repos, other alternative voice suppression solutions that I could instead add to my PipeWire setup would also be welcome.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (7 preceding siblings ...)
2022-12-05 2:12 ` JamiKettunen
@ 2022-12-05 2:12 ` JamiKettunen
2022-12-05 3:51 ` mustaqimM
9 siblings, 0 replies; 14+ messages in thread
From: JamiKettunen @ 2022-12-05 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336635479
Comment:
My last comment is still relevant, I'm also still using this daily so it would be rather great to have this in the repos, other alternative voice suppression solutions that I could instead add to my PipeWire setup would also be welcome.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: New package: noise-suppression-for-voice-0.91
2022-04-03 6:12 [PR PATCH] " mustaqimM
` (8 preceding siblings ...)
2022-12-05 2:12 ` JamiKettunen
@ 2022-12-05 3:51 ` mustaqimM
9 siblings, 0 replies; 14+ messages in thread
From: mustaqimM @ 2022-12-05 3:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336708704
Comment:
@JamiKettunen I had to add `libsanitizer-devel` for it to build the new version, but now it's failing for other arches. I don't have time to see what's up, so if someone wants to take over, please do so.
Also I set the flag `-DBUILD_VST_PLUGIN=OFF` but in the new version, it still builds it and adds it to `/usr/lib/vst3/rnnoise.vst3/Contents/x86_64-linux/rnnoise.so`
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-12-05 3:51 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 17:30 [PR PATCH] New package: noise-suppression-for-voice-0.91 optlink
2022-09-02 2:16 ` github-actions
2022-09-05 8:21 ` JamiKettunen
2022-10-19 15:54 ` [PR PATCH] [Closed]: " ahesford
-- strict thread matches above, loose matches on Subject: below --
2022-04-03 6:12 [PR PATCH] " mustaqimM
2022-04-06 22:01 ` prez
2022-04-07 15:06 ` mustaqimM
2022-04-07 17:15 ` prez
2022-07-07 2:14 ` github-actions
2022-07-08 1:31 ` cinerea0
2022-09-05 8:42 ` JamiKettunen
2022-12-05 1:59 ` github-actions
2022-12-05 2:12 ` JamiKettunen
2022-12-05 2:12 ` JamiKettunen
2022-12-05 3:51 ` mustaqimM
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).