* [PR PATCH] qpdf: changed build_style to cmake.
@ 2022-03-25 11:30 benalb
2022-03-25 12:06 ` [PR PATCH] [Updated] " benalb
` (22 more replies)
0 siblings, 23 replies; 24+ messages in thread
From: benalb @ 2022-03-25 11:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
There is a new pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 2569 bytes --]
From dc8d69809c97c4a6ff3b5d1f61d8c5936662130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 45 ++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..1a376a4ad78d 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,45 +1,38 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
-
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
@ 2022-03-25 12:06 ` benalb
2022-03-25 13:51 ` [PR REVIEW] " TinfoilSubmarine
` (21 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-03-25 12:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
There is an updated pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 3371 bytes --]
From dc8d69809c97c4a6ff3b5d1f61d8c5936662130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH 1/2] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 45 ++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..1a376a4ad78d 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,45 +1,38 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
-
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
From 334f7d4c16d9f91a763af5eec37efbc1b209dd2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 13:06:18 +0100
Subject: [PATCH 2/2] added pkg-config to hostmakedepends
---
srcpkgs/qpdf/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 1a376a4ad78d..0b8b4d806984 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -4,7 +4,7 @@ version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
build_style=cmake
-hostmakedepends="perl"
+hostmakedepends="perl pkg-config"
makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
2022-03-25 12:06 ` [PR PATCH] [Updated] " benalb
@ 2022-03-25 13:51 ` TinfoilSubmarine
2022-03-25 13:52 ` TinfoilSubmarine
` (20 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: TinfoilSubmarine @ 2022-03-25 13:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
New review comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835289448
Comment:
Need to patch out tests if CROSS_BUILD:
```
post_patch() {
if [ "$CROSS_BUILD" ]; then
vsed -e "/\(fmt_lld\|fmt_i64d\|fmt_i64lld\)/d" -i libqpdf/CMakeLists.txt
fi
}
```
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
2022-03-25 12:06 ` [PR PATCH] [Updated] " benalb
2022-03-25 13:51 ` [PR REVIEW] " TinfoilSubmarine
@ 2022-03-25 13:52 ` TinfoilSubmarine
2022-03-25 14:06 ` [PR REVIEW] " tibequadorian
` (19 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: TinfoilSubmarine @ 2022-03-25 13:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1079049948
Comment:
Needs [this patch](https://gist.github.com/TinfoilSubmarine/82528118535a026162163e6b17a26faa) to cross-build successfully, need to test if this produces a valid, working binary though.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (2 preceding siblings ...)
2022-03-25 13:52 ` TinfoilSubmarine
@ 2022-03-25 14:06 ` tibequadorian
2022-03-25 14:07 ` tibequadorian
` (18 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-25 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835303436
Comment:
No need to patch. Works too with `configure_args=-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom`
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (3 preceding siblings ...)
2022-03-25 14:06 ` [PR REVIEW] " tibequadorian
@ 2022-03-25 14:07 ` tibequadorian
2022-03-25 14:11 ` tibequadorian
` (17 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-25 14:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835303436
Comment:
No need to patch. Also works with `configure_args=-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom`
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (4 preceding siblings ...)
2022-03-25 14:07 ` tibequadorian
@ 2022-03-25 14:11 ` tibequadorian
2022-03-25 14:12 ` TinfoilSubmarine
` (16 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-25 14:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835303436
Comment:
No need to patch. Also works with `configure_args=-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom`
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (5 preceding siblings ...)
2022-03-25 14:11 ` tibequadorian
@ 2022-03-25 14:12 ` TinfoilSubmarine
2022-03-25 14:12 ` TinfoilSubmarine
` (15 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: TinfoilSubmarine @ 2022-03-25 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New review comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835308589
Comment:
Ah, shows how much I know my cmake-foo. Thanks!
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (6 preceding siblings ...)
2022-03-25 14:12 ` TinfoilSubmarine
@ 2022-03-25 14:12 ` TinfoilSubmarine
2022-03-26 22:06 ` [PR PATCH] [Updated] " benalb
` (14 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: TinfoilSubmarine @ 2022-03-25 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1079049948
Comment:
~~Needs [this patch](https://gist.github.com/TinfoilSubmarine/82528118535a026162163e6b17a26faa) to cross-build successfully, need to test if this produces a valid, working binary though.~~ See @tibequadorian's better suggestion.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (7 preceding siblings ...)
2022-03-25 14:12 ` TinfoilSubmarine
@ 2022-03-26 22:06 ` benalb
2022-03-26 22:20 ` [PR REVIEW] " tibequadorian
` (13 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-03-26 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
There is an updated pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 5109 bytes --]
From dc8d69809c97c4a6ff3b5d1f61d8c5936662130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH 1/3] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 45 ++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..1a376a4ad78d 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,45 +1,38 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
-
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
From 334f7d4c16d9f91a763af5eec37efbc1b209dd2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 13:06:18 +0100
Subject: [PATCH 2/3] added pkg-config to hostmakedepends
---
srcpkgs/qpdf/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 1a376a4ad78d..0b8b4d806984 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -4,7 +4,7 @@ version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
build_style=cmake
-hostmakedepends="perl"
+hostmakedepends="perl pkg-config"
makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
From 8d3fb39a2d9dd326b23ec2007d9424c4cc80159f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Sat, 26 Mar 2022 23:06:12 +0100
Subject: [PATCH 3/3] fixed indentation, add configure_args if CROSSBUILD
---
srcpkgs/qpdf/template | 32 ++++++++++++++++++--------------
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 0b8b4d806984..537e5333d203 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -15,24 +15,28 @@ distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
+fi
+
+if [ "$CROSS_BUILD" ]; then
+ configure_args="-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom"
fi
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (8 preceding siblings ...)
2022-03-26 22:06 ` [PR PATCH] [Updated] " benalb
@ 2022-03-26 22:20 ` tibequadorian
2022-03-27 5:45 ` [PR PATCH] [Updated] " benalb
` (12 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-26 22:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835818992
Comment:
```suggestion
LIBS="-latomic"
```
to fix armv6l
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (9 preceding siblings ...)
2022-03-26 22:20 ` [PR REVIEW] " tibequadorian
@ 2022-03-27 5:45 ` benalb
2022-03-27 12:47 ` [PR REVIEW] " tibequadorian
` (11 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-03-27 5:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
There is an updated pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 5914 bytes --]
From dc8d69809c97c4a6ff3b5d1f61d8c5936662130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH 1/4] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 45 ++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..1a376a4ad78d 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,45 +1,38 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
-
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
From 334f7d4c16d9f91a763af5eec37efbc1b209dd2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 13:06:18 +0100
Subject: [PATCH 2/4] added pkg-config to hostmakedepends
---
srcpkgs/qpdf/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 1a376a4ad78d..0b8b4d806984 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -4,7 +4,7 @@ version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
build_style=cmake
-hostmakedepends="perl"
+hostmakedepends="perl pkg-config"
makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
From 8d3fb39a2d9dd326b23ec2007d9424c4cc80159f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Sat, 26 Mar 2022 23:06:12 +0100
Subject: [PATCH 3/4] fixed indentation, add configure_args if CROSSBUILD
---
srcpkgs/qpdf/template | 32 ++++++++++++++++++--------------
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 0b8b4d806984..537e5333d203 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -15,24 +15,28 @@ distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
+fi
+
+if [ "$CROSS_BUILD" ]; then
+ configure_args="-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom"
fi
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
From b998a7144402f88b8e19c7b5bc10732d1e65029f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Sun, 27 Mar 2022 07:44:50 +0200
Subject: [PATCH 4/4] fixing armvl6-musl
---
srcpkgs/qpdf/template | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 537e5333d203..215d9ff1d1fd 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -16,7 +16,14 @@ checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ case "$XBPS_TARGET_MACHINE" in
+ armv6l-musl)
+ LIBS="-latomic"
+ ;;
+ *)
+ LDFLAGS+=" -latomic"
+ ;;
+ esac
fi
if [ "$CROSS_BUILD" ]; then
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (10 preceding siblings ...)
2022-03-27 5:45 ` [PR PATCH] [Updated] " benalb
@ 2022-03-27 12:47 ` tibequadorian
2022-03-27 12:47 ` tibequadorian
` (10 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-27 12:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835902529
Comment:
only change this line as i suggested
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (11 preceding siblings ...)
2022-03-27 12:47 ` [PR REVIEW] " tibequadorian
@ 2022-03-27 12:47 ` tibequadorian
2022-03-27 13:55 ` [PR PATCH] [Updated] " benalb
` (9 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-27 12:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835902529
Comment:
only change this line as i suggested
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (12 preceding siblings ...)
2022-03-27 12:47 ` tibequadorian
@ 2022-03-27 13:55 ` benalb
2022-03-27 14:14 ` benalb
` (8 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-03-27 13:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
There is an updated pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 2054 bytes --]
From 57ac1daf64fb30c3974ad911feabb84e084aff7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..215d9ff1d1fd 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,35 +1,39 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl pkg-config"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ case "$XBPS_TARGET_MACHINE" in
+ armv6l-musl)
+ LIBS="-latomic"
+ ;;
+ *)
+ LDFLAGS+=" -latomic"
+ ;;
+ esac
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
+if [ "$CROSS_BUILD" ]; then
+ configure_args="-DLL_FMT=%lld -DRANDOM_DEVICE=/dev/urandom"
+fi
libqpdf_package() {
short_desc+=" - shared library"
pkg_install() {
- vmove "usr/lib/*.so.*"
+ vmove "usr/lib/*.so.*"
}
}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (13 preceding siblings ...)
2022-03-27 13:55 ` [PR PATCH] [Updated] " benalb
@ 2022-03-27 14:14 ` benalb
2022-03-27 14:20 ` [PR REVIEW] " tibequadorian
` (7 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-03-27 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
New comment by benalb on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1079940554
Comment:
Builds OK, I have tested it in X86_64, i686 and armv7l. I will wait till upstream realeses 10.6.4 to push the PR.
Thank you very much @tibequadorian and @TinfoilSubmarine
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (14 preceding siblings ...)
2022-03-27 14:14 ` benalb
@ 2022-03-27 14:20 ` tibequadorian
2022-05-28 23:04 ` Piraty
` (6 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-03-27 14:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r835914760
Comment:
Maybe "to fix armv6l" was misleading, please change the line as I suggested.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (15 preceding siblings ...)
2022-03-27 14:20 ` [PR REVIEW] " tibequadorian
@ 2022-05-28 23:04 ` Piraty
2022-05-29 5:59 ` benalb
` (5 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2022-05-28 23:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1140341107
Comment:
is that worth it?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (16 preceding siblings ...)
2022-05-28 23:04 ` Piraty
@ 2022-05-29 5:59 ` benalb
2022-05-29 16:50 ` [PR REVIEW] " tibequadorian
` (4 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-05-29 5:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New comment by benalb on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1140383520
Comment:
It's an upstream [decission](https://github.com/qpdf/qpdf/releases/tag/release-qpdf-10.6.3.0cmake1)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (17 preceding siblings ...)
2022-05-29 5:59 ` benalb
@ 2022-05-29 16:50 ` tibequadorian
2022-06-04 10:37 ` tibequadorian
` (3 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-05-29 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r884298029
Comment:
@benalb see above
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (18 preceding siblings ...)
2022-05-29 16:50 ` [PR REVIEW] " tibequadorian
@ 2022-06-04 10:37 ` tibequadorian
2022-09-03 2:14 ` github-actions
` (2 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: tibequadorian @ 2022-06-04 10:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#discussion_r884298029
Comment:
@benalb see above
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (19 preceding siblings ...)
2022-06-04 10:37 ` tibequadorian
@ 2022-09-03 2:14 ` github-actions
2022-09-11 14:23 ` benalb
2022-09-11 14:23 ` [PR PATCH] [Closed]: " benalb
22 siblings, 0 replies; 24+ messages in thread
From: github-actions @ 2022-09-03 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1236026901
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (20 preceding siblings ...)
2022-09-03 2:14 ` github-actions
@ 2022-09-11 14:23 ` benalb
2022-09-11 14:23 ` [PR PATCH] [Closed]: " benalb
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-09-11 14:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New comment by benalb on void-packages repository
https://github.com/void-linux/void-packages/pull/36330#issuecomment-1242976133
Comment:
as there is a soname bump involved in the update to 11.0.0, I will close this WIP and create a new PR.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Closed]: qpdf: changed build_style to cmake.
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
` (21 preceding siblings ...)
2022-09-11 14:23 ` benalb
@ 2022-09-11 14:23 ` benalb
22 siblings, 0 replies; 24+ messages in thread
From: benalb @ 2022-09-11 14:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
There's a closed pull request on the void-packages repository
qpdf: changed build_style to cmake.
https://github.com/void-linux/void-packages/pull/36330
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-09-11 14:23 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 11:30 [PR PATCH] qpdf: changed build_style to cmake benalb
2022-03-25 12:06 ` [PR PATCH] [Updated] " benalb
2022-03-25 13:51 ` [PR REVIEW] " TinfoilSubmarine
2022-03-25 13:52 ` TinfoilSubmarine
2022-03-25 14:06 ` [PR REVIEW] " tibequadorian
2022-03-25 14:07 ` tibequadorian
2022-03-25 14:11 ` tibequadorian
2022-03-25 14:12 ` TinfoilSubmarine
2022-03-25 14:12 ` TinfoilSubmarine
2022-03-26 22:06 ` [PR PATCH] [Updated] " benalb
2022-03-26 22:20 ` [PR REVIEW] " tibequadorian
2022-03-27 5:45 ` [PR PATCH] [Updated] " benalb
2022-03-27 12:47 ` [PR REVIEW] " tibequadorian
2022-03-27 12:47 ` tibequadorian
2022-03-27 13:55 ` [PR PATCH] [Updated] " benalb
2022-03-27 14:14 ` benalb
2022-03-27 14:20 ` [PR REVIEW] " tibequadorian
2022-05-28 23:04 ` Piraty
2022-05-29 5:59 ` benalb
2022-05-29 16:50 ` [PR REVIEW] " tibequadorian
2022-06-04 10:37 ` tibequadorian
2022-09-03 2:14 ` github-actions
2022-09-11 14:23 ` benalb
2022-09-11 14:23 ` [PR PATCH] [Closed]: " benalb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).