[PR PATCH] New package: cpux-4.4.0

[PR PATCH] New package: cpux-4.4.0

[zlice]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

There is a new pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages CPU-X
https://github.com/void-linux/void-packages/pull/39533

New package: cpux-4.4.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

![cpux_about](https://user-images.githubusercontent.com/8009811/193115449-572358a3-56cf-4459-9849-e3b5dc2aaaee.png)

Did not test 'daemon' only basic CPU info.

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**


#### unsure

- License is `GPL-3.0`, put `-or-later`
- are cmake config args redundant?
- added `nopie=yes` for cpu-x-daemon


A patch file from https://github.com/void-linux/void-packages/pull/39533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CPU-X-39533.patch --]
[-- Type: text/x-diff, Size: 1231 bytes --]

From 79127ccc40a5f0fc0480be14afd58f702b65532b Mon Sep 17 00:00:00 2001
From: zlice <zlice555@gmail.com>
Date: Thu, 29 Sep 2022 14:37:34 -0400
Subject: [PATCH] New package: cpux-4.4.0

---
 srcpkgs/cpux/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/cpux/template

diff --git a/srcpkgs/cpux/template b/srcpkgs/cpux/template
new file mode 100644
index 000000000000..b5d6a86d4e02
--- /dev/null
+++ b/srcpkgs/cpux/template
@@ -0,0 +1,16 @@
+# Template file for 'cpux'
+pkgname=cpux
+version=4.4.0
+revision=1
+wrksrc=CPU-X-${version}
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release"
+hostmakedepends="pkg-config automake cmake gtk+3 libcpuid libtool ncurses procps-ng "
+makedepends="pkg-config automake cmake gtk+3 gtk+3-devel libcpuid libcpuid-devel libtool ncurses procps-ng procps-ng-devel"
+short_desc="CPU-X gathers information on CPU, motherboard and more"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://x0rg.github.io/CPU-X/"
+distfiles="https://github.com/X0rg/CPU-X/archive/refs/tags/v${version}.tar.gz"
+checksum=5d895ffa80c344cb6887d3fef7d833d20f367a74e35b79dc3f291c2496f060d9
+nopie=yes

Re: [PR PATCH] [Updated] New package: cpux-4.4.0

[zlice]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages CPU-X
https://github.com/void-linux/void-packages/pull/39533

New package: cpux-4.4.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

![cpux_about](https://user-images.githubusercontent.com/8009811/193115449-572358a3-56cf-4459-9849-e3b5dc2aaaee.png)

Did not test 'daemon' only basic CPU info.

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**


#### unsure

- License is `GPL-3.0`, put `-or-later`
- are cmake config args redundant?
- added `nopie=yes` for cpu-x-daemon


A patch file from https://github.com/void-linux/void-packages/pull/39533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CPU-X-39533.patch --]
[-- Type: text/x-diff, Size: 1231 bytes --]

From 1b4b5c134514f4ea5bf5e1042b30e3e1eadf9ec6 Mon Sep 17 00:00:00 2001
From: zlice <zlice555@gmail.com>
Date: Thu, 29 Sep 2022 14:37:34 -0400
Subject: [PATCH] New package: cpux-4.4.0

---
 srcpkgs/cpux/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/cpux/template

diff --git a/srcpkgs/cpux/template b/srcpkgs/cpux/template
new file mode 100644
index 000000000000..b5d6a86d4e02
--- /dev/null
+++ b/srcpkgs/cpux/template
@@ -0,0 +1,16 @@
+# Template file for 'cpux'
+pkgname=cpux
+version=4.4.0
+revision=1
+wrksrc=CPU-X-${version}
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release"
+hostmakedepends="pkg-config automake cmake gtk+3 libcpuid libtool ncurses procps-ng "
+makedepends="pkg-config automake cmake gtk+3 gtk+3-devel libcpuid libcpuid-devel libtool ncurses procps-ng procps-ng-devel"
+short_desc="CPU-X gathers information on CPU, motherboard and more"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-3.0-or-later"
+homepage="https://x0rg.github.io/CPU-X/"
+distfiles="https://github.com/X0rg/CPU-X/archive/refs/tags/v${version}.tar.gz"
+checksum=5d895ffa80c344cb6887d3fef7d833d20f367a74e35b79dc3f291c2496f060d9
+nopie=yes

Re: New package: cpux-4.4.0

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#issuecomment-1262686473

Comment:
This is already packaged: https://github.com/void-linux/void-packages/tree/master/srcpkgs/CPU-X

Re: New package: cpux-4.4.0

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#issuecomment-1262692420

Comment:
You could change this PR to update it since it's still 4.3.0

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983913461

Comment:
pkgname should match upstream

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983913250

Comment:
don't specify these cmake variables, they're already set by the cmake build style
```suggestion
```

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983913773

Comment:
```suggestion
short_desc="Gathers information on CPU, motherboard and more"
```

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983914957

Comment:
```suggestion
homepage="https://x0rg.github.io/CPU-X/"
changelog="https://raw.githubusercontent.com/X0rg/CPU-X/master/ChangeLog.md"
```

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983914604

Comment:
new packages shouldn't be orphaned

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983927927

Comment:
patch out https://github.com/X0rg/CPU-X/blob/v4.4.0/CMakeLists.txt#L39-L42 instead

Re: [PR REVIEW] New package: cpux-4.4.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#discussion_r983924129

Comment:
- why is automake needed?
- cmake doesn't need to be specified
- pkg-config should only be a hostmakedepend
- only put `-devel` packages in makedepends
- missing `pciutils-devel`, `glfw-devel` (probably also need `configure_args="-DWITH_VULKAN=OFF"`)
- non-devel versions of makedepends do not need to be specified anywhere

Re: New package: cpux-4.4.0

[zlice]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/39533#issuecomment-1262701378

Comment:
Will do what tinfoil said. Sorry.

Re: [PR PATCH] [Closed]: New package: cpux-4.4.0

[zlice]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

There's a closed pull request on the void-packages repository

New package: cpux-4.4.0
https://github.com/void-linux/void-packages/pull/39533

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

![cpux_about](https://user-images.githubusercontent.com/8009811/193115449-572358a3-56cf-4459-9849-e3b5dc2aaaee.png)

Did not test 'daemon' only basic CPU info.

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture **x86_64**


#### unsure

- License is `GPL-3.0`, put `-or-later`
- are cmake config args redundant?
- added `nopie=yes` for cpu-x-daemon