* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
@ 2022-10-08 15:11 ` ahesford
2022-10-08 15:28 ` classabbyamp
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ahesford @ 2022-10-08 15:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1272339733
Comment:
Seeking comments from @void-linux/pkg-committers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
2022-10-08 15:11 ` ahesford
@ 2022-10-08 15:28 ` classabbyamp
2022-10-10 10:03 ` Duncaen
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2022-10-08 15:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1272342644
Comment:
I like the idea.
I think having multiple `base-` packages installed might be confusing to people, so maybe the alternative approach would be better.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
2022-10-08 15:11 ` ahesford
2022-10-08 15:28 ` classabbyamp
@ 2022-10-10 10:03 ` Duncaen
2022-10-10 10:03 ` Duncaen
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2022-10-10 10:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273073711
Comment:
This means building `base-minima` requires a lot more dependencies, not sure how useful this really is.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (2 preceding siblings ...)
2022-10-10 10:03 ` Duncaen
@ 2022-10-10 10:03 ` Duncaen
2022-10-10 10:11 ` Duncaen
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2022-10-10 10:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273073711
Comment:
This means building `base-minima;` requires a lot more dependencies, not sure how useful this really is.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (3 preceding siblings ...)
2022-10-10 10:03 ` Duncaen
@ 2022-10-10 10:11 ` Duncaen
2022-10-10 10:12 ` Duncaen
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2022-10-10 10:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273083426
Comment:
Also not a fan of having the base packages depend on other base packages, this just obfuscates the dependencies for no good reason.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (4 preceding siblings ...)
2022-10-10 10:11 ` Duncaen
@ 2022-10-10 10:12 ` Duncaen
2022-10-10 14:02 ` classabbyamp
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2022-10-10 10:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273073711
Comment:
This means building `base-minimal` requires a lot more dependencies, not sure how useful this really is.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (5 preceding siblings ...)
2022-10-10 10:12 ` Duncaen
@ 2022-10-10 14:02 ` classabbyamp
2022-10-10 14:11 ` sgn
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2022-10-10 14:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273362619
Comment:
> This means building `base-minimal` requires a lot more dependencies, not sure how useful this really is.
what about a build option that disables the subpackages for bootstrapping?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (6 preceding siblings ...)
2022-10-10 14:02 ` classabbyamp
@ 2022-10-10 14:11 ` sgn
2022-10-10 14:28 ` ahesford
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2022-10-10 14:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273377450
Comment:
I think it's better to have 3 separated packages. I like the chain dependency, though.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (7 preceding siblings ...)
2022-10-10 14:11 ` sgn
@ 2022-10-10 14:28 ` ahesford
2022-10-10 14:47 ` Duncaen
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ahesford @ 2022-10-10 14:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273403437
Comment:
I don't understand why adding more dependencies to the build of `base-minimal` is a concern. We don't use it for bootstrapping; that's what `base-chroot` is for, and that's still a separate template. Maybe it adds a little more time to the build, but:
1. As far as CI and official builds are concerned, we ought to keep these dependencies in sync anyway, so any update to `base-minimal` ought to include corresponding updates to `-voidstrap` and `-system`; in that case, the build time is actually *reduced* by avoiding triple package installations.
2. Are people really building custom `base-minimal` on their own enough that we should be concerned that sombody winds up fetching the Linux kernel when building the package from the merged template? Meh.
Regarding the dependency chain: I recognize the potential for confusion or annoyance when trying to understand the full list of dependencies of the more featureful bases, but I'm not sure whether that's offset by the fact that chained dependencies makes it more obvious how the packages are related. We've seen a few questions asking for clarity about the differences, and `run_depends: base-minimal [...]` is pretty obvious in that regard. Either way, I can switch to the alternative approach (common variables in a common template to satisfy DRY while avoiding nested dependencies) if there is strong support there.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (8 preceding siblings ...)
2022-10-10 14:28 ` ahesford
@ 2022-10-10 14:47 ` Duncaen
2022-10-11 17:46 ` [PR PATCH] [Closed]: " ahesford
2022-10-11 17:47 ` ahesford
11 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2022-10-10 14:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1273429882
Comment:
I don't really see a strong reason to unify those templates and more reason to not change anything.
- Additional build dependencies for smaller `base-*` packages.
- Changing one of the `base-*` packages requiring an "update" for all.
- More confusing to keep the order of dependencies right (important for example `gawk` being before any other dependency that pulls in the `awk` virtual package.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (9 preceding siblings ...)
2022-10-10 14:47 ` Duncaen
@ 2022-10-11 17:46 ` ahesford
2022-10-11 17:47 ` ahesford
11 siblings, 0 replies; 13+ messages in thread
From: ahesford @ 2022-10-11 17:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
There's a closed pull request on the void-packages repository
[RFC] base-{minimal,voidstrap,system}: unify base packages
https://github.com/void-linux/void-packages/pull/39814
Description:
Unifying the three alternative base packages makes it easier to manage dependencies consistently, and having successively more featureful packages depend on the next more spartan package makes the additional inclusions more obvious.
If there is any real reason not to have a `base-system -> base-voidstrap -> base-minimal` dependency chain, we can still preserve dependency maintainability by defining, *e.g.*,
```sh
_minimal_depends="[...]"
_voidstrap_depends="${_minimal_depends} [...]"
```
in the header.
#### Testing the changes
- I tested the changes in this PR: **NO**
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC] base-{minimal,voidstrap,system}: unify base packages
2022-10-08 15:09 [PR PATCH] [RFC] base-{minimal,voidstrap,system}: unify base packages ahesford
` (10 preceding siblings ...)
2022-10-11 17:46 ` [PR PATCH] [Closed]: " ahesford
@ 2022-10-11 17:47 ` ahesford
11 siblings, 0 replies; 13+ messages in thread
From: ahesford @ 2022-10-11 17:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/39814#issuecomment-1275059846
Comment:
I can't strongly defend against the criticisms here, so we might as well just persist with the status quo.
^ permalink raw reply [flat|nested] 13+ messages in thread