Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] webkit2gtk: remove common
@ 2022-10-22 12:02 oreo639
  2022-10-22 12:03 ` [PR PATCH] [Updated] " oreo639
                   ` (27 more replies)
  0 siblings, 28 replies; 29+ messages in thread
From: oreo639 @ 2022-10-22 12:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages webkit2gtk
https://github.com/void-linux/void-packages/pull/40103

webkit2gtk: remove common
webkit2gtk generates unique locale files for each version so the common package is redundant.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-webkit2gtk-40103.patch --]
[-- Type: text/x-diff, Size: 3304 bytes --]

From fbf9425e2101db651ac6c8a2c6a0230896d041ad Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Sat, 22 Oct 2022 04:17:15 -0700
Subject: [PATCH] webkit2gtk: remove common

webkit2gtk generates unique locale files for each version so the
common package is redundant.
---
 srcpkgs/webkit2gtk/template | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/webkit2gtk/template b/srcpkgs/webkit2gtk/template
index 10602fae9f2d..185ae4d20e0b 100644
--- a/srcpkgs/webkit2gtk/template
+++ b/srcpkgs/webkit2gtk/template
@@ -1,7 +1,7 @@
 # Template file for 'webkit2gtk'
 pkgname=webkit2gtk
 version=2.38.1
-revision=1
+revision=2
 wrksrc="webkitgtk-${version}"
 build_style=cmake
 build_helper="gir"
@@ -31,7 +31,6 @@ makedepends="at-spi2-core-devel libjpeg-turbo-devel libpng-devel
  qt5-devel libmanette-devel libwpe-devel wpebackend-fdo-devel
  libgcrypt-devel libnuspell-devel libpsl-devel $(vopt_if x11 libXt-devel)
  $(vopt_if wayland 'MesaLib-devel libxkbcommon-devel wayland-devel wayland-protocols')"
-depends="webkit2gtk-common"
 short_desc="GTK+3 port of the WebKit2 browser engine"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later, BSD-2-Clause"
@@ -40,6 +39,8 @@ distfiles="https://webkitgtk.org/releases/webkitgtk-${version}.tar.xz"
 checksum=02e195b3fb9e057743b3364ee7f1eec13f71614226849544c07c32a73b8f1848
 make_check=no
 
+replaces="webkit2gtk-common"
+
 build_options="gir wayland x11 bubblewrap jit sampling_profiler minibrowser
  clang lto gtk_doc"
 build_options_default="gir wayland x11 bubblewrap minibrowser"
@@ -67,7 +68,7 @@ fi
 if [ "$build_option_bubblewrap" ]; then
 	hostmakedepends+=" bubblewrap xdg-dbus-proxy"
 	makedepends+=" libseccomp-devel"
-	depends+=" bubblewrap xdg-dbus-proxy"
+	depends="bubblewrap xdg-dbus-proxy"
 fi
 
 if [ "$build_option_lto" -a -z "$build_option_clang" ]; then
@@ -166,6 +167,11 @@ post_install() {
 	vlicense Source/WebCore/LICENSE-LGPL-2
 }
 
+webkit2gtk-common_package() {
+	short_desc="GTK port of the WebKit2 browser engine - common files (transitional dummy package)"
+	build_style=meta
+}
+
 webkit2gtk-devel_package() {
 	depends="gtk+3-devel libsoup-devel ${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
@@ -182,14 +188,6 @@ webkit2gtk-devel_package() {
 	}
 }
 
-webkit2gtk-common_package() {
-	short_desc="GTK port of the WebKit2 browser engine - common files"
-	pkg_install() {
-		vmove usr/share/locale/
-		vmove usr/share/licenses/
-	}
-}
-
 libwebkit2gtk41_package() {
 	depends="${depends}"
 	short_desc="GTK+3 port of the WebKit2 browser engine (soup3)"
@@ -201,6 +199,10 @@ libwebkit2gtk41_package() {
 			vmove "usr/lib/girepository-1.0/*-4.1.typelib"
 		fi
 		vmove "usr/lib/*-4.1.so.*"
+		vmove "usr/share/locale/locale/*/LC_MESSAGES/*-4.1.*"
+		vlicense Source/WebCore/LICENSE-APPLE
+		vlicense Source/WebCore/LICENSE-LGPL-2.1
+		vlicense Source/WebCore/LICENSE-LGPL-2
 	}
 }
 
@@ -230,6 +232,10 @@ libwebkit2gtk50_package() {
 			vmove "usr/lib/girepository-1.0/*-5.0.typelib"
 		fi
 		vmove "usr/lib/*-5.0.so.*"
+		vmove "usr/share/locale/locale/*/LC_MESSAGES/*-4.0.*"
+		vlicense Source/WebCore/LICENSE-APPLE
+		vlicense Source/WebCore/LICENSE-LGPL-2.1
+		vlicense Source/WebCore/LICENSE-LGPL-2
 	}
 }
 

^ permalink raw reply	[flat|nested] 29+ messages in thread
end of thread, other threads:[~2022-10-26 18:58 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-22 12:02 [PR PATCH] webkit2gtk: remove common oreo639
2022-10-22 12:03 ` [PR PATCH] [Updated] " oreo639
2022-10-22 12:09 ` oreo639
2022-10-22 12:19 ` oreo639
2022-10-22 12:20 ` [PR REVIEW] " sgn
2022-10-22 12:25 ` [PR PATCH] [Updated] " oreo639
2022-10-22 12:35 ` oreo639
2022-10-22 20:20 ` oreo639
2022-10-22 20:25 ` oreo639
2022-10-22 20:27 ` oreo639
2022-10-22 20:27 ` oreo639
2022-10-22 20:52 ` [PR PATCH] [Updated] webkit2gtk: remove common subpkg oreo639
2022-10-22 20:52 ` oreo639
2022-10-22 20:56 ` [PR PATCH] [Updated] webkit2gtk: remove webkit2gtk-common subpackage oreo639
2022-10-22 20:57 ` oreo639
2022-10-22 23:21 ` oreo639
2022-10-23  3:11 ` oreo639
2022-10-26  8:47 ` [PR REVIEW] " paper42
2022-10-26  8:49 ` paper42
2022-10-26  9:12 ` oreo639
2022-10-26  9:12 ` oreo639
2022-10-26  9:14 ` [PR PATCH] [Updated] " oreo639
2022-10-26  9:17 ` [PR REVIEW] " oreo639
2022-10-26  9:17 ` oreo639
2022-10-26  9:18 ` oreo639
2022-10-26 18:35 ` paper42
2022-10-26 18:41 ` oreo639
2022-10-26 18:42 ` [PR PATCH] [Updated] " oreo639
2022-10-26 18:58 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).