* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
@ 2022-10-22 16:26 ` JamiKettunen
2022-10-22 18:15 ` classabbyamp
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: JamiKettunen @ 2022-10-22 16:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287846414
Comment:
I'll add my comment here just in case it gets lost in `#xbps`: in the future couldn't we just e.g. make `xbps-src` error (in strict mode?) in case there's a space / newline character in the `distfiles` without `create_wrksrc` set? could possibly work as an addition to `xlint` as well
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
2022-10-22 16:26 ` JamiKettunen
@ 2022-10-22 18:15 ` classabbyamp
2022-10-22 18:19 ` tranzystorek-io
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-10-22 18:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287873437
Comment:
imo it would be better to automatically set create_wrksrc if there's multiple distfiles
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
2022-10-22 16:26 ` JamiKettunen
2022-10-22 18:15 ` classabbyamp
@ 2022-10-22 18:19 ` tranzystorek-io
2022-10-22 19:17 ` paper42
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tranzystorek-io @ 2022-10-22 18:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287874061
Comment:
`iaito` seems to only have one distfile, a typo of sorts?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (2 preceding siblings ...)
2022-10-22 18:19 ` tranzystorek-io
@ 2022-10-22 19:17 ` paper42
2022-10-22 19:23 ` tranzystorek-io
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-10-22 19:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287888692
Comment:
> `iaito` seems to only have one distfile, a typo of sorts?
It was a wrong grep that matched many false positives, removed now, thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (3 preceding siblings ...)
2022-10-22 19:17 ` paper42
@ 2022-10-22 19:23 ` tranzystorek-io
2022-10-23 0:30 ` sgn
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tranzystorek-io @ 2022-10-22 19:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287889808
Comment:
`fs-utils` skips extraction of the license distfile, is `create_wrksrc` necessary in this case?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (4 preceding siblings ...)
2022-10-22 19:23 ` tranzystorek-io
@ 2022-10-23 0:30 ` sgn
2022-10-23 0:51 ` sgn
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2022-10-23 0:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287959754
Comment:
> `fs-utils` skips extraction of the license distfile, is `create_wrksrc` necessary in this case?
IMO, yes, it will help move to auto create wrksrc later easier. So, we won't have case like:
- building cmake-gui to ensure build is good after updating Qt, run into failure
- try to build cmake to see if it's still good. Now, `cmake` will use `cmake-gui`'s `wrksrc`
Also, case to consider set `-fdebug-prefix-map=$wrksrc/$build_wrksrc`, (OK, this has been done by me).
`-ffile-prefix-map` and `-fmacro-prefix-map`
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (5 preceding siblings ...)
2022-10-23 0:30 ` sgn
@ 2022-10-23 0:51 ` sgn
2022-11-08 16:18 ` sgn
2022-11-08 16:20 ` [ISSUE] [CLOSED] " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2022-10-23 0:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1287964563
Comment:
That said, if the number of distfiles that not in skip_extraction list is 1, we should avoid create_wrksrc, but that's another story.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (6 preceding siblings ...)
2022-10-23 0:51 ` sgn
@ 2022-11-08 16:18 ` sgn
2022-11-08 16:20 ` [ISSUE] [CLOSED] " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2022-11-08 16:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/40071#issuecomment-1307477299
Comment:
Now #40122 has been merged, I think we should close this now.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [ISSUE] [CLOSED] [Tracking] Packages with multiple distfiles without create_wrksrc
2022-10-21 0:06 [ISSUE] [Tracking] Packages with multiple distfiles without create_wrksrc paper42
` (7 preceding siblings ...)
2022-11-08 16:18 ` sgn
@ 2022-11-08 16:20 ` classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-11-08 16:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]
Closed issue by paper42 on void-packages repository
https://github.com/void-linux/void-packages/issues/40071
Description:
Packages that have multiple distfiles should use create_wrksrc to make sure all sources get cleaned up when the build is done and everything is contained in one directory. Manual.md already instructs people to use create_wrksrc every time there are multiple distfiles, but in practice there is a lot of templates that don't follow this.
- [ ] 7kaa
- [ ] EmptyEpsilon
- [ ] EmulationStation
- [ ] Fritzing
- [ ] LanguageTool
- [ ] OpenRCT2
- [ ] Waybar
- [ ] Z80Explorer
- [ ] acmetool
- [ ] antlr3-bin
- [ ] apache-fop
- [ ] apache-maven
- [ ] app-builder
- [ ] arcan
- [ ] avahi
- [ ] avahi-discover
- [ ] babashka
- [ ] barrier
- [ ] bitcoin
- [ ] browsh
- [ ] bumblebee-status
- [ ] cargo
- [ ] cavestory
- [ ] cgit
- [ ] choosenim
- [ ] composer
- [ ] composer8.0
- [ ] composer8.1
- [ ] cracklib
- [ ] crda
- [ ] daemontools
- [ ] deadbeef
- [ ] debootstrap
- [ ] dolphin-emu
- [ ] ekushey-fonts-ttf
- [ ] exa
- [ ] fah
- [ ] fairy-stockfish
- [ ] fcitx
- [ ] fcitx-libpinyin
- [ ] fcitx5
- [ ] fcitx5-chinese-addons
- [ ] fcitx5-zhuyin
- [ ] gendesk
- [ ] gmic
- [ ] grafana
- [ ] grafx2
- [ ] gucharmap
- [ ] gzdoom
- [ ] ipe
- [ ] jmol
- [ ] juCi++
- [ ] kristall
- [ ] lc0
- [ ] leiningen
- [ ] leocad
- [ ] libime
- [ ] libime-jyutping
- [ ] libluv
- [ ] libpinyin
- [ ] lightzone
- [ ] maturin
- [ ] minetest
- [ ] mkinitcpio-encryptssh
- [ ] monero
- [ ] monero-gui
- [ ] mons
- [ ] mpc-qt
- [ ] msttcorefonts
- [ ] musescore
- [ ] notmuch
- [ ] nsjail
- [ ] ocs-url
- [ ] offo-hyphenation
- [ ] openjdk15-bootstrap
- [ ] openjdk16-bootstrap
- [ ] opensonic
- [ ] par
- [ ] pasmo
- [ ] perl
- [ ] pijul
- [x] pipewire 5d02a92eede1ff48ac50ed634c4871d281c2ec18
- [ ] plex-media-player
- [ ] poppler
- [ ] prometheus-cpp
- [ ] pymol
- [ ] python3-colored-traceback
- [ ] python3-discogs_client
- [ ] python3-pytest-xvfb
- [ ] python3-webencodings
- [ ] qflipper
- [ ] qt5-webengine
- [ ] radamsa
- [ ] renderdoc
- [ ] rstudio
- [ ] sage-data-conway_polynomials
- [ ] sage-data-elliptic_curves
- [ ] sbsigntool
- [ ] sc
- [ ] sc3-plugins
- [ ] scrcpy
- [ ] solvespace
- [ ] stack
- [ ] stockfish
- [ ] stremio-shell
- [ ] sunpinyin
- [ ] tcpflow
- [ ] textadept
- [ ] tg_owt
- [ ] tigervnc
- [ ] tty-clock
- [ ] tvbrowser
- [ ] upwork
- [ ] volk
- [ ] wabt
- [ ] wally-udev-rules
- [ ] wasmtime
- [x] wayfire 2d4987a20bb498bdeab34e1db8c17447a138ac11
- [ ] words-web2
- [ ] yaboot
^ permalink raw reply [flat|nested] 10+ messages in thread