From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
Date: Thu, 17 Nov 2022 12:02:49 +0100 [thread overview]
Message-ID: <20221117110249.6zzBw0XD-JPXAtFaWI4kxMsIOZr15KpjlLo7hB9Ywfc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40569@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025047015
Comment:
Check can run multiple times, but rm will only succeed the first time because the file will be deleted then. Use -f or maybe better, add --deselect to pytest args instead.
```suggestion
PYTHONPATH="$(cd build/lib* && pwd)" pytest
rm -f tests/test_uinput.py # permission issue with /dev/uinput
```
next prev parent reply other threads:[~2022-11-17 11:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 10:26 [PR PATCH] " icp1994
2022-11-17 10:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 11:02 ` paper42 [this message]
2022-11-17 11:07 ` [PR REVIEW] " paper42
2022-11-17 11:08 ` paper42
2022-11-17 13:14 ` icp1994
2022-11-17 13:29 ` icp1994
2022-11-17 13:32 ` paper42
2022-11-17 13:34 ` paper42
2022-11-17 13:38 ` icp1994
2022-11-17 13:39 ` icp1994
2022-11-17 13:39 ` paper42
2022-11-17 13:45 ` ahesford
2022-11-17 13:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 13:53 ` [PR REVIEW] " icp1994
2022-11-17 14:00 ` ahesford
2022-11-21 21:19 ` tornaria
2022-11-21 21:30 ` ahesford
2022-11-21 21:44 ` tornaria
2022-11-21 21:46 ` ahesford
2022-11-22 5:36 ` icp1994
2022-12-16 18:19 ` paper42
2022-12-17 13:25 ` [PR PATCH] [Updated] " icp1994
2022-12-17 17:26 ` tornaria
2022-12-17 19:55 ` paper42
2022-12-18 11:02 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117110249.6zzBw0XD-JPXAtFaWI4kxMsIOZr15KpjlLo7hB9Ywfc@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).