From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
Date: Thu, 17 Nov 2022 15:00:34 +0100 [thread overview]
Message-ID: <20221117140034.ANOALx6b0p6ANEBb9B8cT-I-VBXtxsIU-jH8m4MWHgc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40569@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40569#discussion_r1025230818
Comment:
I think `python3 -m pytest` solved some issues at the time we added support for pytest in the build style. I'm not sure if it's still relevant. If the build style is changed, we should run through tests in at least a random sample of packages to have confidence that the change isn't causing more harm than good.
Keeping the module form in the pep517 style is probably the right behavior, because it's better to try running tests from the current directory than to fail when the pep517 builder leaves no stages package available for test.
next prev parent reply other threads:[~2022-11-17 14:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 10:26 [PR PATCH] " icp1994
2022-11-17 10:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 11:02 ` [PR REVIEW] " paper42
2022-11-17 11:07 ` paper42
2022-11-17 11:08 ` paper42
2022-11-17 13:14 ` icp1994
2022-11-17 13:29 ` icp1994
2022-11-17 13:32 ` paper42
2022-11-17 13:34 ` paper42
2022-11-17 13:38 ` icp1994
2022-11-17 13:39 ` icp1994
2022-11-17 13:39 ` paper42
2022-11-17 13:45 ` ahesford
2022-11-17 13:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 13:53 ` [PR REVIEW] " icp1994
2022-11-17 14:00 ` ahesford [this message]
2022-11-21 21:19 ` tornaria
2022-11-21 21:30 ` ahesford
2022-11-21 21:44 ` tornaria
2022-11-21 21:46 ` ahesford
2022-11-22 5:36 ` icp1994
2022-12-16 18:19 ` paper42
2022-12-17 13:25 ` [PR PATCH] [Updated] " icp1994
2022-12-17 17:26 ` tornaria
2022-12-17 19:55 ` paper42
2022-12-18 11:02 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117140034.ANOALx6b0p6ANEBb9B8cT-I-VBXtxsIU-jH8m4MWHgc@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).