Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] srcpkgs: add missing python3 dependency in python3 packages
Date: Thu, 17 Nov 2022 14:29:53 +0100	[thread overview]
Message-ID: <20221117132953.MTifSwqT7I52QjTwkLjkBFcEi8UzvVXydISQWa7EtcY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40569@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 9010 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40569#discussion_r1025190470

Comment:
There are a couple extra tests being run by the setup,py test method. Here's the output in the current state:
```
=> python3-pplpy-0.8.7_3: running do_check ...
/builddir/python3-pplpy-0.8.7/setup.py:14: SetuptoolsDeprecationWarning: As setuptools moves its configuration towards `pyproject.toml`,
`setuptools.config.read_configuration` became deprecated.

For the time being, you can use the `setuptools.config.setupcfg` module
to access a backward compatible API, but this module is provisional
and might be removed in the future.

  conf_dict = read_configuration(os.path.join(dir_path, "setup.cfg"))
running test
copying ./tests/testpplpy.pyx -> /tmp/tmp3ane4nvz
creating /tmp/tmp3ane4nvz/__pycache__
copying ./tests/__pycache__/test_constraint.cpython-311-pytest-7.1.3.pyc -> /tmp/tmp3ane4nvz/__pycache__
copying ./tests/__pycache__/test_variable.cpython-311-pytest-7.1.3.pyc -> /tmp/tmp3ane4nvz/__pycache__
copying ./tests/testpplpy2.pyx -> /tmp/tmp3ane4nvz
copying ./tests/setup2.py -> /tmp/tmp3ane4nvz
copying ./tests/test_constraint.py -> /tmp/tmp3ane4nvz
copying ./tests/runtests.py -> /tmp/tmp3ane4nvz
copying ./tests/setup.py -> /tmp/tmp3ane4nvz
copying ./tests/test_variable.py -> /tmp/tmp3ane4nvz
test_creation_invalid (test_variable.TestVariable.test_creation_invalid) ... ok
test_creation_valid (test_variable.TestVariable.test_creation_valid) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK
test_creation_empty (test_constraint.TestConstraint.test_creation_empty) ... ok
test_creation_invalid (test_constraint.TestConstraint.test_creation_invalid) ... ok
test_creation_other (test_constraint.TestConstraint.test_creation_other) ... ok
test_creation_empty (test_constraint.TestConstraint_System.test_creation_empty) ... ok
test_creation_invalid (test_constraint.TestConstraint_System.test_creation_invalid) ... ok
test_creation_other (test_constraint.TestConstraint_System.test_creation_other) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.001s

OK
Running pplpy doctests
--------------------------------------------------------------------------------
<module 'ppl' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/__init__.py'>
TestResults(failed=0, attempted=34)
--------------------------------------------------------------------------------
<module 'ppl.linear_algebra' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/linear_algebra.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=402)
--------------------------------------------------------------------------------
<module 'ppl.mip_problem' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/mip_problem.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=394)
--------------------------------------------------------------------------------
<module 'ppl.polyhedron' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/polyhedron.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=1204)
--------------------------------------------------------------------------------
<module 'ppl.generator' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/generator.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=468)
--------------------------------------------------------------------------------
<module 'ppl.constraint' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/constraint.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=478)
--------------------------------------------------------------------------------
<module 'ppl.congruence' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/congruence.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=156)
--------------------------------------------------------------------------------
<module 'ppl.bit_arrays' from '/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl/bit_arrays.cpython-311-x86_64-linux-gnu.so'>
TestResults(failed=0, attempted=102)
--------------------------------------------------------------------------------
Running unittests
--------------------------------------------------------------------------------
/usr/lib/python3.11/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp3ane4nvz/testpplpy.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
Compiling testpplpy.pyx because it changed.
[1/1] Cythonizing testpplpy.pyx
running build_ext
building 'testpplpy' extension
creating build
creating build/temp.linux-x86_64-cpython-311
cc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. -fPIC -I/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl -I/usr/include/python3.11 -c testpplpy.cpp -o build/temp.linux-x86_64-cpython-311/testpplpy.o
creating build/lib.linux-x86_64-cpython-311
g++ -shared -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. build/temp.linux-x86_64-cpython-311/testpplpy.o -L/usr/lib64 -lppl -o build/lib.linux-x86_64-cpython-311/testpplpy.cpython-311-x86_64-linux-gnu.so
copying build/lib.linux-x86_64-cpython-311/testpplpy.cpython-311-x86_64-linux-gnu.so -> 
--------------------------------------------------------------------------------
Cython test 1 OK
--------------------------------------------------------------------------------
Generator_System {ray(1, 0, -1), ray(0, 1, -1), point(0/1, 0/1, 1/1)}
dim = 3
--------------------------------------------------------------------------------
Cython example 1 OK
--------------------------------------------------------------------------------
/usr/lib/python3.11/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /tmp/tmp3ane4nvz/testpplpy2.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
Compiling testpplpy2.pyx because it changed.
[1/1] Cythonizing testpplpy2.pyx
running build_ext
building 'testpplpy2' extension
cc -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -g -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. -fPIC -I/builddir/python3-pplpy-0.8.7/build/lib.linux-x86_64-cpython-311/ppl -I/usr/include/python3.11 -c testpplpy2.cpp -o build/temp.linux-x86_64-cpython-311/testpplpy2.o
g++ -shared -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -fdebug-prefix-map=/builddir/python3-pplpy-0.8.7=. build/temp.linux-x86_64-cpython-311/testpplpy2.o -L/usr/lib64 -lppl -o build/lib.linux-x86_64-cpython-311/testpplpy2.cpython-311-x86_64-linux-gnu.so
copying build/lib.linux-x86_64-cpython-311/testpplpy2.cpython-311-x86_64-linux-gnu.so -> 
--------------------------------------------------------------------------------
Cython test 2 OK
--------------------------------------------------------------------------------
Generator_System {ray(1, 0, -1), ray(0, 1, -1), point(0/1, 0/1, 1/1)}
dim = 3
--------------------------------------------------------------------------------
Cython example 2 OK
--------------------------------------------------------------------------------
=> python3-pplpy-0.8.7_3: running pre-install hook: 00-libdir ...
```

The pytest output in comparison:
```
=> python3-pplpy-0.8.7_3: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.11.0, pytest-7.1.3, pluggy-1.0.0
rootdir: /builddir/python3-pplpy-0.8.7
collected 8 items

tests/test_constraint.py ......                                          [ 75%]
tests/test_variable.py ..                                                [100%]

============================== 8 passed in 0.04s ===============================
=> python3-pplpy-0.8.7_3: running pre-install hook: 00-libdir ...
```

  parent reply	other threads:[~2022-11-17 13:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 10:26 [PR PATCH] " icp1994
2022-11-17 10:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 11:02 ` [PR REVIEW] " paper42
2022-11-17 11:07 ` paper42
2022-11-17 11:08 ` paper42
2022-11-17 13:14 ` icp1994
2022-11-17 13:29 ` icp1994 [this message]
2022-11-17 13:32 ` paper42
2022-11-17 13:34 ` paper42
2022-11-17 13:38 ` icp1994
2022-11-17 13:39 ` icp1994
2022-11-17 13:39 ` paper42
2022-11-17 13:45 ` ahesford
2022-11-17 13:48 ` [PR PATCH] [Updated] " icp1994
2022-11-17 13:53 ` [PR REVIEW] " icp1994
2022-11-17 14:00 ` ahesford
2022-11-21 21:19 ` tornaria
2022-11-21 21:30 ` ahesford
2022-11-21 21:44 ` tornaria
2022-11-21 21:46 ` ahesford
2022-11-22  5:36 ` icp1994
2022-12-16 18:19 ` paper42
2022-12-17 13:25 ` [PR PATCH] [Updated] " icp1994
2022-12-17 17:26 ` tornaria
2022-12-17 19:55 ` paper42
2022-12-18 11:02 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117132953.MTifSwqT7I52QjTwkLjkBFcEi8UzvVXydISQWa7EtcY@z \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).