* Re: spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
@ 2022-11-14 19:14 ` kruceter
2022-11-15 16:53 ` [PR PATCH] [Updated] " nbelikov
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: kruceter @ 2022-11-14 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
New comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/40486#issuecomment-1314251686
Comment:
Works for me on x86_64-musl. GCC 12 was used for building this package.
I use `qemu` from time to time for harmful operating systems with various architectures and can confirm that in my use case `qemu-system-i386` and `qemu-system-x86_64` do not crash and do not produce unexpected behavior.
[spice.txt](https://github.com/void-linux/void-packages/files/10006280/spice.txt)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
2022-11-14 19:14 ` kruceter
@ 2022-11-15 16:53 ` nbelikov
2022-11-15 16:56 ` nbelikov
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: nbelikov @ 2022-11-15 16:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
There is an updated pull request by nbelikov against master on the void-packages repository
https://github.com/nbelikov/void-packages spice
https://github.com/void-linux/void-packages/pull/40486
spice: update to 0.15.1.
Updated, and removed python 2 dependency (#38229).
#### Testing the changes
- I tested the changes in this PR: **briefly**
I didn't do much testing other than making sure that the tests pass and that `qemu-system-x86_64` doesn't crash.
The python scripts as far as I can tell are only involved in unit testing; moreover, upstream [uses python3](https://gitlab.freedesktop.org/spice/spice/-/blob/master/.gitlab-ci.yml) in their CI.
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64 (crossbuild)
A patch file from https://github.com/void-linux/void-packages/pull/40486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spice-40486.patch --]
[-- Type: text/x-diff, Size: 1792 bytes --]
From 983b56e645c92cc88817097d6d373f1e2e1fd27c Mon Sep 17 00:00:00 2001
From: Nikolay Belikov <nb@nbelikov.com>
Date: Sat, 12 Nov 2022 16:26:05 +0300
Subject: [PATCH] spice: update to 0.15.1.
---
srcpkgs/spice/template | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 7f67e27c1ac9..fb8d5918d681 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,11 +1,11 @@
# Template file for 'spice'
pkgname=spice
-version=0.15.0
+version=0.15.1
revision=1
build_style=gnu-configure
configure_args="--disable-tunnel --disable-opengl --enable-smartcard
--with-sasl --disable-static --enable-xinerama --disable-celt051"
-hostmakedepends="pkg-config python"
+hostmakedepends="pkg-config python3"
makedepends="spice-protocol libjpeg-turbo-devel pixman-devel
openssl-devel opus-devel alsa-lib-devel libXfixes-devel libXrender-devel
libXrandr-devel libsasl-devel libXinerama-devel libglib-devel libcacard-devel
@@ -16,7 +16,7 @@ maintainer="Anachron <gith@cron.world>"
license="LGPL-2.1-or-later"
homepage="http://www.spice-space.org"
distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
-checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
+checksum=ada9af67ab321916bd7eb59e3d619a4a7796c08a28c732edfc7f02fc80b1a37a
if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
broken="SPICE server only works on little endian architectures"
@@ -30,10 +30,6 @@ if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
make_check=no
fi
-post_extract() {
- sed -i 's/armv6hl/arm/g' configure # "detects" cpu from triplet.
-}
-
spice-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
2022-11-14 19:14 ` kruceter
2022-11-15 16:53 ` [PR PATCH] [Updated] " nbelikov
@ 2022-11-15 16:56 ` nbelikov
2022-11-17 17:40 ` [PR PATCH] [Updated] " nbelikov
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: nbelikov @ 2022-11-15 16:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
New comment by nbelikov on void-packages repository
https://github.com/void-linux/void-packages/pull/40486#issuecomment-1315601295
Comment:
ERROR: spice-0.15.0_1: vsed: regex "s/armv6hl/arm/g" didn't change file "configure"
It appears that this patch became obsolete at some point so I removed it altogether.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
` (2 preceding siblings ...)
2022-11-15 16:56 ` nbelikov
@ 2022-11-17 17:40 ` nbelikov
2022-11-17 17:44 ` nbelikov
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: nbelikov @ 2022-11-17 17:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
There is an updated pull request by nbelikov against master on the void-packages repository
https://github.com/nbelikov/void-packages spice
https://github.com/void-linux/void-packages/pull/40486
spice: update to 0.15.1.
Updated, and removed python 2 dependency (#38229).
#### Testing the changes
- I tested the changes in this PR: **briefly**
I didn't do much testing other than making sure that the tests pass and that `qemu-system-x86_64` doesn't crash.
The python scripts as far as I can tell are only involved in unit testing; moreover, upstream [uses python3](https://gitlab.freedesktop.org/spice/spice/-/blob/master/.gitlab-ci.yml) in their CI.
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64 (crossbuild)
A patch file from https://github.com/void-linux/void-packages/pull/40486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spice-40486.patch --]
[-- Type: text/x-diff, Size: 1995 bytes --]
From 5c3e64259b4c168752547761e77f356ece412c7a Mon Sep 17 00:00:00 2001
From: Nikolay Belikov <nb@nbelikov.com>
Date: Sat, 12 Nov 2022 16:26:05 +0300
Subject: [PATCH] spice: update to 0.15.1.
---
srcpkgs/spice/template | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/spice/template b/srcpkgs/spice/template
index 7f67e27c1ac9..20d54521c3fb 100644
--- a/srcpkgs/spice/template
+++ b/srcpkgs/spice/template
@@ -1,11 +1,11 @@
# Template file for 'spice'
pkgname=spice
-version=0.15.0
+version=0.15.1
revision=1
build_style=gnu-configure
configure_args="--disable-tunnel --disable-opengl --enable-smartcard
--with-sasl --disable-static --enable-xinerama --disable-celt051"
-hostmakedepends="pkg-config python"
+hostmakedepends="pkg-config python3"
makedepends="spice-protocol libjpeg-turbo-devel pixman-devel
openssl-devel opus-devel alsa-lib-devel libXfixes-devel libXrender-devel
libXrandr-devel libsasl-devel libXinerama-devel libglib-devel libcacard-devel
@@ -14,9 +14,10 @@ checkdepends="glib-networking"
short_desc="Implements the SPICE protocol"
maintainer="Anachron <gith@cron.world>"
license="LGPL-2.1-or-later"
-homepage="http://www.spice-space.org"
+homepage="https://www.spice-space.org/"
+changelog="https://gitlab.freedesktop.org/spice/spice/-/raw/master/CHANGELOG.md"
distfiles="https://www.spice-space.org/download/releases/spice-server/spice-${version}.tar.bz2"
-checksum=b320cf8f4bd2852750acb703c15b72856027e5a8554f8217dfbb3cc09deba0f5
+checksum=ada9af67ab321916bd7eb59e3d619a4a7796c08a28c732edfc7f02fc80b1a37a
if [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
broken="SPICE server only works on little endian architectures"
@@ -30,10 +31,6 @@ if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
make_check=no
fi
-post_extract() {
- sed -i 's/armv6hl/arm/g' configure # "detects" cpu from triplet.
-}
-
spice-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
` (3 preceding siblings ...)
2022-11-17 17:40 ` [PR PATCH] [Updated] " nbelikov
@ 2022-11-17 17:44 ` nbelikov
2022-11-18 11:27 ` paper42
2022-11-18 11:28 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: nbelikov @ 2022-11-17 17:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
New comment by nbelikov on void-packages repository
https://github.com/void-linux/void-packages/pull/40486#issuecomment-1318988778
Comment:
@paper42, I've applied your suggestions. I usually try to limit commits to minimal changes required to satisfy the intent of a commit. In future, when changing a template, should I try to improve it as much as I could in one go?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
` (4 preceding siblings ...)
2022-11-17 17:44 ` nbelikov
@ 2022-11-18 11:27 ` paper42
2022-11-18 11:28 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-11-18 11:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40486#issuecomment-1319877514
Comment:
> @paper42, I've applied your suggestions. I usually try to limit commits to minimal changes required to satisfy the intent of a commit. In future, when changing a template, should I try to improve it as much as I could in one go?
Yes, if you feel like it's not clear enough what you are doing, feel free to mention it in the commit message body.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Merged]: spice: update to 0.15.1.
2022-11-12 13:47 [PR PATCH] spice: update to 0.15.1 nbelikov
` (5 preceding siblings ...)
2022-11-18 11:27 ` paper42
@ 2022-11-18 11:28 ` paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-11-18 11:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
There's a merged pull request on the void-packages repository
spice: update to 0.15.1.
https://github.com/void-linux/void-packages/pull/40486
Description:
Updated, and removed python 2 dependency (#38229).
#### Testing the changes
- I tested the changes in this PR: **briefly**
I didn't do much testing other than making sure that the tests pass and that `qemu-system-x86_64` doesn't crash.
The python scripts as far as I can tell are only involved in unit testing; moreover, upstream [uses python3](https://gitlab.freedesktop.org/spice/spice/-/blob/master/.gitlab-ci.yml) in their CI.
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64 (crossbuild)
^ permalink raw reply [flat|nested] 8+ messages in thread