Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: xplr-0.20.0
@ 2022-11-22 22:10 devraza
  2022-11-22 22:16 ` [PR REVIEW] " classabbyamp
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: devraza @ 2022-11-22 22:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

There is a new pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 1171 bytes --]

From dc74b13a50fb9bb95929825eccc82e434930252d Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
  2022-11-22 22:16 ` [PR REVIEW] " classabbyamp
@ 2022-11-22 22:16 ` classabbyamp
  2022-11-23 10:11 ` [PR PATCH] [Updated] " devraza
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-11-22 22:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#discussion_r1029870156

Comment:
instead of overriding do_install, use post_install. you should be able to get rid of the vbin

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
@ 2022-11-22 22:16 ` classabbyamp
  2022-11-22 22:16 ` classabbyamp
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-11-22 22:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#discussion_r1029870385

Comment:
this dir should already have been created by vdoc

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
  2022-11-22 22:16 ` [PR REVIEW] " classabbyamp
  2022-11-22 22:16 ` classabbyamp
@ 2022-11-23 10:11 ` devraza
  2022-11-23 10:11 ` devraza
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 10:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 2301 bytes --]

From dc74b13a50fb9bb95929825eccc82e434930252d Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/2] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

From 0ec162828cf05b1850a6b3a753b089cb288577bf Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:10:59 +0000
Subject: [PATCH 2/2] xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.
---
 srcpkgs/xplr/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 4f56ae05852f..0f57bd0da232 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -10,11 +10,8 @@ homepage="https://github.com/sayanarjit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 
-do_install() {
+post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vmkdir usr/share/doc/xplr/
 	     vcopy docs/en/src usr/share/doc/xplr/
-	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
-	     vbin ${_bin_path}/xplr
 }

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (2 preceding siblings ...)
  2022-11-23 10:11 ` [PR PATCH] [Updated] " devraza
@ 2022-11-23 10:11 ` devraza
  2022-11-23 10:21 ` [PR REVIEW] " devraza
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 10:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 3164 bytes --]

From dc74b13a50fb9bb95929825eccc82e434930252d Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/3] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

From 0ec162828cf05b1850a6b3a753b089cb288577bf Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:10:59 +0000
Subject: [PATCH 2/3] xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.
---
 srcpkgs/xplr/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 4f56ae05852f..0f57bd0da232 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -10,11 +10,8 @@ homepage="https://github.com/sayanarjit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 
-do_install() {
+post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vmkdir usr/share/doc/xplr/
 	     vcopy docs/en/src usr/share/doc/xplr/
-	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
-	     vbin ${_bin_path}/xplr
 }

From a759cf2e50e41c60c4aa3d87f3827ccc0d295ac8 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:11:44 +0000
Subject: [PATCH 3/3] xplr: typo in homepage

---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 0f57bd0da232..7550706957d8 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -6,7 +6,7 @@ build_style=cargo
 short_desc="Hackable, minimal, fast TUI file explorer"
 maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
 license="MIT"
-homepage="https://github.com/sayanarjit/xplr"
+homepage="https://github.com/sayanarijit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (3 preceding siblings ...)
  2022-11-23 10:11 ` devraza
@ 2022-11-23 10:21 ` devraza
  2022-11-23 10:35 ` devraza
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 10:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by devraza on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#discussion_r1030259917

Comment:
Updated to use post_install() - vbin has also been removed too.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (4 preceding siblings ...)
  2022-11-23 10:21 ` [PR REVIEW] " devraza
@ 2022-11-23 10:35 ` devraza
  2022-11-23 17:15 ` devraza
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 10:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by devraza on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#discussion_r1030274269

Comment:
Removed creation of the ;usr/share/doc/xplr' directory.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (5 preceding siblings ...)
  2022-11-23 10:35 ` devraza
@ 2022-11-23 17:15 ` devraza
  2022-11-23 17:45 ` [PR PATCH] [Updated] " devraza
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 17:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by devraza on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#discussion_r1030274269

Comment:
Removed creation of the 'usr/share/doc/xplr' directory.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (6 preceding siblings ...)
  2022-11-23 17:15 ` devraza
@ 2022-11-23 17:45 ` devraza
  2022-11-24 19:04 ` devraza
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-23 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 3164 bytes --]

From 353d9178c587e43717f8068993cd351517566052 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/3] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

From 59eb32876abea4c15c3f679ef21783519f9adab7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:10:59 +0000
Subject: [PATCH 2/3] xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.
---
 srcpkgs/xplr/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 4f56ae05852f..0f57bd0da232 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -10,11 +10,8 @@ homepage="https://github.com/sayanarjit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 
-do_install() {
+post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vmkdir usr/share/doc/xplr/
 	     vcopy docs/en/src usr/share/doc/xplr/
-	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
-	     vbin ${_bin_path}/xplr
 }

From b073b7a4901daa5e9f56f3e8c8b5447d26674ad7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:11:44 +0000
Subject: [PATCH 3/3] xplr: typo in homepage

---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 0f57bd0da232..7550706957d8 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -6,7 +6,7 @@ build_style=cargo
 short_desc="Hackable, minimal, fast TUI file explorer"
 maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
 license="MIT"
-homepage="https://github.com/sayanarjit/xplr"
+homepage="https://github.com/sayanarijit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (7 preceding siblings ...)
  2022-11-23 17:45 ` [PR PATCH] [Updated] " devraza
@ 2022-11-24 19:04 ` devraza
  2022-11-25  6:56 ` icp1994
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-24 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 4263 bytes --]

From 353d9178c587e43717f8068993cd351517566052 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/4] New package: xplr-0.20.0

---
 srcpkgs/xplr/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..4f56ae05852f
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,20 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarjit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+do_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vmkdir usr/share/doc/xplr/
+	     vcopy docs/en/src usr/share/doc/xplr/
+	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
+	     vbin ${_bin_path}/xplr
+}

From 59eb32876abea4c15c3f679ef21783519f9adab7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:10:59 +0000
Subject: [PATCH 2/4] xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.
---
 srcpkgs/xplr/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 4f56ae05852f..0f57bd0da232 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -10,11 +10,8 @@ homepage="https://github.com/sayanarjit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 
-do_install() {
+post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vmkdir usr/share/doc/xplr/
 	     vcopy docs/en/src usr/share/doc/xplr/
-	     local _bin_path="${wrksrc}/target/${RUST_TARGET}/release"
-	     vbin ${_bin_path}/xplr
 }

From b073b7a4901daa5e9f56f3e8c8b5447d26674ad7 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Wed, 23 Nov 2022 10:11:44 +0000
Subject: [PATCH 3/4] xplr: typo in homepage

---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 0f57bd0da232..7550706957d8 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -6,7 +6,7 @@ build_style=cargo
 short_desc="Hackable, minimal, fast TUI file explorer"
 maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
 license="MIT"
-homepage="https://github.com/sayanarjit/xplr"
+homepage="https://github.com/sayanarijit/xplr"
 distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
 checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 

From e34dd28abf08d4bb87f44da19c17f640ac956009 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Thu, 24 Nov 2022 19:01:11 +0000
Subject: [PATCH 4/4] xplr: documentation directory itself being copied

Instead, everything inside of the documentation directory should be
copied to '/usr/share/doc/xplr'. Mistake was made as the manual stated
that the 'vcopy' function copies everything inside of the pattern, and
not the pattern itself by default. Instead, the 'vcopy' function is
able to do this, but requires a '/*' following the directory which
needs it's contents being copied.
---
 srcpkgs/xplr/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index 7550706957d8..f2948233261b 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -13,5 +13,5 @@ checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
 post_install() {
 	     vlicense LICENSE
 	     vdoc README.md
-	     vcopy docs/en/src usr/share/doc/xplr/
+	     vcopy docs/en/src/* usr/share/doc/xplr/
 }

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (8 preceding siblings ...)
  2022-11-24 19:04 ` devraza
@ 2022-11-25  6:56 ` icp1994
  2022-11-26 12:37 ` [PR PATCH] [Updated] " devraza
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: icp1994 @ 2022-11-25  6:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40704#issuecomment-1327087536

Comment:
Check out the [Alpine patch](https://git.alpinelinux.org/aports/tree/testing/xplr/remove-vendored-lua.patch) for fixing the cross build failures. And squash all your commits into a single one as per the [contributing guidelines](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes).

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (9 preceding siblings ...)
  2022-11-25  6:56 ` icp1994
@ 2022-11-26 12:37 ` devraza
  2022-12-17 14:49 ` devraza
  2022-12-17 15:22 ` [PR PATCH] [Closed]: " devraza
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-11-26 12:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 3525 bytes --]

From 62609093efe0ec4198e8b621a488eaeb14ae8a28 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH] New package: xplr-0.20.0

xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.

xplr: typo in homepage

xplr: documentation directory itself being copied

Instead, everything inside of the documentation directory should be
copied to '/usr/share/doc/xplr'. Mistake was made as the manual stated
that the 'vcopy' function copies everything inside of the pattern, and
not the pattern itself by default. Instead, the 'vcopy' function is
able to do this, but requires a '/*' following the directory which
needs it's contents being copied.

xplr: patch for cross-compiling compatibility
---
 .../xplr/patches/remove-vendored-lua.patch    | 53 +++++++++++++++++++
 srcpkgs/xplr/template                         | 18 +++++++
 2 files changed, 71 insertions(+)
 create mode 100644 srcpkgs/xplr/patches/remove-vendored-lua.patch
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/patches/remove-vendored-lua.patch b/srcpkgs/xplr/patches/remove-vendored-lua.patch
new file mode 100644
index 000000000000..a8afb8f3c03e
--- /dev/null
+++ b/srcpkgs/xplr/patches/remove-vendored-lua.patch
@@ -0,0 +1,53 @@
+--- a/Cargo.lock
++++ b/Cargo.lock
+@@ -557,27 +557,7 @@ name = "log"
+ version = "0.4.17"
+ source = "registry+https://github.com/rust-lang/crates.io-index"
+ checksum = "abb12e687cfb44aa40f41fc3978ef76448f9b6038cad6aef4259d3c095a2382e"
+-dependencies = [
+- "cfg-if",
+-]
+-
+-[[package]]
+-name = "lua-src"
+-version = "544.0.1"
+-source = "registry+https://github.com/rust-lang/crates.io-index"
+-checksum = "708ba3c844d5e9d38def4a09dd871c17c370f519b3c4b7261fbabe4a613a814c"
+-dependencies = [
+- "cc",
+-]
+-
+-[[package]]
+-name = "luajit-src"
+-version = "210.4.3+resty8384278"
+-source = "registry+https://github.com/rust-lang/crates.io-index"
+-checksum = "19ee5d5afddf1ec76ffa55ca7c3001f2f8a703834beba53c56a38ea6641cef44"
+-dependencies = [
+- "cc",
+-]
++dependencies = []
+ 
+ [[package]]
+ name = "memchr"
+@@ -637,8 +617,6 @@ dependencies = [
+  "bstr",
+  "cc",
+  "erased-serde",
+- "lua-src",
+- "luajit-src",
+  "num-traits",
+  "once_cell",
+  "pkg-config",
+diff --git a/Cargo.toml b/Cargo.toml
+index e7e21c4..048306c 100644
+--- a/Cargo.toml
++++ b/Cargo.toml
+@@ -64,7 +64,7 @@ features = ['serde']
+ 
+ [dependencies.mlua]
+ version = "0.8.4"
+-features = ['luajit', 'vendored', 'serialize', 'send']
++features = ['luajit', 'serialize', 'send']
+ 
+ [dependencies.tui-input]
+ version = "0.6.0"
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..ed0fea14c387
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,18 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+makedepends="pkg-config LuaJIT-devel"
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+post_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vcopy docs/en/src/* usr/share/doc/xplr/
+}

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (10 preceding siblings ...)
  2022-11-26 12:37 ` [PR PATCH] [Updated] " devraza
@ 2022-12-17 14:49 ` devraza
  2022-12-17 15:22 ` [PR PATCH] [Closed]: " devraza
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-12-17 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There is an updated pull request by devraza against master on the void-packages repository

https://github.com/devraza/void-packages xplr
https://github.com/void-linux/void-packages/pull/40704

New package: xplr-0.20.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40704.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xplr-40704.patch --]
[-- Type: text/x-diff, Size: 4204 bytes --]

From 62609093efe0ec4198e8b621a488eaeb14ae8a28 Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Tue, 22 Nov 2022 21:58:00 +0000
Subject: [PATCH 1/2] New package: xplr-0.20.0

xplr: use post_install() instead of do_install()

This removes the need to specify the binary to install. Additionally, the 'usr/share/doc/xplr' is automatically created by xbps, so it does need to be manually created.

xplr: typo in homepage

xplr: documentation directory itself being copied

Instead, everything inside of the documentation directory should be
copied to '/usr/share/doc/xplr'. Mistake was made as the manual stated
that the 'vcopy' function copies everything inside of the pattern, and
not the pattern itself by default. Instead, the 'vcopy' function is
able to do this, but requires a '/*' following the directory which
needs it's contents being copied.

xplr: patch for cross-compiling compatibility
---
 .../xplr/patches/remove-vendored-lua.patch    | 53 +++++++++++++++++++
 srcpkgs/xplr/template                         | 18 +++++++
 2 files changed, 71 insertions(+)
 create mode 100644 srcpkgs/xplr/patches/remove-vendored-lua.patch
 create mode 100644 srcpkgs/xplr/template

diff --git a/srcpkgs/xplr/patches/remove-vendored-lua.patch b/srcpkgs/xplr/patches/remove-vendored-lua.patch
new file mode 100644
index 000000000000..a8afb8f3c03e
--- /dev/null
+++ b/srcpkgs/xplr/patches/remove-vendored-lua.patch
@@ -0,0 +1,53 @@
+--- a/Cargo.lock
++++ b/Cargo.lock
+@@ -557,27 +557,7 @@ name = "log"
+ version = "0.4.17"
+ source = "registry+https://github.com/rust-lang/crates.io-index"
+ checksum = "abb12e687cfb44aa40f41fc3978ef76448f9b6038cad6aef4259d3c095a2382e"
+-dependencies = [
+- "cfg-if",
+-]
+-
+-[[package]]
+-name = "lua-src"
+-version = "544.0.1"
+-source = "registry+https://github.com/rust-lang/crates.io-index"
+-checksum = "708ba3c844d5e9d38def4a09dd871c17c370f519b3c4b7261fbabe4a613a814c"
+-dependencies = [
+- "cc",
+-]
+-
+-[[package]]
+-name = "luajit-src"
+-version = "210.4.3+resty8384278"
+-source = "registry+https://github.com/rust-lang/crates.io-index"
+-checksum = "19ee5d5afddf1ec76ffa55ca7c3001f2f8a703834beba53c56a38ea6641cef44"
+-dependencies = [
+- "cc",
+-]
++dependencies = []
+ 
+ [[package]]
+ name = "memchr"
+@@ -637,8 +617,6 @@ dependencies = [
+  "bstr",
+  "cc",
+  "erased-serde",
+- "lua-src",
+- "luajit-src",
+  "num-traits",
+  "once_cell",
+  "pkg-config",
+diff --git a/Cargo.toml b/Cargo.toml
+index e7e21c4..048306c 100644
+--- a/Cargo.toml
++++ b/Cargo.toml
+@@ -64,7 +64,7 @@ features = ['serde']
+ 
+ [dependencies.mlua]
+ version = "0.8.4"
+-features = ['luajit', 'vendored', 'serialize', 'send']
++features = ['luajit', 'serialize', 'send']
+ 
+ [dependencies.tui-input]
+ version = "0.6.0"
diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
new file mode 100644
index 000000000000..ed0fea14c387
--- /dev/null
+++ b/srcpkgs/xplr/template
@@ -0,0 +1,18 @@
+# Template file for 'xplr'
+pkgname=xplr
+version=0.20.0
+revision=1
+build_style=cargo
+makedepends="pkg-config LuaJIT-devel"
+short_desc="Hackable, minimal, fast TUI file explorer"
+maintainer="Muhammad Nauman Raza <thedevraza@proton.me>"
+license="MIT"
+homepage="https://github.com/sayanarijit/xplr"
+distfiles="https://github.com/sayanarijit/xplr/archive/refs/tags/v${version}.tar.gz"
+checksum=c4d63d9e1e313eeeb2e6d8d17e30b18ee4b8be01c419f08a89959fe5a4a09ac0
+
+post_install() {
+	     vlicense LICENSE
+	     vdoc README.md
+	     vcopy docs/en/src/* usr/share/doc/xplr/
+}

From dc7a036721289f60a040de195d3a5273e2e8b04d Mon Sep 17 00:00:00 2001
From: Muhammad Nauman Raza <thedevraza@proton.me>
Date: Sat, 17 Dec 2022 14:49:04 +0000
Subject: [PATCH 2/2] xplr: update to 0.20.1.

---
 srcpkgs/xplr/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/xplr/template b/srcpkgs/xplr/template
index ed0fea14c387..d2f422132f3e 100644
--- a/srcpkgs/xplr/template
+++ b/srcpkgs/xplr/template
@@ -1,7 +1,7 @@
 # Template file for 'xplr'
 pkgname=xplr
-version=0.20.0
-revision=1
+version=0.20.1
+revision=2
 build_style=cargo
 makedepends="pkg-config LuaJIT-devel"
 short_desc="Hackable, minimal, fast TUI file explorer"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Closed]: New package: xplr-0.20.0
  2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
                   ` (11 preceding siblings ...)
  2022-12-17 14:49 ` devraza
@ 2022-12-17 15:22 ` devraza
  12 siblings, 0 replies; 14+ messages in thread
From: devraza @ 2022-12-17 15:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

There's a closed pull request on the void-packages repository

New package: xplr-0.20.0
https://github.com/void-linux/void-packages/pull/40704

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-12-17 15:22 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 22:10 [PR PATCH] New package: xplr-0.20.0 devraza
2022-11-22 22:16 ` [PR REVIEW] " classabbyamp
2022-11-22 22:16 ` classabbyamp
2022-11-23 10:11 ` [PR PATCH] [Updated] " devraza
2022-11-23 10:11 ` devraza
2022-11-23 10:21 ` [PR REVIEW] " devraza
2022-11-23 10:35 ` devraza
2022-11-23 17:15 ` devraza
2022-11-23 17:45 ` [PR PATCH] [Updated] " devraza
2022-11-24 19:04 ` devraza
2022-11-25  6:56 ` icp1994
2022-11-26 12:37 ` [PR PATCH] [Updated] " devraza
2022-12-17 14:49 ` devraza
2022-12-17 15:22 ` [PR PATCH] [Closed]: " devraza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).