[PR PATCH] spotify: Fix missing icon in KDE task manager

[PR PATCH] spotify: Fix missing icon in KDE task manager

[crtxcr]

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

There is a new pull request by crtxcr against master on the void-packages repository

https://github.com/crtxcr/void-packages fix_spotify_icon
https://github.com/void-linux/void-packages/pull/40897

spotify: Fix missing icon in KDE task manager
Spotify onlys get a generic "X11" icon in the task manager. No window title is shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify. However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the title of the spotify window.

Fixes: #36615

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40897.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix_spotify_icon-40897.patch --]
[-- Type: text/x-diff, Size: 1198 bytes --]

From 63b077abaf57c6efe9c2b6e922702ce12a692d73 Mon Sep 17 00:00:00 2001
From: Albert Schwarzkopf <dev-voidlinux@quitesimple.org>
Date: Sat, 3 Dec 2022 21:20:03 +0100
Subject: [PATCH] spotify: Fix missing icon in KDE task manager

Spotify onlys get a generic "X11" icon in the task manager. No window title is
shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify.
However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the
title of the spotify window.

Fixes: #36615
---
 srcpkgs/spotify/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 50c28fc7672f..9ec23fdddc4a 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -38,6 +38,7 @@ do_install() {
 
 	# move icons to /usr/share
 	mv "${DESTDIR}/usr/libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
+	ln -s "/usr/share/spotify/icons" "${DESTDIR}/usr/libexec/spotify/icons"
 
 	# install icons
 	for _s in 16 22 24 32 48 64 128 256 512; do

Re: [PR PATCH] [Updated] spotify: Fix missing icon in KDE task manager

[crtxcr]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

There is an updated pull request by crtxcr against master on the void-packages repository

https://github.com/crtxcr/void-packages fix_spotify_icon
https://github.com/void-linux/void-packages/pull/40897

spotify: Fix missing icon in KDE task manager
Spotify onlys get a generic "X11" icon in the task manager. No window title is shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify. However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the title of the spotify window.

Fixes: #36615

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40897.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix_spotify_icon-40897.patch --]
[-- Type: text/x-diff, Size: 1391 bytes --]

From b66a2716692cc3f3d619b3c87270172f43f00b58 Mon Sep 17 00:00:00 2001
From: Albert Schwarzkopf <dev-voidlinux@quitesimple.org>
Date: Sat, 3 Dec 2022 21:20:03 +0100
Subject: [PATCH] spotify: Fix missing icon in KDE task manager

Spotify onlys get a generic "X11" icon in the task manager. No window title is
shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify.
However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the
title of the spotify window.

Fixes: #36615
---
 srcpkgs/spotify/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 50c28fc7672f..3d4098133113 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -1,7 +1,7 @@
 # Template file for 'spotify'
 pkgname=spotify
 version=1.1.84
-revision=3
+revision=4
 archs="x86_64"
 create_wrksrc=yes
 hostmakedepends="curl w3m libcurl"
@@ -38,6 +38,7 @@ do_install() {
 
 	# move icons to /usr/share
 	mv "${DESTDIR}/usr/libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
+	ln -s "/usr/share/spotify/icons" "${DESTDIR}/usr/libexec/spotify/icons"
 
 	# install icons
 	for _s in 16 22 24 32 48 64 128 256 512; do

Re: [PR REVIEW] spotify: Fix missing icon in KDE task manager

[sgn]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/40897#discussion_r1041656874

Comment:
```suggestion
	ln -s "../../libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
```

Re: [PR PATCH] [Updated] spotify: Fix missing icon in KDE task manager

[crtxcr]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

There is an updated pull request by crtxcr against master on the void-packages repository

https://github.com/crtxcr/void-packages fix_spotify_icon
https://github.com/void-linux/void-packages/pull/40897

spotify: Fix missing icon in KDE task manager
Spotify onlys get a generic "X11" icon in the task manager. No window title is shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify. However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the title of the spotify window.

Fixes: #36615

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40897.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix_spotify_icon-40897.patch --]
[-- Type: text/x-diff, Size: 1348 bytes --]

From ea8d50e1706cc763b0d205108c5d412645384b6b Mon Sep 17 00:00:00 2001
From: Albert Schwarzkopf <dev-voidlinux@quitesimple.org>
Date: Sat, 3 Dec 2022 21:20:03 +0100
Subject: [PATCH] spotify: Fix missing icon in KDE task manager

Spotify onlys get a generic "X11" icon in the task manager. No window title is
shown either.

Previously, the template moved the icons. Symlink /usr/share/spotify/icons
to /usr/libexec/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the
title of the spotify window.

Fixes: #36615
---
 srcpkgs/spotify/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 50c28fc7672f..843c95dd8b0a 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -1,7 +1,7 @@
 # Template file for 'spotify'
 pkgname=spotify
 version=1.1.84
-revision=3
+revision=4
 archs="x86_64"
 create_wrksrc=yes
 hostmakedepends="curl w3m libcurl"
@@ -36,8 +36,7 @@ do_install() {
 	vmkdir usr/libexec/
 	vcopy usr/share/spotify usr/libexec/
 
-	# move icons to /usr/share
-	mv "${DESTDIR}/usr/libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
+	ln -s "../../libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
 
 	# install icons
 	for _s in 16 22 24 32 48 64 128 256 512; do

Re: spotify: Fix missing icon in KDE task manager

[crtxcr]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by crtxcr on void-packages repository

https://github.com/void-linux/void-packages/pull/40897#issuecomment-1342747955

Comment:
@sgn Incorporated your suggestion, thx. Adjusted commit message

Re: [PR PATCH] [Merged]: spotify: Fix missing icon in KDE task manager

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

There's a merged pull request on the void-packages repository

spotify: Fix missing icon in KDE task manager
https://github.com/void-linux/void-packages/pull/40897

Description:
Spotify onlys get a generic "X11" icon in the task manager. No window title is shown either.

The template moves the "icons" folder provided by spotify to /usr/share/spotify. However, it appears that spotify searches for the icons in /usr/libexec/spotify.

Create a symlink to /usr/share/spotify/icons so spotify finds the icons again.

This makes the spotify icon appear in the KDE taskbar. It also sets the title of the spotify window.

Fixes: #36615

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->