[PR PATCH] go: update to 1.19.4.

[PR PATCH] go: update to 1.19.4.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

There is a new pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages go
https://github.com/void-linux/void-packages/pull/41027

go: update to 1.19.4.
Supersedes #40299.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-41027.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]

From ca174ee050911b5723cbddd2c86afcbb7fd5a15a Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sat, 10 Dec 2022 16:34:14 +0100
Subject: [PATCH] go: update to 1.19.4.

---
 srcpkgs/go/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 4fa13d28f6d1..532402f47bf1 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.19.2
+version=1.19.4
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -12,7 +12,7 @@ license="BSD-3-Clause"
 homepage="https://go.dev/"
 changelog="https://go.dev/doc/devel/release.html"
 distfiles="https://go.dev/dl/go${version}.src.tar.gz"
-checksum=2ce930d70a931de660fdaf271d70192793b1b240272645bf0275779f6704df6b
+checksum=eda74db4ac494800a3e66ee784e495bfbb9b8e535df924a8b01b1a8028b7f368
 nostrip=yes
 noverifyrdeps=yes
 

Re: go: update to 1.19.4.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/41027#issuecomment-1346787696

Comment:
Tests are enabled since d04e7dff0f38ec3279e0f62cc5b1e41305587ccd (#38510) and they passed at the time.
They also passed when updates to v1.19.1 (efc977cf3a0fc07b1529892286ce539d88cfc1ce, #39141) and to v1.19.2 (349efea1057ca96105424ceafef7863a640a9391, #39725) were merged.
Tests fail in this PR and in #40299, but also when rebuilding older versions, as you can see on https://github.com/r-ricci/void-packages/pull/58.
I don't know what could cause this.
@the-maldridge @subnut

Re: go: update to 1.19.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41027#issuecomment-1349605246

Comment:
```
%: git submodule update --init --recursive
git: 'submodule' is not a git command. See 'git --help'.
```
It seems like it's trying to use git from chroot-git which doesn't have the submodule subcommand, so I think adding git to checkdepends would help. The checks pass locally for me in both master and this branch. Can you reproduce this issue locally?

Re: [PR PATCH] [Updated] go: update to 1.19.4.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

There is an updated pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages go
https://github.com/void-linux/void-packages/pull/41027

go: update to 1.19.4.
Supersedes #40299.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-41027.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]

From 89858ad306c1eb8747beb5e7f240d8edf08cc5a3 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sat, 10 Dec 2022 16:34:14 +0100
Subject: [PATCH] go: update to 1.19.4.

---
 srcpkgs/go/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 4fa13d28f6d1..230b040d9090 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.19.2
+version=1.19.4
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -12,9 +12,11 @@ license="BSD-3-Clause"
 homepage="https://go.dev/"
 changelog="https://go.dev/doc/devel/release.html"
 distfiles="https://go.dev/dl/go${version}.src.tar.gz"
-checksum=2ce930d70a931de660fdaf271d70192793b1b240272645bf0275779f6704df6b
+checksum=eda74db4ac494800a3e66ee784e495bfbb9b8e535df924a8b01b1a8028b7f368
 nostrip=yes
 noverifyrdeps=yes
+# on CI it tries to use `git submodule`, which is not part of chroot-git
+make_check=ci-skip
 
 case "${XBPS_TARGET_MACHINE}" in
 	aarch64*) _goarch=arm64 ;;

Re: go: update to 1.19.4.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/41027#issuecomment-1352432381

Comment:
> ```
> %: git submodule update --init --recursive
> git: 'submodule' is not a git command. See 'git --help'.
> ```
> 
> It seems like it's trying to use git from chroot-git which doesn't have the submodule subcommand, so I think adding git to checkdepends would help. The checks pass locally for me in both master and this branch. Can you reproduce this issue locally?

You are right.
Tests failed locally for me, but for another reason. There is a known failure on ZFS and the template removes this test if ZFS is detected, but I used -t, so the filesystem was reported as "overlay". Besides this, tests pass.
On CI, adding git to checkdepends would fix the failure, but I think it's better to understand why it wants to use `git submodule` and fix that instead, so I added `make_check=ci-skip` for now.

Re: [PR PATCH] [Updated] go: update to 1.19.4.

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

There is an updated pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages go
https://github.com/void-linux/void-packages/pull/41027

go: update to 1.19.4.
Supersedes #40299.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-41027.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]

From 7591c9304ac5b617b7e280fd29e168eee17ba0ef Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sat, 10 Dec 2022 16:34:14 +0100
Subject: [PATCH] go: update to 1.19.4.

---
 srcpkgs/go/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/go/template b/srcpkgs/go/template
index 4fa13d28f6d1..230b040d9090 100644
--- a/srcpkgs/go/template
+++ b/srcpkgs/go/template
@@ -1,6 +1,6 @@
 # Template file for 'go'
 pkgname=go
-version=1.19.2
+version=1.19.4
 revision=1
 create_wrksrc=yes
 build_wrksrc=go
@@ -12,9 +12,11 @@ license="BSD-3-Clause"
 homepage="https://go.dev/"
 changelog="https://go.dev/doc/devel/release.html"
 distfiles="https://go.dev/dl/go${version}.src.tar.gz"
-checksum=2ce930d70a931de660fdaf271d70192793b1b240272645bf0275779f6704df6b
+checksum=eda74db4ac494800a3e66ee784e495bfbb9b8e535df924a8b01b1a8028b7f368
 nostrip=yes
 noverifyrdeps=yes
+# on CI it tries to use `git submodule`, which is not part of chroot-git
+make_check=ci-skip
 
 case "${XBPS_TARGET_MACHINE}" in
 	aarch64*) _goarch=arm64 ;;

Re: [PR PATCH] [Merged]: go: update to 1.19.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

There's a merged pull request on the void-packages repository

go: update to 1.19.4.
https://github.com/void-linux/void-packages/pull/41027

Description:
Supersedes #40299.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->