[PR PATCH] Update run

[PR PATCH] Update run

[sbromberger]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

There is a new pull request by sbromberger against master on the void-packages repository

https://github.com/sbromberger/void-packages patch-1
https://github.com/void-linux/void-packages/pull/41272

Update run
Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist/be loadable. The absence of the loop kmod does not appear to negatively impact docker running within a container.

Note: to run in containers, the rest of the script doesn't work either: adding `mount -t cgroup2 cgroup2 /sys/fs/cgroup/` to `/etc/rc.local` makes things work without issue. Modifying the systemd mountpoint check is too big a change to propose without extensive testing so I haven't included it as part of this PR.


#### Testing the changes
- I tested the changes in this PR: **YES***
Note: tested within a container only; I do not have access to void running on metal.

#### Local build testing
- I built this PR locally for my native architecture, `Linux boron 6.0.13_1 #1 SMP PREEMPT_DYNAMIC Fri Dec 16 02:05:26 UTC 2022 x86_64 GNU/Linux` (glibc)



A patch file from https://github.com/void-linux/void-packages/pull/41272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-41272.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

From a448be038f4277983be022ecabe25b7757cc7aa5 Mon Sep 17 00:00:00 2001
From: Seth Bromberger <sbromberger@users.noreply.github.com>
Date: Sat, 24 Dec 2022 12:51:44 -0500
Subject: [PATCH] Update run

Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist. The absence of the loop kmod does not appear to negatively impact docker running within a container.
---
 srcpkgs/moby/files/docker/run | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/moby/files/docker/run b/srcpkgs/moby/files/docker/run
index ed42f5fa72f8..438fb1a917c0 100644
--- a/srcpkgs/moby/files/docker/run
+++ b/srcpkgs/moby/files/docker/run
@@ -1,6 +1,5 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-modprobe -q loop || exit 1
 mountpoint -q /sys/fs/cgroup/systemd || {
     mkdir -p /sys/fs/cgroup/systemd;
     mount -t cgroup -o none,name=systemd cgroup /sys/fs/cgroup/systemd;

Re: Update sv run script for moby to remove loop modprobe check.

[sbromberger]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by sbromberger on void-packages repository

https://github.com/void-linux/void-packages/pull/41272#issuecomment-1364570695

Comment:
Closing pending https://github.com/void-linux/void-runit/pull/101 where we'll be able to do something more intelligent here.

Re: [PR PATCH] [Closed]: Update sv run script for moby to remove loop modprobe check.

[sbromberger]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

There's a closed pull request on the void-packages repository

Update sv run script for moby to remove loop modprobe check.
https://github.com/void-linux/void-packages/pull/41272

Description:
Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist/be loadable. The absence of the loop kmod does not appear to negatively impact docker running within a container.

Note: to run in containers, the rest of the script doesn't work either: adding `mount -t cgroup2 cgroup2 /sys/fs/cgroup/` to `/etc/rc.local` makes things work without issue. Modifying the systemd mountpoint check is too big a change to propose without extensive testing so I haven't included it as part of this PR.


#### Testing the changes
- I tested the changes in this PR: **YES***
Note: tested within a container only; I do not have access to void running on metal.

#### Local build testing
- I built this PR locally for my native architecture, `Linux boron 6.0.13_1 #1 SMP PREEMPT_DYNAMIC Fri Dec 16 02:05:26 UTC 2022 x86_64 GNU/Linux` (glibc)