* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
@ 2023-01-16 17:48 ` Vaelatern
2023-01-16 17:48 ` Vaelatern
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 17:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New review comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071477037
Comment:
Why?
We have `gtk+3-3.24.34_1`, what is the purpose of this comment?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
2023-01-16 17:48 ` [PR REVIEW] " Vaelatern
@ 2023-01-16 17:48 ` Vaelatern
2023-01-16 17:54 ` cazfi
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 17:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071477568
Comment:
This URL redirects to the fandom.com URL. Why the change?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
2023-01-16 17:48 ` [PR REVIEW] " Vaelatern
2023-01-16 17:48 ` Vaelatern
@ 2023-01-16 17:54 ` cazfi
2023-01-16 18:00 ` cazfi
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cazfi @ 2023-01-16 17:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
New review comment by cazfi on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071481803
Comment:
Freeciv gtk3-client is an older client that requires only gtk+-3.10. Freeciv gtk3.22-client is better supported client that requires gtk+-3.22 or gtk+-3.24. Because you have that gtk+-3.24.34, and have no need for the compatibility with gtk+ < 3.22, you should switch to gtk3.22-client of Freeciv.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (2 preceding siblings ...)
2023-01-16 17:54 ` cazfi
@ 2023-01-16 18:00 ` cazfi
2023-01-16 18:41 ` Vaelatern
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cazfi @ 2023-01-16 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
New review comment by cazfi on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071484868
Comment:
"https://www.freeciv.org/wiki/" is the official URL that does not make the assumption of the wiki being located on wikia. Maybe freeciv project won't be using wikia forever (and that URL worked already before migrating wiki to wikia)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (3 preceding siblings ...)
2023-01-16 18:00 ` cazfi
@ 2023-01-16 18:41 ` Vaelatern
2023-01-16 18:51 ` cazfi
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 18:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New review comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071510434
Comment:
Ah, so you are proposing
```
-_clients="gtk3,sdl2"
+_clients="gtk3.22,sdl2"
```
?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (4 preceding siblings ...)
2023-01-16 18:41 ` Vaelatern
@ 2023-01-16 18:51 ` cazfi
2023-01-16 20:54 ` [PR PATCH] [Closed]: " Vaelatern
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cazfi @ 2023-01-16 18:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New review comment by cazfi on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#discussion_r1071515411
Comment:
Yes. Likely requires more changes than that to work properly, but that's the core of it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Closed]: freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (5 preceding siblings ...)
2023-01-16 18:51 ` cazfi
@ 2023-01-16 20:54 ` Vaelatern
2023-01-16 20:55 ` Vaelatern
2023-01-16 20:55 ` Vaelatern
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
There's a closed pull request on the void-packages repository
freeciv: Use proper URLs
https://github.com/void-linux/void-packages/pull/41680
Description:
- https instead of http
- Use canonical freeciv wiki URL
Also add a TODO -comment about the need to switch from mostly deprecated gtk3-client to gtk3.22-client.
Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
NO: I don't have void-linux installation do to any testing, but the change does not touch any functionality.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (6 preceding siblings ...)
2023-01-16 20:54 ` [PR PATCH] [Closed]: " Vaelatern
@ 2023-01-16 20:55 ` Vaelatern
2023-01-16 20:55 ` Vaelatern
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#issuecomment-1384540295
Comment:
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: freeciv: Use proper URLs
2023-01-16 17:42 [PR PATCH] freeciv: Use proper URLs cazfi
` (7 preceding siblings ...)
2023-01-16 20:55 ` Vaelatern
@ 2023-01-16 20:55 ` Vaelatern
8 siblings, 0 replies; 10+ messages in thread
From: Vaelatern @ 2023-01-16 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41680#issuecomment-1384540476
Comment:
I tested the new client briefly. Seemed to work.
^ permalink raw reply [flat|nested] 10+ messages in thread