[PR PATCH] freeciv: Use proper URLs

[PR PATCH] freeciv: Use proper URLs

[cazfi]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

There is a new pull request by cazfi against master on the void-packages repository

https://github.com/cazfi/void-packages freeciv
https://github.com/void-linux/void-packages/pull/41680

freeciv: Use proper URLs
- https instead of http
- Use canonical freeciv wiki URL

Also add a TODO -comment about the need to switch from mostly deprecated gtk3-client to gtk3.22-client.

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

NO: I don't have void-linux installation do to any testing, but the change does not touch any functionality.

A patch file from https://github.com/void-linux/void-packages/pull/41680.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freeciv-41680.patch --]
[-- Type: text/x-diff, Size: 1546 bytes --]

From ab318e8824a7540839958bbdca9cd81eb7427939 Mon Sep 17 00:00:00 2001
From: Marko Lindqvist <cazfi74@gmail.com>
Date: Mon, 16 Jan 2023 19:30:29 +0200
Subject: [PATCH] freeciv: Use proper URLs

- https instead of http
- Use canonical freeciv wiki URL

Also add a TODO -comment about the need to switch from mostly deprecated
gtk3-client to gtk3.22-client.

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
---
 srcpkgs/freeciv/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/freeciv/template b/srcpkgs/freeciv/template
index aaafa7dab557..191177124dae 100644
--- a/srcpkgs/freeciv/template
+++ b/srcpkgs/freeciv/template
@@ -10,12 +10,14 @@ makedepends="SDL2_gfx-devel SDL2_image-devel SDL2_mixer-devel SDL2_ttf-devel
 short_desc="Free and Open Source empire-building strategy game - server/data"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://freeciv.org/"
-changelog="https://freeciv.fandom.com/wiki/NEWS-${version}"
+homepage="https://www.freeciv.org/"
+changelog="https://www.freeciv.org/wiki/NEWS-${version}"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
 checksum=13215adc96be9f2894d5f3a12c78b8ebb9ae06ecdab25fe6bb1794f6e6d2b61b
 nopie_files="/usr/bin/freeciv-ruledit"
 
+# TODO: gtk3 should be replaced by better supported gtk3.22 in any
+#       distribution that has gtk+-3.22 or gtk+-3.24 available.
 _clients="gtk3,sdl2"
 subpackages="freeciv-gtk2 freeciv-gtk3 freeciv-sdl freeciv-xaw"
 if [ -z "$CROSS_BUILD" ]; then

Re: [PR REVIEW] freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071477568

Comment:
This URL redirects to the fandom.com URL. Why the change?

Re: [PR REVIEW] freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071477037

Comment:
Why?

We have `gtk+3-3.24.34_1`, what is the purpose of this comment?

Re: [PR REVIEW] freeciv: Use proper URLs

[cazfi]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New review comment by cazfi on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071481803

Comment:
Freeciv gtk3-client is an older client that requires only gtk+-3.10. Freeciv gtk3.22-client is better supported client that requires gtk+-3.22 or gtk+-3.24. Because you have that gtk+-3.24.34, and have no need for the compatibility with gtk+ < 3.22, you should switch to gtk3.22-client of Freeciv.

Re: [PR REVIEW] freeciv: Use proper URLs

[cazfi]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New review comment by cazfi on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071484868

Comment:
"https://www.freeciv.org/wiki/" is the official URL that does not make the assumption of the wiki being located on wikia. Maybe freeciv project won't be using wikia forever (and that URL worked already before migrating wiki to wikia)

Re: [PR REVIEW] freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071510434

Comment:
Ah, so you are proposing

```
-_clients="gtk3,sdl2"
+_clients="gtk3.22,sdl2"
```
?

Re: [PR REVIEW] freeciv: Use proper URLs

[cazfi]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by cazfi on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#discussion_r1071515411

Comment:
Yes. Likely requires more changes than that to work properly, but that's the core of it.

Re: [PR PATCH] [Closed]: freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There's a closed pull request on the void-packages repository

freeciv: Use proper URLs
https://github.com/void-linux/void-packages/pull/41680

Description:
- https instead of http
- Use canonical freeciv wiki URL

Also add a TODO -comment about the need to switch from mostly deprecated gtk3-client to gtk3.22-client.

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

NO: I don't have void-linux installation do to any testing, but the change does not touch any functionality.

Re: freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#issuecomment-1384540295

Comment:
Thanks!

Re: freeciv: Use proper URLs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/41680#issuecomment-1384540476

Comment:
I tested the new client briefly. Seemed to work.