* [PR PATCH] python3-redis: update to 4.3.4
@ 2022-10-05 2:33 StaticVoidMoon
2022-10-05 12:09 ` StaticVoidMoon
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: StaticVoidMoon @ 2022-10-05 2:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
There is a new pull request by StaticVoidMoon against master on the void-packages repository
https://github.com/StaticVoidMoon/void-packages python3-redis
https://github.com/void-linux/void-packages/pull/39730
python3-redis: update to 4.3.4
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note:
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'.
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
A patch file from https://github.com/void-linux/void-packages/pull/39730.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-redis-39730.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]
From 96034e5ba228939099bb34df62d68d16ffbd772b Mon Sep 17 00:00:00 2001
From: StaticVoidMoon <mem+dev@lnthle.com>
Date: Wed, 5 Oct 2022 09:15:54 +0700
Subject: [PATCH] python3-redis: update to 4.3.4
---
srcpkgs/python3-redis/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/python3-redis/template b/srcpkgs/python3-redis/template
index f228a1c88df3..104542c7c7bf 100644
--- a/srcpkgs/python3-redis/template
+++ b/srcpkgs/python3-redis/template
@@ -1,17 +1,17 @@
# Template file for 'python3-redis'
pkgname=python3-redis
-version=3.5.3
-revision=4
+version=4.3.4
+revision=1
wrksrc="redis-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-packaging"
short_desc="Python3 client for Redis key-value store"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="StaticVoidMoon <mem+dev@lnthle.com>"
license="MIT"
homepage="https://github.com/andymccurdy/redis-py"
distfiles="${PYPI_SITE}/r/redis/redis-${version}.tar.gz"
-checksum=0e7e0cfca8660dea8b7d5cd8c4f6c5e29e11f31158c0b0ae91a397f00e5a05a2
+checksum=ddf27071df4adf3821c4f2ca59d67525c3a82e5f268bed97b813cb4fabf87880
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: python3-redis: update to 4.3.4
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
@ 2022-10-05 12:09 ` StaticVoidMoon
2022-10-06 15:48 ` [PR PATCH] [Updated] " StaticVoidMoon
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: StaticVoidMoon @ 2022-10-05 12:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
New comment by StaticVoidMoon on void-packages repository
https://github.com/void-linux/void-packages/pull/39730#issuecomment-1268351886
Comment:
Hi. Based on my understanding and after digging around, I found that in the check phase it will try to connect to redis for testing as copied below.
```
=> python3-redis-4.3.4_1: running do_check ...
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 611, in connect
INTERNALERROR> sock = self.retry.call_with_retry(
INTERNALERROR> File "/builddir/redis-4.3.4/redis/retry.py", line 46, in call_with_retry
INTERNALERROR> return do()
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 612, in <lambda>
INTERNALERROR> lambda: self._connect(), lambda error: self.disconnect(error)
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 677, in _connect
INTERNALERROR> raise err
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 665, in _connect
INTERNALERROR> sock.connect(socket_address)
INTERNALERROR> ConnectionRefusedError: [Errno 111] Connection refused
```
In this case, should I try to add redis as a `checkdepend` or should I just set `make_check=no`. Sorry for the trouble.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] python3-redis: update to 4.3.4
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
2022-10-05 12:09 ` StaticVoidMoon
@ 2022-10-06 15:48 ` StaticVoidMoon
2022-10-06 15:50 ` StaticVoidMoon
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: StaticVoidMoon @ 2022-10-06 15:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
There is an updated pull request by StaticVoidMoon against master on the void-packages repository
https://github.com/StaticVoidMoon/void-packages python3-redis
https://github.com/void-linux/void-packages/pull/39730
python3-redis: update to 4.3.4
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note:
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'.
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
A patch file from https://github.com/void-linux/void-packages/pull/39730.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-redis-39730.patch --]
[-- Type: text/x-diff, Size: 1292 bytes --]
From b3130a2e3bf710020162dff96bfa59d422a3c863 Mon Sep 17 00:00:00 2001
From: StaticVoidMoon <mem+dev@lnthle.com>
Date: Wed, 5 Oct 2022 09:15:54 +0700
Subject: [PATCH] python3-redis: update to 4.3.4
---
srcpkgs/python3-redis/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/python3-redis/template b/srcpkgs/python3-redis/template
index f228a1c88df3..4daa2098bb81 100644
--- a/srcpkgs/python3-redis/template
+++ b/srcpkgs/python3-redis/template
@@ -1,17 +1,18 @@
# Template file for 'python3-redis'
pkgname=python3-redis
-version=3.5.3
-revision=4
+version=4.3.4
+revision=1
wrksrc="redis-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-packaging"
short_desc="Python3 client for Redis key-value store"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="StaticVoidMoon <mem+dev@lnthle.com>"
license="MIT"
homepage="https://github.com/andymccurdy/redis-py"
distfiles="${PYPI_SITE}/r/redis/redis-${version}.tar.gz"
-checksum=0e7e0cfca8660dea8b7d5cd8c4f6c5e29e11f31158c0b0ae91a397f00e5a05a2
+checksum=ddf27071df4adf3821c4f2ca59d67525c3a82e5f268bed97b813cb4fabf87880
+make_check="no" # Check need running redis instance
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: python3-redis: update to 4.3.4
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
2022-10-05 12:09 ` StaticVoidMoon
2022-10-06 15:48 ` [PR PATCH] [Updated] " StaticVoidMoon
@ 2022-10-06 15:50 ` StaticVoidMoon
2023-01-05 1:59 ` github-actions
2023-01-19 2:01 ` [PR PATCH] [Closed]: " github-actions
4 siblings, 0 replies; 6+ messages in thread
From: StaticVoidMoon @ 2022-10-06 15:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
New comment by StaticVoidMoon on void-packages repository
https://github.com/void-linux/void-packages/pull/39730#issuecomment-1268351886
Comment:
Hi. Based on my understanding and after digging around, I found that in the check phase it will try to connect to redis for testing as copied below.
```
=> python3-redis-4.3.4_1: running do_check ...
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 611, in connect
INTERNALERROR> sock = self.retry.call_with_retry(
INTERNALERROR> File "/builddir/redis-4.3.4/redis/retry.py", line 46, in call_with_retry
INTERNALERROR> return do()
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 612, in <lambda>
INTERNALERROR> lambda: self._connect(), lambda error: self.disconnect(error)
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 677, in _connect
INTERNALERROR> raise err
INTERNALERROR> File "/builddir/redis-4.3.4/redis/connection.py", line 665, in _connect
INTERNALERROR> sock.connect(socket_address)
INTERNALERROR> ConnectionRefusedError: [Errno 111] Connection refused
```
In this case, should I try to add redis as a `checkdepend` or should I just set `make_check=no`. Sorry for the trouble.
*Edited* : After, looking at other library seem like many library related to DB need `make_check="no"` otherwise will failed at test. So, I decide to proceed with `make_check="no"`.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: python3-redis: update to 4.3.4
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
` (2 preceding siblings ...)
2022-10-06 15:50 ` StaticVoidMoon
@ 2023-01-05 1:59 ` github-actions
2023-01-19 2:01 ` [PR PATCH] [Closed]: " github-actions
4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2023-01-05 1:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/39730#issuecomment-1371652189
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: python3-redis: update to 4.3.4
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
` (3 preceding siblings ...)
2023-01-05 1:59 ` github-actions
@ 2023-01-19 2:01 ` github-actions
4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2023-01-19 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
There's a closed pull request on the void-packages repository
python3-redis: update to 4.3.4
https://github.com/void-linux/void-packages/pull/39730
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
-- DB Connect
-- Set
-- Get
-- Dump
-- Restore
-- Expire
-- Exists
#### Note:
- I add 'python3-packaging' dependency due to `import redis` error during test.
- I also presume that I need to change maintainer value from 'orphaned' to 'myself'.
#### Local build testing
- I built this PR locally for my native architecture, (x86-64)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-19 2:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 2:33 [PR PATCH] python3-redis: update to 4.3.4 StaticVoidMoon
2022-10-05 12:09 ` StaticVoidMoon
2022-10-06 15:48 ` [PR PATCH] [Updated] " StaticVoidMoon
2022-10-06 15:50 ` StaticVoidMoon
2023-01-05 1:59 ` github-actions
2023-01-19 2:01 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).