* Re: [PR PATCH] [Updated] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
@ 2023-02-25 5:02 ` carvalhudo
2023-02-25 5:04 ` carvalhudo
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-02-25 5:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
There is an updated pull request by carvalhudo against master on the void-packages repository
https://github.com/carvalhudo/void-packages adopt_i3blocks
https://github.com/void-linux/void-packages/pull/42439
i3blocks: adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/42439.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adopt_i3blocks-42439.patch --]
[-- Type: text/x-diff, Size: 883 bytes --]
From 68df9dcd232e0f80f46cd8d6a0ab305d6c0496bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?= <alcm99@gmail.com>
Date: Sat, 25 Feb 2023 01:44:26 -0300
Subject: [PATCH] i3blocks: adopt the package
---
srcpkgs/i3blocks/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/i3blocks/template b/srcpkgs/i3blocks/template
index bbd5ac987ca6..589537169939 100644
--- a/srcpkgs/i3blocks/template
+++ b/srcpkgs/i3blocks/template
@@ -7,7 +7,7 @@ make_build_args="SYSCONFDIR=/etc"
hostmakedepends="autoconf automake pkg-config"
makedepends="bash-completion"
short_desc="Flexible scheduler for i3bar"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer=" André L. C. Moreira <alcm99@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/vivien/i3blocks"
distfiles="${homepage}/archive/${version}.tar.gz"
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
2023-02-25 5:02 ` [PR PATCH] [Updated] " carvalhudo
@ 2023-02-25 5:04 ` carvalhudo
2023-02-25 19:12 ` [PR REVIEW] " mhmdanas
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-02-25 5:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
There is an updated pull request by carvalhudo against master on the void-packages repository
https://github.com/carvalhudo/void-packages adopt_i3blocks
https://github.com/void-linux/void-packages/pull/42439
i3blocks: adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/42439.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adopt_i3blocks-42439.patch --]
[-- Type: text/x-diff, Size: 882 bytes --]
From c30cfbb86d443348edddcb72314de4fc1631d6ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?= <alcm99@gmail.com>
Date: Sat, 25 Feb 2023 01:44:26 -0300
Subject: [PATCH] i3blocks: adopt the package
---
srcpkgs/i3blocks/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/i3blocks/template b/srcpkgs/i3blocks/template
index bbd5ac987ca6..c46294c686fd 100644
--- a/srcpkgs/i3blocks/template
+++ b/srcpkgs/i3blocks/template
@@ -7,7 +7,7 @@ make_build_args="SYSCONFDIR=/etc"
hostmakedepends="autoconf automake pkg-config"
makedepends="bash-completion"
short_desc="Flexible scheduler for i3bar"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <alcm99@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/vivien/i3blocks"
distfiles="${homepage}/archive/${version}.tar.gz"
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
2023-02-25 5:02 ` [PR PATCH] [Updated] " carvalhudo
2023-02-25 5:04 ` carvalhudo
@ 2023-02-25 19:12 ` mhmdanas
2023-03-01 23:17 ` carvalhudo
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: mhmdanas @ 2023-02-25 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1117964691
Comment:
```suggestion
distfiles="https://github.com/vivien/i3blocks/archive/${version}.tar.gz"
```
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (2 preceding siblings ...)
2023-02-25 19:12 ` [PR REVIEW] " mhmdanas
@ 2023-03-01 23:17 ` carvalhudo
2023-03-02 5:00 ` carvalhudo
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-03-01 23:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
New review comment by carvalhudo on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1122412187
Comment:
Thanks for your feedback. I'm not sure we should do that, because according to the [Manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) such variable is mandatory in the template file.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (3 preceding siblings ...)
2023-03-01 23:17 ` carvalhudo
@ 2023-03-02 5:00 ` carvalhudo
2023-03-02 10:34 ` mhmdanas
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-03-02 5:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
New review comment by carvalhudo on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1122412187
Comment:
Thanks for your feedback. Since the homepage variable is mandatory in the template file, I think it makes sense to reuse it to set the distfiles, instead of define the same string in two different places.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (4 preceding siblings ...)
2023-03-02 5:00 ` carvalhudo
@ 2023-03-02 10:34 ` mhmdanas
2023-03-05 19:08 ` [PR PATCH] [Updated] " carvalhudo
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: mhmdanas @ 2023-03-02 10:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1122892294
Comment:
It's kind of the new (semi-)official convention to avoid using any variables other than `version` (or related variables) in `distfiles`. For example, see the commit description in https://git.vuxu.org/xtools/commit/?id=248be132dff32a1d2ec45dce0c84f878fe8fdc51:
> It also often doesn't save any characters and not using the variable
> makes prettier, simpler URLs that can often be copied from the template
> without manually replacing variables to get to the page with sources.
The commit message is referring to `${pkgname}`, but the same idea applies to `${homepage}` too.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (5 preceding siblings ...)
2023-03-02 10:34 ` mhmdanas
@ 2023-03-05 19:08 ` carvalhudo
2023-03-05 19:09 ` [PR REVIEW] " carvalhudo
2023-03-11 7:30 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-03-05 19:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
There is an updated pull request by carvalhudo against master on the void-packages repository
https://github.com/carvalhudo/void-packages adopt_i3blocks
https://github.com/void-linux/void-packages/pull/42439
i3blocks: adopt
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/42439.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adopt_i3blocks-42439.patch --]
[-- Type: text/x-diff, Size: 1058 bytes --]
From 603102008f15abda20fe19b10107f8e4a9a44f33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?= <alcm99@gmail.com>
Date: Sat, 25 Feb 2023 01:44:26 -0300
Subject: [PATCH] i3blocks: adopt the package
---
srcpkgs/i3blocks/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/i3blocks/template b/srcpkgs/i3blocks/template
index bbd5ac987ca6..96f31f49904d 100644
--- a/srcpkgs/i3blocks/template
+++ b/srcpkgs/i3blocks/template
@@ -7,10 +7,10 @@ make_build_args="SYSCONFDIR=/etc"
hostmakedepends="autoconf automake pkg-config"
makedepends="bash-completion"
short_desc="Flexible scheduler for i3bar"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <alcm99@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/vivien/i3blocks"
-distfiles="${homepage}/archive/${version}.tar.gz"
+distfiles="https://github.com/vivien/i3blocks/archive/${version}.tar.gz"
checksum=41764d771043d0c06c23d75b1e3ca6b2b94279191483d03f10c5e034d6722ebf
pre_configure() {
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (6 preceding siblings ...)
2023-03-05 19:08 ` [PR PATCH] [Updated] " carvalhudo
@ 2023-03-05 19:09 ` carvalhudo
2023-03-11 7:30 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: carvalhudo @ 2023-03-05 19:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by carvalhudo on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1125717783
Comment:
Thanks for the explanation. Suggestion implemented.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Merged]: i3blocks: adopt
2023-02-25 4:55 [PR PATCH] i3blocks: adopt carvalhudo
` (7 preceding siblings ...)
2023-03-05 19:09 ` [PR REVIEW] " carvalhudo
@ 2023-03-11 7:30 ` classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-03-11 7:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
There's a merged pull request on the void-packages repository
i3blocks: adopt
https://github.com/void-linux/void-packages/pull/42439
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 10+ messages in thread