Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] riff: update to 2.23.1.
@ 2023-03-19 19:14 icp1994
  2023-03-19 19:26 ` 0x5c
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: icp1994 @ 2023-03-19 19:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages riff
https://github.com/void-linux/void-packages/pull/42868

riff: update to 2.23.1.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/42868.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-riff-42868.patch --]
[-- Type: text/x-diff, Size: 990 bytes --]

From 0863de34576dca909e11188e63c43d63fefc1abd Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 19 Mar 2023 12:33:53 +0530
Subject: [PATCH] riff: update to 2.23.1.

---
 srcpkgs/riff/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/riff/template b/srcpkgs/riff/template
index 624a61013c75..854021c06ab3 100644
--- a/srcpkgs/riff/template
+++ b/srcpkgs/riff/template
@@ -1,6 +1,6 @@
 # Template file for 'riff'
 pkgname=riff
-version=2.22.2
+version=2.23.1
 revision=1
 build_style=cargo
 short_desc="Diff filter highlighting which line parts have changed"
@@ -8,7 +8,7 @@ maintainer="0x5c <dev@0x5c.io>"
 license="MIT"
 homepage="https://github.com/walles/riff"
 distfiles="https://github.com/walles/riff/archive/refs/tags/${version}.tar.gz"
-checksum=7624e73d968d41133edc095b78ba49a19084933ff46f375864fed89fcf7c3e86
+checksum=703684f3dcdb0f600def0e3708b08901c90162d66af03c0217648409c802beb6
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: riff: update to 2.23.1.
  2023-03-19 19:14 [PR PATCH] riff: update to 2.23.1 icp1994
@ 2023-03-19 19:26 ` 0x5c
  2023-03-19 19:35 ` icp1994
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: 0x5c @ 2023-03-19 19:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/42868#issuecomment-1475373563

Comment:
I haven't updated riff yet because there's been successive releases, including this one, that weren't actually ready and needed further patch versions. I want to test packages I maintain instead of just simply bumping versions.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: riff: update to 2.23.1.
  2023-03-19 19:14 [PR PATCH] riff: update to 2.23.1 icp1994
  2023-03-19 19:26 ` 0x5c
@ 2023-03-19 19:35 ` icp1994
  2023-03-19 21:20 ` 0x5c
  2023-03-22  4:08 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: icp1994 @ 2023-03-19 19:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42868#issuecomment-1475375809

Comment:
Huh, that's weird. I actually use riff for the void-packages git checkout and have been building locally since the last couple of minor versions. But I guess hadn't hit the newline related issues for the diffs here.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: riff: update to 2.23.1.
  2023-03-19 19:14 [PR PATCH] riff: update to 2.23.1 icp1994
  2023-03-19 19:26 ` 0x5c
  2023-03-19 19:35 ` icp1994
@ 2023-03-19 21:20 ` 0x5c
  2023-03-22  4:08 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: 0x5c @ 2023-03-19 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/42868#issuecomment-1475403065

Comment:
Void-packages is not a good test case for these bugs. Git diff seems to always use the exact string `\ No newline at end of file` regardless of the locale (unlike `diff -u`), hiding the first bug. Then since the repo doesn't contain many files that lack a newline at the end, it's easy to miss the second bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: riff: update to 2.23.1.
  2023-03-19 19:14 [PR PATCH] riff: update to 2.23.1 icp1994
                   ` (2 preceding siblings ...)
  2023-03-19 21:20 ` 0x5c
@ 2023-03-22  4:08 ` classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2023-03-22  4:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There's a closed pull request on the void-packages repository

riff: update to 2.23.1.
https://github.com/void-linux/void-packages/pull/42868

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-22  4:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 19:14 [PR PATCH] riff: update to 2.23.1 icp1994
2023-03-19 19:26 ` 0x5c
2023-03-19 19:35 ` icp1994
2023-03-19 21:20 ` 0x5c
2023-03-22  4:08 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).