[PR PATCH] New package: i2pd-devel-2.46.0

[PR PATCH] New package: i2pd-devel-2.46.0

[kevcrumb]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

There is a new pull request by kevcrumb against master on the void-packages repository

https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915

New package: i2pd-devel-2.46.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - aarch64-musl
  - aarch64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1525 bytes --]

From b74beb7bb8ac3fe0ef9f8cf864dec251e6135acd Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] New package: i2pd-devel-2.46.0

---
 srcpkgs/i2pd-devel    |  1 +
 srcpkgs/i2pd/template | 19 ++++++++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/i2pd-devel

diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..4bc4d9cbfa41 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -27,6 +27,13 @@ case "${XBPS_TARGET_MACHINE}" in
 esac
 
 do_install() {
+	# Static library and headers for the -devel package
+	vinstall libi2pd.a 644 usr/lib
+	for f in libi2pd/*.h ; do
+		vinstall $f 644 usr/include
+	done
+
+	# Configuration for the main package
 	vbin i2pd
 	vman debian/i2pd.1
 	vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +44,15 @@ do_install() {
 	vmkdir usr/share/i2pd
 	vcopy contrib/certificates usr/share/i2pd
 	vmkdir var/lib/i2pd
-	ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+	ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+
+i2pd-devel_package() {
+	depends="i2pd>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove "usr/lib/*.a"
+		vmove "usr/include/*.h"
+	}
 }

Re: [PR REVIEW] New package: i2pd-devel-2.46.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#discussion_r1144210109

Comment:
```suggestion
	vcopy "libi2pd/*.h" usr/include
```

may require `vmkdir usr/include` too

Re: [PR REVIEW] New package: i2pd-devel-2.46.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#discussion_r1144211158

Comment:
what about the shared library? you should be able to build that with an additional build target (`make_build_target="all api"` i think should work) 

Re: New package: i2pd-devel-2.46.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#issuecomment-1479032924

Comment:
this is not really adding a package, so the commit should say something like "i2pd: add -devel subpackage"

Re: [PR REVIEW] New package: i2pd-devel-2.46.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#discussion_r1144423952

Comment:
```suggestion
```

Re: [PR PATCH] [Updated] New package: i2pd-devel-2.46.0

[kevcrumb]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

There is an updated pull request by kevcrumb against master on the void-packages repository

https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915

New package: i2pd-devel-2.46.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - aarch64-musl
  - aarch64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1798 bytes --]

From b95207c04858f9a327a5f3bcf5d7161489a9bc88 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage

---
 srcpkgs/i2pd-devel    |  1 +
 srcpkgs/i2pd/template | 20 +++++++++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/i2pd-devel

diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..d74853fa4f41 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -3,6 +3,7 @@ pkgname=i2pd
 version=2.46.0
 revision=1
 build_style=gnu-makefile
+make_build_target="all api"
 make_build_args="USE_UPNP=yes"
 makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
  libatomic-devel"
@@ -27,6 +28,13 @@ case "${XBPS_TARGET_MACHINE}" in
 esac
 
 do_install() {
+	# Static library and headers for the -devel package
+	vinstall libi2pd.a 644 usr/lib
+	vinstall libi2pd.so 755 usr/lib
+	vmkdir usr/include
+	vcopy "libi2pd/*.h" usr/include
+
+	# Configuration for the main package
 	vbin i2pd
 	vman debian/i2pd.1
 	vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +45,15 @@ do_install() {
 	vmkdir usr/share/i2pd
 	vcopy contrib/certificates usr/share/i2pd
 	vmkdir var/lib/i2pd
-	ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+	ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+	depends="i2pd>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove "usr/include/*.h"
+	}
 }

Re: [PR REVIEW] i2pd: add -devel subpackage

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#discussion_r1145333492

Comment:
ok, after looking at the makefile more, it seems they don't version the shared library, so there's not much point in using it, I think.

Re: [PR PATCH] [Updated] i2pd: add -devel subpackage

[kevcrumb]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

There is an updated pull request by kevcrumb against master on the void-packages repository

https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915

i2pd: add -devel subpackage
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - aarch64-musl
  - aarch64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1838 bytes --]

From a88c5df1230356e4503a8496eb46bff735871ff9 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage

---
 srcpkgs/i2pd-devel    |  1 +
 srcpkgs/i2pd/template | 20 +++++++++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/i2pd-devel

diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..56e70720f961 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -3,6 +3,7 @@ pkgname=i2pd
 version=2.46.0
 revision=1
 build_style=gnu-makefile
+make_build_target="all api"
 make_build_args="USE_UPNP=yes"
 makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
  libatomic-devel"
@@ -27,6 +28,14 @@ case "${XBPS_TARGET_MACHINE}" in
 esac
 
 do_install() {
+	# Static library and headers for the -devel package
+	vinstall libi2pd.a 644 usr/lib
+        # Skipping until upstream versions the shared library
+	#vinstall libi2pd.so 755 usr/lib
+	vmkdir usr/include
+	vcopy "libi2pd/*.h" usr/include
+
+	# Configuration for the main package
 	vbin i2pd
 	vman debian/i2pd.1
 	vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +46,14 @@ do_install() {
 	vmkdir usr/share/i2pd
 	vcopy contrib/certificates usr/share/i2pd
 	vmkdir var/lib/i2pd
-	ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+	ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+	depends="i2pd>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove "usr/lib/*.a"
+		vmove "usr/include/*.h"
+	}
 }

Re: [PR PATCH] [Updated] i2pd: add -devel subpackage

[kevcrumb]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

There is an updated pull request by kevcrumb against master on the void-packages repository

https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915

i2pd: add -devel subpackage
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - aarch64-musl
  - aarch64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]

From fba0ea304081b499289565f3058a007d5e7d0679 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage

---
 srcpkgs/i2pd-devel    |  1 +
 srcpkgs/i2pd/template | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/i2pd-devel

diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..209f52225e96 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -27,6 +27,12 @@ case "${XBPS_TARGET_MACHINE}" in
 esac
 
 do_install() {
+	# Static library and headers for the -devel package
+	vinstall libi2pd.a 644 usr/lib
+	vmkdir usr/include
+	vcopy "libi2pd/*.h" usr/include
+
+	# Configuration for the main package
 	vbin i2pd
 	vman debian/i2pd.1
 	vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +43,14 @@ do_install() {
 	vmkdir usr/share/i2pd
 	vcopy contrib/certificates usr/share/i2pd
 	vmkdir var/lib/i2pd
-	ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+	ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+	depends="i2pd>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove "usr/lib/*.a"
+		vmove "usr/include/*.h"
+	}
 }

Re: i2pd: add -devel subpackage

[kevcrumb]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by kevcrumb on void-packages repository

https://github.com/void-linux/void-packages/pull/42915#issuecomment-1505960684

Comment:
bumping just in case this got out of sight

Re: [PR PATCH] [Merged]: i2pd: add -devel subpackage

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There's a merged pull request on the void-packages repository

i2pd: add -devel subpackage
https://github.com/void-linux/void-packages/pull/42915

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-glibc
  - aarch64-musl
  - aarch64-glibc