* Re: [PR REVIEW] New package: i2pd-devel-2.46.0
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
@ 2023-03-22 4:15 ` classabbyamp
2023-03-22 4:15 ` classabbyamp
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2023-03-22 4:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#discussion_r1144210109
Comment:
```suggestion
vcopy "libi2pd/*.h" usr/include
```
may require `vmkdir usr/include` too
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: i2pd-devel-2.46.0
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
2023-03-22 4:15 ` [PR REVIEW] " classabbyamp
@ 2023-03-22 4:15 ` classabbyamp
2023-03-22 7:25 ` paper42
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2023-03-22 4:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#discussion_r1144211158
Comment:
what about the shared library? you should be able to build that with an additional build target (`make_build_target="all api"` i think should work)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: New package: i2pd-devel-2.46.0
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
2023-03-22 4:15 ` [PR REVIEW] " classabbyamp
2023-03-22 4:15 ` classabbyamp
@ 2023-03-22 7:25 ` paper42
2023-03-22 8:55 ` [PR REVIEW] " classabbyamp
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2023-03-22 7:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#issuecomment-1479032924
Comment:
this is not really adding a package, so the commit should say something like "i2pd: add -devel subpackage"
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: i2pd-devel-2.46.0
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (2 preceding siblings ...)
2023-03-22 7:25 ` paper42
@ 2023-03-22 8:55 ` classabbyamp
2023-03-22 16:21 ` [PR PATCH] [Updated] " kevcrumb
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2023-03-22 8:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#discussion_r1144423952
Comment:
```suggestion
```
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: i2pd-devel-2.46.0
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (3 preceding siblings ...)
2023-03-22 8:55 ` [PR REVIEW] " classabbyamp
@ 2023-03-22 16:21 ` kevcrumb
2023-03-22 19:50 ` [PR REVIEW] i2pd: add -devel subpackage classabbyamp
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: kevcrumb @ 2023-03-22 16:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
There is an updated pull request by kevcrumb against master on the void-packages repository
https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915
New package: i2pd-devel-2.46.0
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-glibc
- aarch64-musl
- aarch64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1798 bytes --]
From b95207c04858f9a327a5f3bcf5d7161489a9bc88 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage
---
srcpkgs/i2pd-devel | 1 +
srcpkgs/i2pd/template | 20 +++++++++++++++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/i2pd-devel
diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..d74853fa4f41 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -3,6 +3,7 @@ pkgname=i2pd
version=2.46.0
revision=1
build_style=gnu-makefile
+make_build_target="all api"
make_build_args="USE_UPNP=yes"
makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
libatomic-devel"
@@ -27,6 +28,13 @@ case "${XBPS_TARGET_MACHINE}" in
esac
do_install() {
+ # Static library and headers for the -devel package
+ vinstall libi2pd.a 644 usr/lib
+ vinstall libi2pd.so 755 usr/lib
+ vmkdir usr/include
+ vcopy "libi2pd/*.h" usr/include
+
+ # Configuration for the main package
vbin i2pd
vman debian/i2pd.1
vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +45,15 @@ do_install() {
vmkdir usr/share/i2pd
vcopy contrib/certificates usr/share/i2pd
vmkdir var/lib/i2pd
- ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+ ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+ depends="i2pd>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ vmove "usr/include/*.h"
+ }
}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] i2pd: add -devel subpackage
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (4 preceding siblings ...)
2023-03-22 16:21 ` [PR PATCH] [Updated] " kevcrumb
@ 2023-03-22 19:50 ` classabbyamp
2023-03-23 14:20 ` [PR PATCH] [Updated] " kevcrumb
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2023-03-22 19:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#discussion_r1145333492
Comment:
ok, after looking at the makefile more, it seems they don't version the shared library, so there's not much point in using it, I think.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] i2pd: add -devel subpackage
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (5 preceding siblings ...)
2023-03-22 19:50 ` [PR REVIEW] i2pd: add -devel subpackage classabbyamp
@ 2023-03-23 14:20 ` kevcrumb
2023-03-23 14:23 ` kevcrumb
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: kevcrumb @ 2023-03-23 14:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
There is an updated pull request by kevcrumb against master on the void-packages repository
https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915
i2pd: add -devel subpackage
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-glibc
- aarch64-musl
- aarch64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1838 bytes --]
From a88c5df1230356e4503a8496eb46bff735871ff9 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage
---
srcpkgs/i2pd-devel | 1 +
srcpkgs/i2pd/template | 20 +++++++++++++++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/i2pd-devel
diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..56e70720f961 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -3,6 +3,7 @@ pkgname=i2pd
version=2.46.0
revision=1
build_style=gnu-makefile
+make_build_target="all api"
make_build_args="USE_UPNP=yes"
makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
libatomic-devel"
@@ -27,6 +28,14 @@ case "${XBPS_TARGET_MACHINE}" in
esac
do_install() {
+ # Static library and headers for the -devel package
+ vinstall libi2pd.a 644 usr/lib
+ # Skipping until upstream versions the shared library
+ #vinstall libi2pd.so 755 usr/lib
+ vmkdir usr/include
+ vcopy "libi2pd/*.h" usr/include
+
+ # Configuration for the main package
vbin i2pd
vman debian/i2pd.1
vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +46,14 @@ do_install() {
vmkdir usr/share/i2pd
vcopy contrib/certificates usr/share/i2pd
vmkdir var/lib/i2pd
- ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+ ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+ depends="i2pd>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove "usr/lib/*.a"
+ vmove "usr/include/*.h"
+ }
}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] i2pd: add -devel subpackage
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (6 preceding siblings ...)
2023-03-23 14:20 ` [PR PATCH] [Updated] " kevcrumb
@ 2023-03-23 14:23 ` kevcrumb
2023-04-12 21:16 ` kevcrumb
2023-04-12 23:45 ` [PR PATCH] [Merged]: " classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: kevcrumb @ 2023-03-23 14:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
There is an updated pull request by kevcrumb against master on the void-packages repository
https://github.com/kevcrumb/void-packages i2pd-devel
https://github.com/void-linux/void-packages/pull/42915
i2pd: add -devel subpackage
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-glibc
- aarch64-musl
- aarch64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/42915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-devel-42915.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]
From fba0ea304081b499289565f3058a007d5e7d0679 Mon Sep 17 00:00:00 2001
From: Kevin Crumb <kevcrumb@splitlinux.org>
Date: Wed, 22 Mar 2023 01:10:52 +0000
Subject: [PATCH] i2pd: add -devel subpackage
---
srcpkgs/i2pd-devel | 1 +
srcpkgs/i2pd/template | 17 ++++++++++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/i2pd-devel
diff --git a/srcpkgs/i2pd-devel b/srcpkgs/i2pd-devel
new file mode 120000
index 000000000000..6a68f8b39558
--- /dev/null
+++ b/srcpkgs/i2pd-devel
@@ -0,0 +1 @@
+i2pd
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..209f52225e96 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -27,6 +27,12 @@ case "${XBPS_TARGET_MACHINE}" in
esac
do_install() {
+ # Static library and headers for the -devel package
+ vinstall libi2pd.a 644 usr/lib
+ vmkdir usr/include
+ vcopy "libi2pd/*.h" usr/include
+
+ # Configuration for the main package
vbin i2pd
vman debian/i2pd.1
vinstall contrib/i2pd.conf 644 etc/i2pd
@@ -37,5 +43,14 @@ do_install() {
vmkdir usr/share/i2pd
vcopy contrib/certificates usr/share/i2pd
vmkdir var/lib/i2pd
- ln -s /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+ ln -sf /usr/share/i2pd/certificates ${DESTDIR}/var/lib/i2pd/certificates
+}
+
+i2pd-devel_package() {
+ depends="i2pd>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove "usr/lib/*.a"
+ vmove "usr/include/*.h"
+ }
}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: i2pd: add -devel subpackage
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (7 preceding siblings ...)
2023-03-23 14:23 ` kevcrumb
@ 2023-04-12 21:16 ` kevcrumb
2023-04-12 23:45 ` [PR PATCH] [Merged]: " classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: kevcrumb @ 2023-04-12 21:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
New comment by kevcrumb on void-packages repository
https://github.com/void-linux/void-packages/pull/42915#issuecomment-1505960684
Comment:
bumping just in case this got out of sight
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Merged]: i2pd: add -devel subpackage
2023-03-22 2:35 [PR PATCH] New package: i2pd-devel-2.46.0 kevcrumb
` (8 preceding siblings ...)
2023-04-12 21:16 ` kevcrumb
@ 2023-04-12 23:45 ` classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2023-04-12 23:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
There's a merged pull request on the void-packages repository
i2pd: add -devel subpackage
https://github.com/void-linux/void-packages/pull/42915
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-glibc
- aarch64-musl
- aarch64-glibc
^ permalink raw reply [flat|nested] 11+ messages in thread