Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rpm: Remove obsolete dependency on error.h
@ 2023-03-23  2:14 ismaell
  2023-03-23  2:18 ` sgn
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ismaell @ 2023-03-23  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

There is a new pull request by ismaell against master on the void-packages repository

https://github.com/ismaell/void-packages rpm-no-error.h
https://github.com/void-linux/void-packages/pull/42940

rpm: Remove obsolete dependency on error.h
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-musl`)


A patch file from https://github.com/void-linux/void-packages/pull/42940.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpm-no-error.h-42940.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 0548742ea18f9ec29823b7de39ab43b6a73d0277 Mon Sep 17 00:00:00 2001
From: Ismael Luceno <ismael@iodev.co.uk>
Date: Thu, 23 Mar 2023 03:05:08 +0100
Subject: [PATCH] rpm: doesn't depends on error.h anymore

Closes: https://github.com/void-linux/void-packages/issues/36668
---
 srcpkgs/rpm/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rpm/template b/srcpkgs/rpm/template
index 3f2b3915daa0..02b06b60b86a 100644
--- a/srcpkgs/rpm/template
+++ b/srcpkgs/rpm/template
@@ -1,7 +1,7 @@
 # Template file for 'rpm'
 pkgname=rpm
 version=4.17.1
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-cap --with-acl
  --enable-python PYTHON=python3 --sharedstatedir=/var/lib"
@@ -22,9 +22,8 @@ CFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
 
 case "$XBPS_TARGET_MACHINE" in
 	# rpm uses _nl_msg_cat_cntr, so it needs the glibc gettext impl
-	# it uses <error.h> header, provided by legacy-compat
 	*-musl)
-	makedepends+=" gettext-devel musl-legacy-compat"
+	makedepends+=" gettext-devel"
 	CFLAGS+=" -I${XBPS_CROSS_BASE}/usr/include/gettext"
 	LDFLAGS="-lintl"
 	;;

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: rpm: Remove obsolete dependency on error.h
  2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
@ 2023-03-23  2:18 ` sgn
  2023-03-23 20:57 ` [PR PATCH] [Updated] " ismaell
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2023-03-23  2:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/42940#issuecomment-1480487850

Comment:
```
tools/elfdeps.c:8:10: fatal error: error.h: No such file or directory
    8 | #include <error.h>
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] rpm: Remove obsolete dependency on error.h
  2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
  2023-03-23  2:18 ` sgn
@ 2023-03-23 20:57 ` ismaell
  2023-03-23 21:01 ` ismaell
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ismaell @ 2023-03-23 20:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

There is an updated pull request by ismaell against master on the void-packages repository

https://github.com/ismaell/void-packages rpm-no-error.h
https://github.com/void-linux/void-packages/pull/42940

rpm: Remove obsolete dependency on error.h
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-musl`)


A patch file from https://github.com/void-linux/void-packages/pull/42940.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpm-no-error.h-42940.patch --]
[-- Type: text/x-diff, Size: 2280 bytes --]

From 1dbc58e3c533168aec40229b853dc69160be4db6 Mon Sep 17 00:00:00 2001
From: Ismael Luceno <ismael@iodev.co.uk>
Date: Thu, 13 Oct 2022 19:28:56 +0200
Subject: [PATCH 1/2] rpm: update to 4.18.0.

---
 srcpkgs/rpm/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rpm/template b/srcpkgs/rpm/template
index 3f2b3915daa0..05c887574e3a 100644
--- a/srcpkgs/rpm/template
+++ b/srcpkgs/rpm/template
@@ -1,7 +1,7 @@
 # Template file for 'rpm'
 pkgname=rpm
-version=4.17.1
-revision=3
+version=4.18.0
+revision=1
 build_style=gnu-configure
 configure_args="--with-cap --with-acl
  --enable-python PYTHON=python3 --sharedstatedir=/var/lib"
@@ -15,7 +15,7 @@ license="GPL-2.0-or-later"
 homepage="https://rpm.org"
 changelog="https://rpm.org/wiki/Releases/${version}.html"
 distfiles="https://ftp.osuosl.org/pub/rpm/releases/rpm-${version%.*}.x/rpm-${version}.tar.bz2"
-checksum=0c11b793466e7258851ff82bd65c8ffd8c2dbbc70acc869a5d34150549926e5d
+checksum=2a17152d7187ab30edf2c2fb586463bdf6388de7b5837480955659e5e9054554
 python_version=3
 
 CFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"

From c909e34cd171e6646207bf528d562aa28b3f0495 Mon Sep 17 00:00:00 2001
From: Ismael Luceno <ismael@iodev.co.uk>
Date: Thu, 23 Mar 2023 03:05:08 +0100
Subject: [PATCH 2/2] rpm: remove dependency on musl-legacy-compat

rpm doesn't depends on error.h anymore.

Closes: https://github.com/void-linux/void-packages/issues/36668
---
 srcpkgs/rpm/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rpm/template b/srcpkgs/rpm/template
index 05c887574e3a..4f8bf628cea6 100644
--- a/srcpkgs/rpm/template
+++ b/srcpkgs/rpm/template
@@ -1,7 +1,7 @@
 # Template file for 'rpm'
 pkgname=rpm
 version=4.18.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-cap --with-acl
  --enable-python PYTHON=python3 --sharedstatedir=/var/lib"
@@ -22,9 +22,8 @@ CFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
 
 case "$XBPS_TARGET_MACHINE" in
 	# rpm uses _nl_msg_cat_cntr, so it needs the glibc gettext impl
-	# it uses <error.h> header, provided by legacy-compat
 	*-musl)
-	makedepends+=" gettext-devel musl-legacy-compat"
+	makedepends+=" gettext-devel"
 	CFLAGS+=" -I${XBPS_CROSS_BASE}/usr/include/gettext"
 	LDFLAGS="-lintl"
 	;;

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: rpm: Remove obsolete dependency on error.h
  2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
  2023-03-23  2:18 ` sgn
  2023-03-23 20:57 ` [PR PATCH] [Updated] " ismaell
@ 2023-03-23 21:01 ` ismaell
  2023-03-23 21:02 ` ismaell
  2023-03-23 21:03 ` [PR PATCH] [Closed]: " ismaell
  4 siblings, 0 replies; 6+ messages in thread
From: ismaell @ 2023-03-23 21:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by ismaell on void-packages repository

https://github.com/void-linux/void-packages/pull/42940#issuecomment-1481903483

Comment:
> ```
> tools/elfdeps.c:8:10: fatal error: error.h: No such file or directory
>     8 | #include <error.h>
> ```

Sorry, yes, I forgot the update somehow.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: rpm: Remove obsolete dependency on error.h
  2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
                   ` (2 preceding siblings ...)
  2023-03-23 21:01 ` ismaell
@ 2023-03-23 21:02 ` ismaell
  2023-03-23 21:03 ` [PR PATCH] [Closed]: " ismaell
  4 siblings, 0 replies; 6+ messages in thread
From: ismaell @ 2023-03-23 21:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by ismaell on void-packages repository

https://github.com/void-linux/void-packages/pull/42940#issuecomment-1481904444

Comment:
OK, I see I need to do it separately :/.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: rpm: Remove obsolete dependency on error.h
  2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
                   ` (3 preceding siblings ...)
  2023-03-23 21:02 ` ismaell
@ 2023-03-23 21:03 ` ismaell
  4 siblings, 0 replies; 6+ messages in thread
From: ismaell @ 2023-03-23 21:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

There's a closed pull request on the void-packages repository

rpm: Remove obsolete dependency on error.h
https://github.com/void-linux/void-packages/pull/42940

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-musl`)


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-03-23 21:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23  2:14 [PR PATCH] rpm: Remove obsolete dependency on error.h ismaell
2023-03-23  2:18 ` sgn
2023-03-23 20:57 ` [PR PATCH] [Updated] " ismaell
2023-03-23 21:01 ` ismaell
2023-03-23 21:02 ` ismaell
2023-03-23 21:03 ` [PR PATCH] [Closed]: " ismaell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).