[PR PATCH] citations: fix build

[PR PATCH] citations: fix build

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages citations-fix-build
https://github.com/void-linux/void-packages/pull/43119

citations: fix build
#### Testing the changes
- I tested the changes in this PR: **briefly**

Citations 0.5.1 has a specific commit hash for nom-bibtex in it's Cargo.lock, but nom-bibtex doesn't have that commit in it's master which causes cargo to fail. I solved it by updating the commit to an equivalent commit which is in master, but it has a different hash probably because it's based on nom-bibtex 0.4.0 instead of 0.3.0.

cc @A6GibKm I am not sure if you are aware of this

```
[24/27] Generating src/cargo-build with a custom command
    Updating crates.io index
    Updating git repository `https://github.com/A6GibKm/nom-bibtex.git`
error: failed to get `nom-bibtex` as a dependency of package `cratebibtex v0.1.0 (/builddir/citations-0.5.1/cratebibtex)`
    ... which satisfies path dependency `cratebibtex` (locked to 0.1.0) of package `citations v0.5.1 (/builddir/citations-0.5.1)`

Caused by:
  failed to load source for dependency `nom-bibtex`

Caused by:
  Unable to update https://github.com/A6GibKm/nom-bibtex.git#3e20b1f6

Caused by:
  object not found - no match for id (3e20b1f6a1f8709bf61836f171b8d90cb84cd8b3); class=Odb (9); code=NotFound (-3)
[26/27] Generating data/org.gnome.World.Citations.metainfo.xml with a custom command
FAILED: src/citations 
/usr/bin/env CARGO_HOME=/builddir/citations-0.5.1/build/cargo-home /usr/bin/cargo build --manifest-path /builddir/citations-0.5.1/Cargo.toml --target-dir /builddir/citations-0.5.1/build/src --release && cp src/release/citations src/citations
ninja: build stopped: subcommand failed.
```

A patch file from https://github.com/void-linux/void-packages/pull/43119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-citations-fix-build-43119.patch --]
[-- Type: text/x-diff, Size: 842 bytes --]

From baff07a73e611ff4e6713ad65f43ea5d515a07d3 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Thu, 30 Mar 2023 20:20:23 +0200
Subject: [PATCH] citations: fix build

---
 srcpkgs/citations/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/citations/template b/srcpkgs/citations/template
index 5dbdc7c9fa62..bb82deae2c81 100644
--- a/srcpkgs/citations/template
+++ b/srcpkgs/citations/template
@@ -20,6 +20,8 @@ pre_build() {
 	if [ "${CROSS_BUILD}" ]; then
 		vsed -i build/build.ninja -e 's, && cp src/release/citations src/citations,,'
 	fi
+	# nom-bibtex was probably force pushed, the old git hash doesn't exist anymore
+	cargo update --package nom-bibtex --precise da0eda527c58e281acf41336512cc8627370cff9
 }
 
 # Take the cross-build folder into account when copying the file for the install

Re: citations: fix build

[abenson]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1490788002

Comment:
@misuchiru03 ^^

Re: citations: fix build

[A6GibKm]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by A6GibKm on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1490804157

Comment:
Hello, the problem is that I force pushed to my fork of nom-bibtex, there will be a release on the 3rd that does not use the fork at all.

Re: citations: fix build

[paper42]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1490897348

Comment:
> Hello, the problem is that I force pushed to my fork of nom-bibtex, there will be a release on the 3rd that does not use the fork at all.

Thanks, do you know if it's safe for us to use this new commit that's based on nom-bibtex 0.4.0 for now?

Re: citations: fix build

[A6GibKm]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by A6GibKm on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1490952087

Comment:
its not. The fork was fundamentally different.

Re: citations: fix build

[paper42]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1490985768

Comment:
ok, thanks

Re: [PR PATCH] [Closed]: citations: fix build

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1721 bytes --]

There's a closed pull request on the void-packages repository

citations: fix build
https://github.com/void-linux/void-packages/pull/43119

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

Citations 0.5.1 has a specific commit hash for nom-bibtex in it's Cargo.lock, but nom-bibtex doesn't have that commit in it's master which causes cargo to fail. I solved it by updating the commit to an equivalent commit which is in master, but it has a different hash probably because it's based on nom-bibtex 0.4.0 instead of 0.3.0.

cc @A6GibKm I am not sure if you are aware of this

```
[24/27] Generating src/cargo-build with a custom command
    Updating crates.io index
    Updating git repository `https://github.com/A6GibKm/nom-bibtex.git`
error: failed to get `nom-bibtex` as a dependency of package `cratebibtex v0.1.0 (/builddir/citations-0.5.1/cratebibtex)`
    ... which satisfies path dependency `cratebibtex` (locked to 0.1.0) of package `citations v0.5.1 (/builddir/citations-0.5.1)`

Caused by:
  failed to load source for dependency `nom-bibtex`

Caused by:
  Unable to update https://github.com/A6GibKm/nom-bibtex.git#3e20b1f6

Caused by:
  object not found - no match for id (3e20b1f6a1f8709bf61836f171b8d90cb84cd8b3); class=Odb (9); code=NotFound (-3)
[26/27] Generating data/org.gnome.World.Citations.metainfo.xml with a custom command
FAILED: src/citations 
/usr/bin/env CARGO_HOME=/builddir/citations-0.5.1/build/cargo-home /usr/bin/cargo build --manifest-path /builddir/citations-0.5.1/Cargo.toml --target-dir /builddir/citations-0.5.1/build/src --release && cp src/release/citations src/citations
ninja: build stopped: subcommand failed.
```

Re: citations: fix build

[A6GibKm]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by A6GibKm on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1495870571

Comment:
Yesterday I released a new version, it uses the latest commit in the nom-bibtex repo, but it will work just fine with the latest stable release (4.0 I think), the reason is that without https://github.com/charlesvdv/nom-bibtex/commit/23c1999d0d6781e2939ce311abd030517a7d1a16 the crate would pull in a bunch of outdated crates.

Re: citations: fix build

[A6GibKm]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New comment by A6GibKm on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1495870571

Comment:
Yesterday I released a new version, it uses the latest commit in the nom-bibtex repo, but it will work just fine with the latest stable release (4.0), the reason is that without https://github.com/charlesvdv/nom-bibtex/commit/23c1999d0d6781e2939ce311abd030517a7d1a16 the crate would pull in a bunch of outdated crates.

Re: citations: fix build

[A6GibKm]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

New comment by A6GibKm on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1495870571

Comment:
Yesterday I released a new version, it uses the latest commit in the nom-bibtex repo, but it will work just fine with the latest stable release (0.4.0), the reason is that without https://github.com/charlesvdv/nom-bibtex/commit/23c1999d0d6781e2939ce311abd030517a7d1a16 the crate would pull in a bunch of outdated crates.

Re: citations: fix build

[paper42]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43119#issuecomment-1496362403

Comment:
thanks for the comment, I updated citations to 0.5.2 in https://github.com/void-linux/void-packages/pull/43262