Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: wraith-master-1.2.1
@ 2023-04-07 10:29 adigitoleo
  2023-04-07 11:29 ` [PR PATCH] [Updated] " adigitoleo
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-07 10:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

There is a new pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages wraith-master
https://github.com/void-linux/void-packages/pull/43317

New package: wraith-master-1.2.1
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/43317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wraith-master-43317.patch --]
[-- Type: text/x-diff, Size: 3258 bytes --]

From 60335babc72729dee11d67e6d232275627acfea0 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Fri, 7 Apr 2023 17:35:06 +1000
Subject: [PATCH] New package: wraith-master-1.2.1

Package for RGB control of AMD Wraith Master cooling fans.
As far as I am aware, the gradle build system is not capable of
producing PIE executables, hence the use of `nopie_files`.
The GTK3 and cli frontends can be built separately, as per upstream
build options (and the AUR PKGBUILD).
---
 srcpkgs/wraith-master-cli      |  1 +
 srcpkgs/wraith-master-gtk      |  1 +
 srcpkgs/wraith-master/template | 60 ++++++++++++++++++++++++++++++++++
 3 files changed, 62 insertions(+)
 create mode 120000 srcpkgs/wraith-master-cli
 create mode 120000 srcpkgs/wraith-master-gtk
 create mode 100644 srcpkgs/wraith-master/template

diff --git a/srcpkgs/wraith-master-cli b/srcpkgs/wraith-master-cli
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-cli
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master-gtk b/srcpkgs/wraith-master-gtk
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-gtk
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master/template b/srcpkgs/wraith-master/template
new file mode 100644
index 000000000000..f3e419c00811
--- /dev/null
+++ b/srcpkgs/wraith-master/template
@@ -0,0 +1,60 @@
+# Template file for 'wraith-master'
+
+pkgname=wraith-master
+version=1.2.1
+revision=1
+
+build_style=gnu-makefile
+# Don't build experimental ELF frontend yet, https://gitlab.com/serebit/wraith-master/-/issues/26.
+make_build_target="common cli gtk"
+# Don't download gradle.
+make_build_args="GRADLE=gradle"
+# Gradle can't build PIE executables?
+nopie_files="/usr/bin/wraith-master /usr/bin/wraith-master-gtk"
+
+hostmakedepends="scdoc gradle tar"
+makedepends="libusb-devel gtk+3-devel"
+short_desc="Wraith Prism RGB control application built with GTK+ and Kotlin/Native"
+maintainer="adigitoleo <adigitoleo@dissimulo.com>"
+license="Apache-2.0"
+homepage="https://gitlab.com/serebit/wraith-master"
+changelog="https://gitlab.com/serebit/wraith-master/-/raw/master/CHANGELOG.md"
+distfiles="https://gitlab.com/serebit/wraith-master/-/archive/v$version/$pkgname-v$version.tar.gz"
+checksum=fcf150b5f45e9b9ffad60e1a72f7251d4488fba28d5b325688c931f5098e21ca
+
+pre_build() {
+	export GRADLE_USER_HOME=$PWD/.gradle
+	export KONAN_DATA_DIR=$PWD/.konan
+}
+
+pkg_install() {
+	cd build/PACKAGE
+	vmkdir /etc/udev/rules.d/
+	vcopy udev/* /etc/udev/rules.d/
+}
+
+wraith-master-cli_package() {
+	short_desc+=" - CLI frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master
+		vman man/wraith-master.1
+	}
+}
+
+wraith-master-gtk_package() {
+	short_desc+=" - GTK frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master-gtk
+		vman man/wraith-master-gtk.1
+		vmkdir /usr/share/icons/
+		vcopy icons/* /usr/share/icons/
+		vmkdir /usr/share/metainfo/
+		vcopy metainfo/* /usr/share/metainfo/
+		vmkdir /usr/share/applications/
+		vcopy desktop/* /usr/share/applications/
+	}
+}

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
@ 2023-04-07 11:29 ` adigitoleo
  2023-04-07 11:40 ` adigitoleo
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-07 11:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is an updated pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages wraith-master
https://github.com/void-linux/void-packages/pull/43317

New package: wraith-master-1.2.1
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/43317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wraith-master-43317.patch --]
[-- Type: text/x-diff, Size: 3267 bytes --]

From eeb8a3f7f2361f2cec5c8a5e3cd3a763f3b9b25f Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Fri, 7 Apr 2023 17:35:06 +1000
Subject: [PATCH] New package: wraith-master-1.2.1

Package for RGB control of AMD Wraith Master cooling fans.
As far as I am aware, the gradle build system is not capable of
producing PIE executables, hence the use of `nopie_files`.
The GTK3 and cli frontends can be built separately, as per upstream
build options (and the AUR PKGBUILD).
---
 srcpkgs/wraith-master-cli      |  1 +
 srcpkgs/wraith-master-gtk      |  1 +
 srcpkgs/wraith-master/template | 60 ++++++++++++++++++++++++++++++++++
 3 files changed, 62 insertions(+)
 create mode 120000 srcpkgs/wraith-master-cli
 create mode 120000 srcpkgs/wraith-master-gtk
 create mode 100644 srcpkgs/wraith-master/template

diff --git a/srcpkgs/wraith-master-cli b/srcpkgs/wraith-master-cli
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-cli
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master-gtk b/srcpkgs/wraith-master-gtk
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-gtk
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master/template b/srcpkgs/wraith-master/template
new file mode 100644
index 000000000000..76305f5f8c07
--- /dev/null
+++ b/srcpkgs/wraith-master/template
@@ -0,0 +1,60 @@
+# Template file for 'wraith-master'
+
+pkgname=wraith-master
+version=1.2.1
+revision=1
+
+build_style=gnu-makefile
+# Don't build experimental ELF frontend yet, https://gitlab.com/serebit/wraith-master/-/issues/26.
+make_build_target="common cli gtk"
+# Don't download gradle.
+make_build_args="GRADLE=gradle"
+# Gradle can't build PIE executables?
+nopie_files="/usr/bin/wraith-master /usr/bin/wraith-master-gtk"
+
+hostmakedepends="scdoc openjdk8 gradle tar"
+makedepends="libusb-devel gtk+3-devel"
+short_desc="Wraith Prism RGB control application built with GTK+ and Kotlin/Native"
+maintainer="adigitoleo <adigitoleo@dissimulo.com>"
+license="Apache-2.0"
+homepage="https://gitlab.com/serebit/wraith-master"
+changelog="https://gitlab.com/serebit/wraith-master/-/raw/master/CHANGELOG.md"
+distfiles="https://gitlab.com/serebit/wraith-master/-/archive/v$version/$pkgname-v$version.tar.gz"
+checksum=fcf150b5f45e9b9ffad60e1a72f7251d4488fba28d5b325688c931f5098e21ca
+
+pre_build() {
+	export GRADLE_USER_HOME=$PWD/.gradle
+	export KONAN_DATA_DIR=$PWD/.konan
+}
+
+pkg_install() {
+	cd build/PACKAGE
+	vmkdir /etc/udev/rules.d/
+	vcopy udev/* /etc/udev/rules.d/
+}
+
+wraith-master-cli_package() {
+	short_desc+=" - CLI frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master
+		vman man/wraith-master.1
+	}
+}
+
+wraith-master-gtk_package() {
+	short_desc+=" - GTK frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master-gtk
+		vman man/wraith-master-gtk.1
+		vmkdir /usr/share/icons/
+		vcopy icons/* /usr/share/icons/
+		vmkdir /usr/share/metainfo/
+		vcopy metainfo/* /usr/share/metainfo/
+		vmkdir /usr/share/applications/
+		vcopy desktop/* /usr/share/applications/
+	}
+}

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
  2023-04-07 11:29 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-04-07 11:40 ` adigitoleo
  2023-04-07 11:53 ` adigitoleo
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-07 11:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is an updated pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages wraith-master
https://github.com/void-linux/void-packages/pull/43317

New package: wraith-master-1.2.1
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/43317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wraith-master-43317.patch --]
[-- Type: text/x-diff, Size: 3316 bytes --]

From db87322530bd02b296ac0e3f7e2e4863db0125ab Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Fri, 7 Apr 2023 17:35:06 +1000
Subject: [PATCH] New package: wraith-master-1.2.1

Package for RGB control of AMD Wraith Master cooling fans.
As far as I am aware, the gradle build system is not capable of
producing PIE executables, hence the use of `nopie_files`.
The GTK3 and cli frontends can be built separately, as per upstream
build options (and the AUR PKGBUILD).
---
 srcpkgs/wraith-master-cli      |  1 +
 srcpkgs/wraith-master-gtk      |  1 +
 srcpkgs/wraith-master/template | 61 ++++++++++++++++++++++++++++++++++
 3 files changed, 63 insertions(+)
 create mode 120000 srcpkgs/wraith-master-cli
 create mode 120000 srcpkgs/wraith-master-gtk
 create mode 100644 srcpkgs/wraith-master/template

diff --git a/srcpkgs/wraith-master-cli b/srcpkgs/wraith-master-cli
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-cli
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master-gtk b/srcpkgs/wraith-master-gtk
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-gtk
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master/template b/srcpkgs/wraith-master/template
new file mode 100644
index 000000000000..ee2710b2469c
--- /dev/null
+++ b/srcpkgs/wraith-master/template
@@ -0,0 +1,61 @@
+# Template file for 'wraith-master'
+
+pkgname=wraith-master
+version=1.2.1
+revision=1
+
+build_style=gnu-makefile
+# Don't build experimental ELF frontend yet, https://gitlab.com/serebit/wraith-master/-/issues/26.
+make_build_target="common cli gtk"
+# Don't download gradle.
+make_build_args="GRADLE=gradle"
+# Gradle can't build PIE executables?
+nopie_files="/usr/bin/wraith-master /usr/bin/wraith-master-gtk"
+
+hostmakedepends="scdoc openjdk8 gradle tar"
+makedepends="libusb-devel gtk+3-devel"
+short_desc="Wraith Prism RGB control application built with GTK+ and Kotlin/Native"
+maintainer="adigitoleo <adigitoleo@dissimulo.com>"
+license="Apache-2.0"
+homepage="https://gitlab.com/serebit/wraith-master"
+changelog="https://gitlab.com/serebit/wraith-master/-/raw/master/CHANGELOG.md"
+distfiles="https://gitlab.com/serebit/wraith-master/-/archive/v$version/$pkgname-v$version.tar.gz"
+checksum=fcf150b5f45e9b9ffad60e1a72f7251d4488fba28d5b325688c931f5098e21ca
+
+pre_build() {
+	export GRADLE_USER_HOME=$PWD/.gradle
+	export KONAN_DATA_DIR=$PWD/.konan
+	export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk
+}
+
+pkg_install() {
+	cd build/PACKAGE
+	vmkdir /etc/udev/rules.d/
+	vcopy udev/* /etc/udev/rules.d/
+}
+
+wraith-master-cli_package() {
+	short_desc+=" - CLI frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master
+		vman man/wraith-master.1
+	}
+}
+
+wraith-master-gtk_package() {
+	short_desc+=" - GTK frontend"
+	depends="$sourcepkg>=$version_$revision"
+	pkg_install() {
+		cd build/PACKAGE
+		vbin wraith-master-gtk
+		vman man/wraith-master-gtk.1
+		vmkdir /usr/share/icons/
+		vcopy icons/* /usr/share/icons/
+		vmkdir /usr/share/metainfo/
+		vcopy metainfo/* /usr/share/metainfo/
+		vmkdir /usr/share/applications/
+		vcopy desktop/* /usr/share/applications/
+	}
+}

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
  2023-04-07 11:29 ` [PR PATCH] [Updated] " adigitoleo
  2023-04-07 11:40 ` adigitoleo
@ 2023-04-07 11:53 ` adigitoleo
  2023-04-07 11:56 ` asiekierka
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-07 11:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1500218580

Comment:
CI can't find the java executable. Build log excerpt:

```
> Task :core:cinteropLibusbLinuxX64 FAILED
226

227
FAILURE: Build failed with an exception.
228

229
* What went wrong:
230
Execution failed for task ':core:cinteropLibusbLinuxX64'.
231
> Process 'command '/usr/lib/jvm/java-1.8-openjdk/bin/java'' finished with non-zero exit value 1
```

After trying a few things like adding openjdk8 to dependencies and setting JAVA_HOME, I'm out of ideas at the moment. It seems to build fine locally but I did run into this error a couple of times before I got it to work. I have no experience with gradle, unfortunately. Maybe @asiekierka can help, who maintains the gradle package.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (2 preceding siblings ...)
  2023-04-07 11:53 ` adigitoleo
@ 2023-04-07 11:56 ` asiekierka
  2023-04-07 12:10 ` adigitoleo
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: asiekierka @ 2023-04-07 11:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New comment by asiekierka on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1500220929

Comment:
I'm still listed as a maintainer? I haven't ran Void Linux in years...

In your log, Gradle is running, so the problem is not with the presence of a Java environment. If you get a reproduction going, `gradle --debug --stacktrace` should provide more information.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (3 preceding siblings ...)
  2023-04-07 11:56 ` asiekierka
@ 2023-04-07 12:10 ` adigitoleo
  2023-04-07 13:02 ` [PR REVIEW] " paper42
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-07 12:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1500234968

Comment:
> I'm still listed as a maintainer? I haven't ran Void Linux in years...

Apologies, I just looked at the comment in the gradle template file.

> In your log, Gradle is running, so the problem is not with the presence of a Java environment. If you get a reproduction going, `gradle --debug --stacktrace` should provide more information.

Thanks for the hint, I'll try to reproduce locally (maybe on a different machine) tomorrow.



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (6 preceding siblings ...)
  2023-04-07 13:02 ` paper42
@ 2023-04-07 13:02 ` paper42
  2023-04-07 13:02 ` paper42
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2023-04-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#discussion_r1160649874

Comment:
remove this space

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (4 preceding siblings ...)
  2023-04-07 12:10 ` adigitoleo
@ 2023-04-07 13:02 ` paper42
  2023-04-07 13:02 ` paper42
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2023-04-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#discussion_r1160650295

Comment:
$version_ is not a variable

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (5 preceding siblings ...)
  2023-04-07 13:02 ` [PR REVIEW] " paper42
@ 2023-04-07 13:02 ` paper42
  2023-04-07 13:02 ` paper42
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2023-04-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#discussion_r1160649817

Comment:
remove this space

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (8 preceding siblings ...)
  2023-04-07 13:02 ` paper42
@ 2023-04-07 13:02 ` paper42
  2023-04-11  9:15 ` [PR PATCH] [Updated] " adigitoleo
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2023-04-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#discussion_r1160650456

Comment:
don't cd, use the whole path in vbin and vman

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (7 preceding siblings ...)
  2023-04-07 13:02 ` paper42
@ 2023-04-07 13:02 ` paper42
  2023-04-07 13:02 ` paper42
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2023-04-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#discussion_r1160650661

Comment:
did you mean do_install?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (9 preceding siblings ...)
  2023-04-07 13:02 ` paper42
@ 2023-04-11  9:15 ` adigitoleo
  2023-04-11  9:17 ` adigitoleo
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-11  9:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is an updated pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages wraith-master
https://github.com/void-linux/void-packages/pull/43317

New package: wraith-master-1.2.1
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/43317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wraith-master-43317.patch --]
[-- Type: text/x-diff, Size: 3368 bytes --]

From c53f535ea4d5b1e166c32ab1be135149eb82fe5d Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Fri, 7 Apr 2023 17:35:06 +1000
Subject: [PATCH] New package: wraith-master-1.2.1

Package for RGB control of AMD Wraith Master cooling fans.
As far as I am aware, the gradle build system is not capable of
producing PIE executables, hence the use of `nopie_files`.
The GTK3 and cli frontends can be built separately, as per upstream
build options (and the AUR PKGBUILD).
---
 srcpkgs/wraith-master-cli      |  1 +
 srcpkgs/wraith-master-gtk      |  1 +
 srcpkgs/wraith-master/template | 56 ++++++++++++++++++++++++++++++++++
 3 files changed, 58 insertions(+)
 create mode 120000 srcpkgs/wraith-master-cli
 create mode 120000 srcpkgs/wraith-master-gtk
 create mode 100644 srcpkgs/wraith-master/template

diff --git a/srcpkgs/wraith-master-cli b/srcpkgs/wraith-master-cli
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-cli
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master-gtk b/srcpkgs/wraith-master-gtk
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-gtk
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master/template b/srcpkgs/wraith-master/template
new file mode 100644
index 000000000000..bc4a0e818a10
--- /dev/null
+++ b/srcpkgs/wraith-master/template
@@ -0,0 +1,56 @@
+# Template file for 'wraith-master'
+
+pkgname=wraith-master
+version=1.2.1
+revision=1
+build_style=gnu-makefile
+# Don't build experimental ELF frontend yet, https://gitlab.com/serebit/wraith-master/-/issues/26.
+make_build_target="common cli gtk"
+# Don't download gradle.
+make_build_args="GRADLE=gradle"
+# Gradle can't build PIE executables?
+nopie_files="/usr/bin/wraith-master /usr/bin/wraith-master-gtk"
+hostmakedepends="scdoc openjdk8 gradle tar"
+makedepends="libusb-devel gtk+3-devel"
+short_desc="Wraith Prism RGB control application built with GTK+ and Kotlin/Native"
+maintainer="adigitoleo <adigitoleo@dissimulo.com>"
+license="Apache-2.0"
+homepage="https://gitlab.com/serebit/wraith-master"
+changelog="https://gitlab.com/serebit/wraith-master/-/raw/master/CHANGELOG.md"
+distfiles="https://gitlab.com/serebit/wraith-master/-/archive/v$version/$pkgname-v$version.tar.gz"
+checksum=fcf150b5f45e9b9ffad60e1a72f7251d4488fba28d5b325688c931f5098e21ca
+
+pre_build() {
+	export GRADLE_USER_HOME=$PWD/.gradle
+	export KONAN_DATA_DIR=$PWD/.konan
+	export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk
+}
+
+do_install() {
+	vmkdir /etc/udev/rules.d/
+	vcopy build/PACKAGE/udev/* /etc/udev/rules.d/
+}
+
+wraith-master-cli_package() {
+	short_desc+=" - CLI frontend"
+	depends="$sourcepkg>=${version}_$revision"
+	pkg_install() {
+		vbin build/PACKAGE/wraith-master
+		vman build/PACKAGE/man/wraith-master.1
+	}
+}
+
+wraith-master-gtk_package() {
+	short_desc+=" - GTK frontend"
+	depends="$sourcepkg>=${version}_$revision"
+	pkg_install() {
+		vbin build/PACKAGE/wraith-master-gtk
+		vman build/PACKAGE/man/wraith-master-gtk.1
+		vmkdir /usr/share/icons/
+		vcopy build/PACKAGE/icons/* /usr/share/icons/
+		vmkdir /usr/share/metainfo/
+		vcopy build/PACKAGE/metainfo/* /usr/share/metainfo/
+		vmkdir /usr/share/applications/
+		vcopy build/PACKAGE/desktop/* /usr/share/applications/
+	}
+}

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (10 preceding siblings ...)
  2023-04-11  9:15 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-04-11  9:17 ` adigitoleo
  2023-04-11 11:40 ` [PR PATCH] [Updated] " adigitoleo
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-11  9:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1502971697

Comment:
Thanks for the review, @paper42. I've addressed the comments in the latest changes. I can repro the build failure now, but only when using xpbs-src and not when manually setting env vars and using make from the source tree. I've reached out to upstream to see if they can help, but will continue to try my best to fix it.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (11 preceding siblings ...)
  2023-04-11  9:17 ` adigitoleo
@ 2023-04-11 11:40 ` adigitoleo
  2023-04-11 11:51 ` adigitoleo
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-11 11:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is an updated pull request by adigitoleo against master on the void-packages repository

https://github.com/adigitoleo/void-packages wraith-master
https://github.com/void-linux/void-packages/pull/43317

New package: wraith-master-1.2.1
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/43317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wraith-master-43317.patch --]
[-- Type: text/x-diff, Size: 3360 bytes --]

From 6b4ad6c3dd75c19ec928ad9e1dba01640f2a8d66 Mon Sep 17 00:00:00 2001
From: adigitoleo <adigitoleo@dissimulo.com>
Date: Fri, 7 Apr 2023 17:35:06 +1000
Subject: [PATCH] New package: wraith-master-1.2.1

Package for RGB control of AMD Wraith Master cooling fans.
As far as I am aware, the gradle build system is not capable of
producing PIE executables, hence the use of `nopie_files`.
The GTK3 and cli frontends can be built separately, as per upstream
build options (and the AUR PKGBUILD).
---
 srcpkgs/wraith-master-cli      |  1 +
 srcpkgs/wraith-master-gtk      |  1 +
 srcpkgs/wraith-master/template | 55 ++++++++++++++++++++++++++++++++++
 3 files changed, 57 insertions(+)
 create mode 120000 srcpkgs/wraith-master-cli
 create mode 120000 srcpkgs/wraith-master-gtk
 create mode 100644 srcpkgs/wraith-master/template

diff --git a/srcpkgs/wraith-master-cli b/srcpkgs/wraith-master-cli
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-cli
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master-gtk b/srcpkgs/wraith-master-gtk
new file mode 120000
index 000000000000..dbdab2cf8071
--- /dev/null
+++ b/srcpkgs/wraith-master-gtk
@@ -0,0 +1 @@
+wraith-master
\ No newline at end of file
diff --git a/srcpkgs/wraith-master/template b/srcpkgs/wraith-master/template
new file mode 100644
index 000000000000..14d34eaa2931
--- /dev/null
+++ b/srcpkgs/wraith-master/template
@@ -0,0 +1,55 @@
+# Template file for 'wraith-master'
+
+pkgname=wraith-master
+version=1.2.1
+revision=1
+build_style=gnu-makefile
+# Don't build experimental ELF frontend yet, https://gitlab.com/serebit/wraith-master/-/issues/26.
+make_build_target="common cli gtk"
+# Don't download gradle.
+make_build_args="GRADLE=gradle"
+# Gradle can't build PIE executables?
+nopie_files="/usr/bin/wraith-master /usr/bin/wraith-master-gtk"
+makedepends="scdoc tar libusb-devel gtk+3-devel openjdk11 gradle"
+short_desc="Wraith Prism RGB control application built with GTK+ and Kotlin/Native"
+maintainer="adigitoleo <adigitoleo@dissimulo.com>"
+license="Apache-2.0"
+homepage="https://gitlab.com/serebit/wraith-master"
+changelog="https://gitlab.com/serebit/wraith-master/-/raw/master/CHANGELOG.md"
+distfiles="https://gitlab.com/serebit/wraith-master/-/archive/v$version/$pkgname-v$version.tar.gz"
+checksum=fcf150b5f45e9b9ffad60e1a72f7251d4488fba28d5b325688c931f5098e21ca
+
+pre_build() {
+	export GRADLE_USER_HOME=$PWD/.gradle
+	export KONAN_DATA_DIR=$PWD/.konan
+	export JAVA_HOME=/usr/lib/jvm/openjdk11/bin/java
+}
+
+do_install() {
+	vmkdir /usr/lib/udev/rules.d/
+	vcopy build/PACKAGE/udev/* /usr/lib/udev/rules.d/
+}
+
+wraith-master-cli_package() {
+	short_desc+=" - CLI frontend"
+	depends="$sourcepkg>=${version}_$revision"
+	pkg_install() {
+		vbin build/PACKAGE/wraith-master
+		vman build/PACKAGE/man/wraith-master.1
+	}
+}
+
+wraith-master-gtk_package() {
+	short_desc+=" - GTK frontend"
+	depends="$sourcepkg>=${version}_$revision"
+	pkg_install() {
+		vbin build/PACKAGE/wraith-master-gtk
+		vman build/PACKAGE/man/wraith-master-gtk.1
+		vmkdir /usr/share/icons/
+		vcopy build/PACKAGE/icons/* /usr/share/icons/
+		vmkdir /usr/share/metainfo/
+		vcopy build/PACKAGE/metainfo/* /usr/share/metainfo/
+		vmkdir /usr/share/applications/
+		vcopy build/PACKAGE/desktop/* /usr/share/applications/
+	}
+}

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (12 preceding siblings ...)
  2023-04-11 11:40 ` [PR PATCH] [Updated] " adigitoleo
@ 2023-04-11 11:51 ` adigitoleo
  2023-07-11  2:02 ` github-actions
  2023-07-26  1:56 ` [PR PATCH] [Closed]: " github-actions
  15 siblings, 0 replies; 17+ messages in thread
From: adigitoleo @ 2023-04-11 11:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1502971697

Comment:
Thanks for the review, @paper42. I've addressed the comments in the latest changes. I can repro the build failure now, but only when using xpbs-src and not when manually setting env vars and using make from the source tree. I've reached out to upstream to see if they can help, but will continue to try my best to fix it.

EDIT: Got it to work with a newer openjdk. However, since this app basically requires an entire java environment to build, and all it does is control RGB for a single type of cooler fan, it might not be a great fit for the void repos. I leave this decision up to void maintainers.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (13 preceding siblings ...)
  2023-04-11 11:51 ` adigitoleo
@ 2023-07-11  2:02 ` github-actions
  2023-07-26  1:56 ` [PR PATCH] [Closed]: " github-actions
  15 siblings, 0 replies; 17+ messages in thread
From: github-actions @ 2023-07-11  2:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1629987740

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Closed]: New package: wraith-master-1.2.1
  2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
                   ` (14 preceding siblings ...)
  2023-07-11  2:02 ` github-actions
@ 2023-07-26  1:56 ` github-actions
  15 siblings, 0 replies; 17+ messages in thread
From: github-actions @ 2023-07-26  1:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

There's a closed pull request on the void-packages repository

New package: wraith-master-1.2.1
https://github.com/void-linux/void-packages/pull/43317

Description:
Package for RGB control of AMD Wraith Master cooling fans. As far as I am aware, the gradle build system is not capable of producing PIE executables, hence the use of `nopie_files`. The GTK3 and cli frontends can be built separately, as per upstream build options (and the AUR PKGBUILD).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES** (system-wide install, compiled)

#### Local build testing
- I built this PR locally for my native architecture, (glibc x86_64)

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2023-07-26  1:56 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07 10:29 [PR PATCH] New package: wraith-master-1.2.1 adigitoleo
2023-04-07 11:29 ` [PR PATCH] [Updated] " adigitoleo
2023-04-07 11:40 ` adigitoleo
2023-04-07 11:53 ` adigitoleo
2023-04-07 11:56 ` asiekierka
2023-04-07 12:10 ` adigitoleo
2023-04-07 13:02 ` [PR REVIEW] " paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-11  9:15 ` [PR PATCH] [Updated] " adigitoleo
2023-04-11  9:17 ` adigitoleo
2023-04-11 11:40 ` [PR PATCH] [Updated] " adigitoleo
2023-04-11 11:51 ` adigitoleo
2023-07-11  2:02 ` github-actions
2023-07-26  1:56 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).