[PR PATCH] New package: tessen-2.2.1

[PR PATCH] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

There is a new pull request by reedts against master on the void-packages repository

https://github.com/reedts/void-packages tessen_v2.2.1
https://github.com/void-linux/void-packages/pull/43377

New package: tessen-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **NO**

While technically this PR does not conform to rule *2* of the package requirements, I consider this as a direct replacement for `rofi-pass` (which itself is also only a shell script) for users running Wayland. As we package `rofi-pass`, I think providing an alternative for Wayland makes sense.

A patch file from https://github.com/void-linux/void-packages/pull/43377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tessen_v2.2.1-43377.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]

From 9e5ce67e9e8eb84bad90d972927513e1d81fedf3 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Mon, 10 Apr 2023 20:04:22 +0200
Subject: [PATCH] New package: tessen-2.2.1

---
 srcpkgs/tessen/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tessen/template

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
new file mode 100644
index 000000000000..039e0ecba979
--- /dev/null
+++ b/srcpkgs/tessen/template
@@ -0,0 +1,17 @@
+# Template file for 'tessen'
+pkgname=tessen
+version=2.2.1
+revision=1
+hostmakedepends="scdoc"
+short_desc="Interactive menu to autotype and copy pass and gopass data"
+maintainer="reedts <j.reedts@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://git.sr.ht/~ayushnix/tessen"
+distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
+checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vcompletion completion/tessen.bash-completion bash
+	vcompletion completion/tessen.fish-completion fish
+}

Re: [PR REVIEW] New package: tessen-2.2.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1161986365

Comment:
would this work?
```suggestion
build_style=gnu-makefile

post_install() {
```

Re: [PR REVIEW] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New review comment by reedts on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1161993018

Comment:
Yes that would work too. However, when using `build_style=gnu-makefile` you'd get a build error because it will try to build `make all`, which in this case does not exist. If you want to use `gnu-makefile` I'd suggest to unset the build function like this:

```sh
do_build() {
    :
}
```

Re: [PR REVIEW] New package: tessen-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1162201774

Comment:
it does the default target in `do_build`, and I don't see any issues with letting [that target](https://git.sr.ht/~ayushnix/tessen/tree/v2.2.1/item/Makefile#L22-25) run, it shouldn't fail

Re: [PR PATCH] [Updated] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

There is an updated pull request by reedts against master on the void-packages repository

https://github.com/reedts/void-packages tessen_v2.2.1
https://github.com/void-linux/void-packages/pull/43377

New package: tessen-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **NO**

While technically this PR does not conform to rule *2* of the package requirements, I consider this as a direct replacement for `rofi-pass` (which itself is also only a shell script) for users running Wayland. As we package `rofi-pass`, I think providing an alternative for Wayland makes sense.

A patch file from https://github.com/void-linux/void-packages/pull/43377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tessen_v2.2.1-43377.patch --]
[-- Type: text/x-diff, Size: 2233 bytes --]

From 9e5ce67e9e8eb84bad90d972927513e1d81fedf3 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Mon, 10 Apr 2023 20:04:22 +0200
Subject: [PATCH 1/2] New package: tessen-2.2.1

---
 srcpkgs/tessen/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tessen/template

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
new file mode 100644
index 000000000000..039e0ecba979
--- /dev/null
+++ b/srcpkgs/tessen/template
@@ -0,0 +1,17 @@
+# Template file for 'tessen'
+pkgname=tessen
+version=2.2.1
+revision=1
+hostmakedepends="scdoc"
+short_desc="Interactive menu to autotype and copy pass and gopass data"
+maintainer="reedts <j.reedts@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://git.sr.ht/~ayushnix/tessen"
+distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
+checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vcompletion completion/tessen.bash-completion bash
+	vcompletion completion/tessen.fish-completion fish
+}

From 521b487f3f31649b6480afab1fcce854f5734c2e Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Tue, 11 Apr 2023 09:33:50 +0200
Subject: [PATCH 2/2] Use `gnu-makefile` build style

---
 srcpkgs/tessen/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
index 039e0ecba979..27bf610a261b 100644
--- a/srcpkgs/tessen/template
+++ b/srcpkgs/tessen/template
@@ -2,6 +2,7 @@
 pkgname=tessen
 version=2.2.1
 revision=1
+build_style=gnu-makefile
 hostmakedepends="scdoc"
 short_desc="Interactive menu to autotype and copy pass and gopass data"
 maintainer="reedts <j.reedts@gmail.com>"
@@ -10,8 +11,7 @@ homepage="https://git.sr.ht/~ayushnix/tessen"
 distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
 checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
 
-do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
+post_install() {
 	vcompletion completion/tessen.bash-completion bash
 	vcompletion completion/tessen.fish-completion fish
 }

Re: [PR REVIEW] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by reedts on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1162412963

Comment:
@classabbyamp my bad, I meant "build warning" rather than error. Nevertheless I updated the template.

Re: [PR PATCH] [Updated] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

There is an updated pull request by reedts against master on the void-packages repository

https://github.com/reedts/void-packages tessen_v2.2.1
https://github.com/void-linux/void-packages/pull/43377

New package: tessen-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **NO**

While technically this PR does not conform to rule *2* of the package requirements, I consider this as a direct replacement for `rofi-pass` (which itself is also only a shell script) for users running Wayland. As we package `rofi-pass`, I think providing an alternative for Wayland makes sense.

A patch file from https://github.com/void-linux/void-packages/pull/43377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tessen_v2.2.1-43377.patch --]
[-- Type: text/x-diff, Size: 2291 bytes --]

From 9e5ce67e9e8eb84bad90d972927513e1d81fedf3 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Mon, 10 Apr 2023 20:04:22 +0200
Subject: [PATCH 1/2] New package: tessen-2.2.1

---
 srcpkgs/tessen/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tessen/template

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
new file mode 100644
index 000000000000..039e0ecba979
--- /dev/null
+++ b/srcpkgs/tessen/template
@@ -0,0 +1,17 @@
+# Template file for 'tessen'
+pkgname=tessen
+version=2.2.1
+revision=1
+hostmakedepends="scdoc"
+short_desc="Interactive menu to autotype and copy pass and gopass data"
+maintainer="reedts <j.reedts@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://git.sr.ht/~ayushnix/tessen"
+distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
+checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vcompletion completion/tessen.bash-completion bash
+	vcompletion completion/tessen.fish-completion fish
+}

From 873fb23e0f7bb95890ab196ede49c440a1830416 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Tue, 11 Apr 2023 09:33:50 +0200
Subject: [PATCH 2/2] Use `gnu-makefile` build style

---
 srcpkgs/tessen/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
index 039e0ecba979..10bb0031012f 100644
--- a/srcpkgs/tessen/template
+++ b/srcpkgs/tessen/template
@@ -2,7 +2,9 @@
 pkgname=tessen
 version=2.2.1
 revision=1
+build_style=gnu-makefile
 hostmakedepends="scdoc"
+checkdepends="shellcheck shfmt"
 short_desc="Interactive menu to autotype and copy pass and gopass data"
 maintainer="reedts <j.reedts@gmail.com>"
 license="GPL-2.0-only"
@@ -10,8 +12,7 @@ homepage="https://git.sr.ht/~ayushnix/tessen"
 distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
 checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
 
-do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
+post_install() {
 	vcompletion completion/tessen.bash-completion bash
 	vcompletion completion/tessen.fish-completion fish
 }

Re: [PR REVIEW] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by reedts on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1162412963

Comment:
@classabbyamp my bad, I meant "build warning" rather than error. Nevertheless I updated the template.

**EDIT:** I also added `checkdepends` to enable the check target

Re: [PR REVIEW] New package: tessen-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1162427335

Comment:
[from what I see in the makefile](https://git.sr.ht/~ayushnix/tessen/tree/v2.2.1/item/Makefile#L32), this should be done by `make install`

Re: [PR PATCH] [Updated] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

There is an updated pull request by reedts against master on the void-packages repository

https://github.com/reedts/void-packages tessen_v2.2.1
https://github.com/void-linux/void-packages/pull/43377

New package: tessen-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **NO**

While technically this PR does not conform to rule *2* of the package requirements, I consider this as a direct replacement for `rofi-pass` (which itself is also only a shell script) for users running Wayland. As we package `rofi-pass`, I think providing an alternative for Wayland makes sense.

A patch file from https://github.com/void-linux/void-packages/pull/43377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tessen_v2.2.1-43377.patch --]
[-- Type: text/x-diff, Size: 3135 bytes --]

From 9e5ce67e9e8eb84bad90d972927513e1d81fedf3 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Mon, 10 Apr 2023 20:04:22 +0200
Subject: [PATCH 1/3] New package: tessen-2.2.1

---
 srcpkgs/tessen/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tessen/template

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
new file mode 100644
index 000000000000..039e0ecba979
--- /dev/null
+++ b/srcpkgs/tessen/template
@@ -0,0 +1,17 @@
+# Template file for 'tessen'
+pkgname=tessen
+version=2.2.1
+revision=1
+hostmakedepends="scdoc"
+short_desc="Interactive menu to autotype and copy pass and gopass data"
+maintainer="reedts <j.reedts@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://git.sr.ht/~ayushnix/tessen"
+distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
+checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
+
+do_install() {
+	make PREFIX=/usr DESTDIR=${DESTDIR} install
+	vcompletion completion/tessen.bash-completion bash
+	vcompletion completion/tessen.fish-completion fish
+}

From 873fb23e0f7bb95890ab196ede49c440a1830416 Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Tue, 11 Apr 2023 09:33:50 +0200
Subject: [PATCH 2/3] Use `gnu-makefile` build style

---
 srcpkgs/tessen/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
index 039e0ecba979..10bb0031012f 100644
--- a/srcpkgs/tessen/template
+++ b/srcpkgs/tessen/template
@@ -2,7 +2,9 @@
 pkgname=tessen
 version=2.2.1
 revision=1
+build_style=gnu-makefile
 hostmakedepends="scdoc"
+checkdepends="shellcheck shfmt"
 short_desc="Interactive menu to autotype and copy pass and gopass data"
 maintainer="reedts <j.reedts@gmail.com>"
 license="GPL-2.0-only"
@@ -10,8 +12,7 @@ homepage="https://git.sr.ht/~ayushnix/tessen"
 distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
 checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
 
-do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
+post_install() {
 	vcompletion completion/tessen.bash-completion bash
 	vcompletion completion/tessen.fish-completion fish
 }

From 81dcc2d4796ed1d7228740b6e630a6e6a24d2fbf Mon Sep 17 00:00:00 2001
From: reedts <j.reedts@gmail.com>
Date: Tue, 11 Apr 2023 09:51:54 +0200
Subject: [PATCH 3/3] Rely on `make install` to install shell completions

---
 srcpkgs/tessen/template | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/srcpkgs/tessen/template b/srcpkgs/tessen/template
index 10bb0031012f..318958cf8f6f 100644
--- a/srcpkgs/tessen/template
+++ b/srcpkgs/tessen/template
@@ -11,8 +11,3 @@ license="GPL-2.0-only"
 homepage="https://git.sr.ht/~ayushnix/tessen"
 distfiles="https://git.sr.ht/~ayushnix/tessen/refs/download/v${version}/tessen-${version}.tar.gz"
 checksum=31d510d5ffac5825bc7e63f13283c5d432eb102db2d2483ee937c9135c8cfc04
-
-post_install() {
-	vcompletion completion/tessen.bash-completion bash
-	vcompletion completion/tessen.fish-completion fish
-}

Re: [PR REVIEW] New package: tessen-2.2.1

[reedts]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by reedts on void-packages repository

https://github.com/void-linux/void-packages/pull/43377#discussion_r1163146472

Comment:
The new commit should be as minimal as it gets

Re: [PR PATCH] [Closed]: New package: tessen-2.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There's a closed pull request on the void-packages repository

New package: tessen-2.2.1
https://github.com/void-linux/void-packages/pull/43377

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **NO**

While technically this PR does not conform to rule *2* of the package requirements, I consider this as a direct replacement for `rofi-pass` (which itself is also only a shell script) for users running Wayland. As we package `rofi-pass`, I think providing an alternative for Wayland makes sense.