From: yoshiyoshyosh <yoshiyoshyosh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] NoiseTorch: update to 0.12.2.
Date: Thu, 27 Apr 2023 05:55:13 +0200 [thread overview]
Message-ID: <20230427035513.g4Gfjl-8PcStUSwgteXcXAsid6M3_4sF3T2YcqZ6V5w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43646@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
There is an updated pull request by yoshiyoshyosh against master on the void-packages repository
https://github.com/yoshiyoshyosh/void-packages noisetorch-0.12.2
https://github.com/void-linux/void-packages/pull/43646
NoiseTorch: update to 0.12.2.
#### Testing the changes
- I tested the changes in this PR: **Briefly**
- I built this PR locally for my native architecture, (x86_64-glibc)
Addresses #41656 and #42403.
I tried building using `rnnoise-devel`; it would build without errors, but would not actually function when testing. Because of this, I'm pretty sure the `*.c` files from rnnoise are required to build the ladspa library that gets integrated into this, so I used the vendored submodules.
Everything seems to work, but I only tried with pipewire (I doubt it'd break anywhere else if pipewire's working fine)
A patch file from https://github.com/void-linux/void-packages/pull/43646.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-noisetorch-0.12.2-43646.patch --]
[-- Type: text/x-diff, Size: 2677 bytes --]
From 4158fa26ee13341cc3bd3b634b9e8637996ca27f Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Wed, 26 Apr 2023 23:34:05 -0400
Subject: [PATCH] NoiseTorch: update to 0.12.2.
---
.../patches/dont-fetch-submods.patch | 11 ++++++++++
srcpkgs/NoiseTorch/template | 22 ++++++++++++++-----
2 files changed, 28 insertions(+), 5 deletions(-)
create mode 100644 srcpkgs/NoiseTorch/patches/dont-fetch-submods.patch
diff --git a/srcpkgs/NoiseTorch/patches/dont-fetch-submods.patch b/srcpkgs/NoiseTorch/patches/dont-fetch-submods.patch
new file mode 100644
index 000000000000..3d7e7aaab9f3
--- /dev/null
+++ b/srcpkgs/NoiseTorch/patches/dont-fetch-submods.patch
@@ -0,0 +1,11 @@
+Don't fetch submodules, since xbps-src does already.
+diff --git a/Makefile b/Makefile
+index ae252c0..6409106 100644
+--- a/Makefile
++++ b/Makefile
+@@ -28,5 +28,4 @@ release: rnnoise
+ rm -rf tmp/
+ go run scripts/signer.go -s -f bin/NoiseTorch_x64_${VERSION}.tgz
+ rnnoise:
+- git submodule update --init --recursive
+ $(MAKE) -C c/ladspa
diff --git a/srcpkgs/NoiseTorch/template b/srcpkgs/NoiseTorch/template
index a9e9fb2c92d4..8fa51fb423be 100644
--- a/srcpkgs/NoiseTorch/template
+++ b/srcpkgs/NoiseTorch/template
@@ -1,17 +1,29 @@
# Template file for 'NoiseTorch'
pkgname=NoiseTorch
-version=0.11.4
+version=0.12.2
revision=1
build_style=go
go_ldflags="-X main.version=${version} -X main.distribution=VoidLinux"
go_import_path="noisetorch"
depends="libcap-progs"
short_desc="Real-time microphone noise suppression on Linux"
-maintainer="Soc Virnyl S. Estela <renegan.ronin@gmail.com>"
+maintainer="yosh <yosh-git@riseup.net>"
license="GPL-3.0-or-later"
-homepage="https://github.com/lawl/NoiseTorch"
-distfiles="https://github.com/lawl/NoiseTorch/archive/${version}.tar.gz"
-checksum=3da6cad119ecca6f4e131c8bca86eb122d2363d5d30dcd1da41974af5887a3c1
+homepage="https://github.com/NoiseTorch/NoiseTorch"
+_c_ringbuf_commit=2037560fb90dea5d2538611d983964d790bdbac2
+_rnnoise_commit=1cbdbcf1283499bbb2230a6b0f126eb9b236defd
+distfiles="https://github.com/NoiseTorch/NoiseTorch/archive/v${version}.tar.gz
+https://github.com/NoiseTorch/c-ringbuf/archive/${_c_ringbuf_commit}.tar.gz
+https://github.com/NoiseTorch/rnnoise/archive/${_rnnoise_commit}.tar.gz"
+checksum="4a30650314a6f83d979f3303d49618847ba58e39e3e26482dfe58b5e261c5611
+877b08413c59baac56b4cc7720fa56cf0eb399192a0ec652ce7b590c9cd9ad8a
+68c7ab4e408426088603e19955e746bb2a412d84bb121b6f39834c60fc8068b7"
+
+post_extract() {
+ mv NoiseTorch-${version}/* .
+ mv c-ringbuf-${_c_ringbuf_commit}/* c/c-ringbuf
+ mv rnnoise-${_rnnoise_commit}/* c/rnnoise
+}
pre_build() {
make rnnoise
next prev parent reply other threads:[~2023-04-27 3:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 3:49 [PR PATCH] " yoshiyoshyosh
2023-04-27 3:55 ` yoshiyoshyosh [this message]
2023-06-23 19:54 ` [PR REVIEW] " Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 20:53 ` yoshiyoshyosh
2023-06-23 21:10 ` yoshiyoshyosh
2023-06-23 21:12 ` yoshiyoshyosh
2023-06-23 21:17 ` Duncaen
2023-06-23 21:23 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-06-23 21:23 ` yoshiyoshyosh
2023-06-23 21:46 ` [PR PATCH] [Closed]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427035513.g4Gfjl-8PcStUSwgteXcXAsid6M3_4sF3T2YcqZ6V5w@z \
--to=yoshiyoshyosh@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).