From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: NoiseTorch: update to 0.12.2.
Date: Fri, 23 Jun 2023 23:46:44 +0200 [thread overview]
Message-ID: <20230623214644.UIN4p66DCQLozmAaG760YA6rWX5DqE2JPMVau0Qn6tU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43646@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
There's a closed pull request on the void-packages repository
NoiseTorch: update to 0.12.2.
https://github.com/void-linux/void-packages/pull/43646
Description:
#### Testing the changes
- I tested the changes in this PR: **Briefly**
- I built this PR locally for my native architecture, (x86_64-glibc)
Addresses #41656 and #42403.
I tried building using `rnnoise-devel`; it would build without errors, but would not actually function when testing. Because of this, I'm pretty sure the `*.c` files from rnnoise are required to build the ladspa library that gets integrated into this, so I used the vendored submodules.
Everything seems to work, but I only tried with pipewire (I doubt it'd break anywhere else if pipewire's working fine)
prev parent reply other threads:[~2023-06-23 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 3:49 [PR PATCH] " yoshiyoshyosh
2023-04-27 3:55 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-06-23 19:54 ` [PR REVIEW] " Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 20:53 ` yoshiyoshyosh
2023-06-23 21:10 ` yoshiyoshyosh
2023-06-23 21:12 ` yoshiyoshyosh
2023-06-23 21:17 ` Duncaen
2023-06-23 21:23 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-06-23 21:23 ` yoshiyoshyosh
2023-06-23 21:46 ` Duncaen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623214644.UIN4p66DCQLozmAaG760YA6rWX5DqE2JPMVau0Qn6tU@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).