Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] NoiseTorch: update to 0.12.2.
Date: Fri, 23 Jun 2023 23:17:50 +0200	[thread overview]
Message-ID: <20230623211750.GJv7Flr3KOwegNTfjfj7ozdnhSp9jHUKLf1M4cDXwZU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43646@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43646#discussion_r1240408890

Comment:
I guess `post_patch` would be more correct, it should already apply `build_wrksrc` there afaik and the steps of patching and building are separated. so you you rerun just the build step during development it doesn't try to patch it every time and print a warning.

  parent reply	other threads:[~2023-06-23 21:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  3:49 [PR PATCH] " yoshiyoshyosh
2023-04-27  3:55 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-06-23 19:54 ` [PR REVIEW] " Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 19:54 ` Duncaen
2023-06-23 20:53 ` yoshiyoshyosh
2023-06-23 21:10 ` yoshiyoshyosh
2023-06-23 21:12 ` yoshiyoshyosh
2023-06-23 21:17 ` Duncaen [this message]
2023-06-23 21:23 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-06-23 21:23 ` yoshiyoshyosh
2023-06-23 21:46 ` [PR PATCH] [Closed]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623211750.GJv7Flr3KOwegNTfjfj7ozdnhSp9jHUKLf1M4cDXwZU@z \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).