Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] zig: target baseline cpu
@ 2023-05-16 12:09 ifreund
  2023-05-16 13:48 ` [PR PATCH] [Merged]: " abenson
  0 siblings, 1 reply; 2+ messages in thread
From: ifreund @ 2023-05-16 12:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

There is a new pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages zig-mcpu-fix
https://github.com/void-linux/void-packages/pull/43900

zig: target baseline cpu
Since zig 0.10.1 the cmake build system will produce a binary with the equivalent of -march=native by default. To produce a binary portable across cpu versions we must target the baseline cpu.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43900.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zig-mcpu-fix-43900.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

From ecc0b8edd9b5b5e337afd680a8f8631f9cb0bfae Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 16 May 2023 14:01:45 +0200
Subject: [PATCH] zig: target baseline cpu

Since zig 0.10.1 the cmake build system will produce a binary with the
equivalent of -march=native by default. To produce a binary portable
across cpu versions we must target the baseline cpu.
---
 srcpkgs/zig/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/zig/template b/srcpkgs/zig/template
index 9807f7ab206b..55b31e5573c4 100644
--- a/srcpkgs/zig/template
+++ b/srcpkgs/zig/template
@@ -1,9 +1,10 @@
 # Template file for 'zig'
 pkgname=zig
 version=0.10.1
-revision=1
+revision=2
 archs="x86_64* aarch64*"
 build_style=cmake
+configure_args="-DZIG_TARGET_MCPU=baseline"
 make_cmd=make
 # we add xml2, zstd, zlib and ncurses
 # because our lld is static-only and requires those to work

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: zig: target baseline cpu
  2023-05-16 12:09 [PR PATCH] zig: target baseline cpu ifreund
@ 2023-05-16 13:48 ` abenson
  0 siblings, 0 replies; 2+ messages in thread
From: abenson @ 2023-05-16 13:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

There's a merged pull request on the void-packages repository

zig: target baseline cpu
https://github.com/void-linux/void-packages/pull/43900

Description:
Since zig 0.10.1 the cmake build system will produce a binary with the equivalent of -march=native by default. To produce a binary portable across cpu versions we must target the baseline cpu.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-16 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 12:09 [PR PATCH] zig: target baseline cpu ifreund
2023-05-16 13:48 ` [PR PATCH] [Merged]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).