[PR PATCH] mdcat: install completions and manpage for mdless.

[PR PATCH] mdcat: install completions and manpage for mdless.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages mdcat-add-mdless-manpage
https://github.com/void-linux/void-packages/pull/43771

mdcat: install completions and manpage for mdless.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@cinerea0

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-add-mdless-manpage-43771.patch --]
[-- Type: text/x-diff, Size: 1691 bytes --]

From db2e0c7e93ee1daab340570c3da10b903ec3125c Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Sat, 6 May 2023 18:41:36 +0300
Subject: [PATCH] mdcat: install completions and manpage for mdless.

---
 srcpkgs/mdcat/template | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index ef45b736e8ea..2bfc7b41e18a 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,7 +1,7 @@
 # Template file for 'mdcat'
 pkgname=mdcat
 version=2.0.3
-revision=1
+revision=2
 build_style=cargo
 hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="openssl-devel"
@@ -22,14 +22,18 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 post_install() {
-	bash_completion=$(find ${wrksrc}/target -name mdcat.bash -print -quit)
-	vcompletion ${bash_completion} bash
-	zsh_completion=$(find ${wrksrc}/target -name _mdcat -print -quit)
-	vcompletion ${zsh_completion} zsh
-	fish_completion=$(find ${wrksrc}/target -name mdcat.fish -print -quit)
-	vcompletion ${fish_completion} fish
+	for command in mdcat mdless; do
+		bash_completion=$(find ${wrksrc}/target -name ${command}.bash -print -quit)
+		vcompletion ${bash_completion} bash ${command}
+		zsh_completion=$(find ${wrksrc}/target -name _${command} -print -quit)
+		vcompletion ${zsh_completion} zsh ${command}
+		fish_completion=$(find ${wrksrc}/target -name ${command}.fish -print -quit)
+		vcompletion ${fish_completion} fish ${command}
+	done
 
 	man_page=$(find ${wrksrc}/target -name mdcat.1 -print -quit)
 	vman ${man_page}
+
 	ln -sf /usr/bin/mdcat ${DESTDIR}/usr/bin/mdless
+	ln -sf mdcat.1 ${DESTDIR}/usr/share/man/man1/mdless.1
 }

Re: [PR REVIEW] mdcat: install completions and manpage for mdless.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43771#discussion_r1186734964

Comment:
i don't see any other distro doing this, and the help output for mdless says `See 'man 1 mdcat' for more information.`

Re: [PR REVIEW] mdcat: install completions and manpage for mdless.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43771#discussion_r1186735566

Comment:
Still, here's the synopsis for the manpage:
```
       mdcat [OPTIONS] [FILE]...

       mdless [OPTIONS] [FILE]...
```

So I think it makes sense.

Re: [PR REVIEW] mdcat: install completions and manpage for mdless.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43771#discussion_r1190568755

Comment:
Nope, I don't think it make sense, its `.TH` is `MDCAT`, its `.SH "NAME"`  is `mdcat`, upstream should change like this:
```diff
30c30
< mdcat \- render CommonMark Markdown to text terminals
---
> mdcat, mdless \- render CommonMark Markdown to text terminals
```

Re: [PR PATCH] [Updated] mdcat: install completions and manpage for mdless.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages mdcat-add-mdless-manpage
https://github.com/void-linux/void-packages/pull/43771

mdcat: install completions and manpage for mdless.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@cinerea0

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-add-mdless-manpage-43771.patch --]
[-- Type: text/x-diff, Size: 1565 bytes --]

From e6231ba584ffbbc28ea2c747971d6d87622ba96c Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Sat, 6 May 2023 18:41:36 +0300
Subject: [PATCH] mdcat: install completions for mdless.

---
 srcpkgs/mdcat/template | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index ef45b736e8ea..4a5e219556bf 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,7 +1,7 @@
 # Template file for 'mdcat'
 pkgname=mdcat
 version=2.0.3
-revision=1
+revision=2
 build_style=cargo
 hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="openssl-devel"
@@ -22,12 +22,14 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 post_install() {
-	bash_completion=$(find ${wrksrc}/target -name mdcat.bash -print -quit)
-	vcompletion ${bash_completion} bash
-	zsh_completion=$(find ${wrksrc}/target -name _mdcat -print -quit)
-	vcompletion ${zsh_completion} zsh
-	fish_completion=$(find ${wrksrc}/target -name mdcat.fish -print -quit)
-	vcompletion ${fish_completion} fish
+	for command in mdcat mdless; do
+		bash_completion=$(find ${wrksrc}/target -name ${command}.bash -print -quit)
+		vcompletion ${bash_completion} bash ${command}
+		zsh_completion=$(find ${wrksrc}/target -name _${command} -print -quit)
+		vcompletion ${zsh_completion} zsh ${command}
+		fish_completion=$(find ${wrksrc}/target -name ${command}.fish -print -quit)
+		vcompletion ${fish_completion} fish ${command}
+	done
 
 	man_page=$(find ${wrksrc}/target -name mdcat.1 -print -quit)
 	vman ${man_page}

Re: [PR REVIEW] mdcat: install completions for mdless.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43771#discussion_r1199807319

Comment:
I understand, I removed the manpage symlink for now.

Re: [PR PATCH] [Merged]: mdcat: install completions for mdless.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

There's a merged pull request on the void-packages repository

mdcat: install completions for mdless.
https://github.com/void-linux/void-packages/pull/43771

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@cinerea0

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->