* Re: [PR REVIEW] gforth: fix build on musl
2023-03-20 8:33 [PR PATCH] gforth: fix build on musl hazen2215
@ 2023-03-20 14:50 ` sgn
2023-03-20 15:40 ` [PR PATCH] [Updated] " hazen2215
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2023-03-20 14:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/42876#discussion_r1142240189
Comment:
```suggestion
revision=3
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] gforth: fix build on musl
2023-03-20 8:33 [PR PATCH] gforth: fix build on musl hazen2215
2023-03-20 14:50 ` [PR REVIEW] " sgn
@ 2023-03-20 15:40 ` hazen2215
2023-05-28 11:09 ` hazen2215
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: hazen2215 @ 2023-03-20 15:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
There is an updated pull request by hazen2215 against master on the void-packages repository
https://github.com/hazen2215/void-packages gforth
https://github.com/void-linux/void-packages/pull/42876
gforth: fix build on musl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
A patch file from https://github.com/void-linux/void-packages/pull/42876.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gforth-42876.patch --]
[-- Type: text/x-diff, Size: 914 bytes --]
From e4e1fb9a8bd5ac5faeaf72b229da8a27fd70cd27 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Mon, 20 Mar 2023 17:27:20 +0900
Subject: [PATCH] gforth: fix build on musl
---
srcpkgs/gforth/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gforth/template b/srcpkgs/gforth/template
index f0df03991086..053a4814dd8e 100644
--- a/srcpkgs/gforth/template
+++ b/srcpkgs/gforth/template
@@ -14,6 +14,8 @@ checksum=2f62f2233bf022c23d01c920b1556aa13eab168e3236b13352ac5e9f18542bb0
disable_parallel_build=yes
nocross="Configure script is picky: https://api.travis-ci.org/jobs/158049419/log.txt?deansi=true"
-case "${XBPS_TARGET_MACHINE}" in
- *-musl) broken="Tests fail, might just be a flushing problem";;
-esac
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ # Tests fail, might just be a flushing problem
+ make_check=no
+ configure_args="--without-check"
+fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] gforth: fix build on musl
2023-03-20 8:33 [PR PATCH] gforth: fix build on musl hazen2215
2023-03-20 14:50 ` [PR REVIEW] " sgn
2023-03-20 15:40 ` [PR PATCH] [Updated] " hazen2215
@ 2023-05-28 11:09 ` hazen2215
2023-06-05 17:19 ` hazen2215
2023-06-23 20:04 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: hazen2215 @ 2023-05-28 11:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
There is an updated pull request by hazen2215 against master on the void-packages repository
https://github.com/hazen2215/void-packages gforth
https://github.com/void-linux/void-packages/pull/42876
gforth: fix build on musl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
A patch file from https://github.com/void-linux/void-packages/pull/42876.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gforth-42876.patch --]
[-- Type: text/x-diff, Size: 914 bytes --]
From 8ff90b1a548fb3b1f7278b62796ae7e7273a24d6 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Mon, 20 Mar 2023 17:27:20 +0900
Subject: [PATCH] gforth: fix build on musl
---
srcpkgs/gforth/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gforth/template b/srcpkgs/gforth/template
index f0df03991086..053a4814dd8e 100644
--- a/srcpkgs/gforth/template
+++ b/srcpkgs/gforth/template
@@ -14,6 +14,8 @@ checksum=2f62f2233bf022c23d01c920b1556aa13eab168e3236b13352ac5e9f18542bb0
disable_parallel_build=yes
nocross="Configure script is picky: https://api.travis-ci.org/jobs/158049419/log.txt?deansi=true"
-case "${XBPS_TARGET_MACHINE}" in
- *-musl) broken="Tests fail, might just be a flushing problem";;
-esac
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ # Tests fail, might just be a flushing problem
+ make_check=no
+ configure_args="--without-check"
+fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] gforth: fix build on musl
2023-03-20 8:33 [PR PATCH] gforth: fix build on musl hazen2215
` (2 preceding siblings ...)
2023-05-28 11:09 ` hazen2215
@ 2023-06-05 17:19 ` hazen2215
2023-06-23 20:04 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: hazen2215 @ 2023-06-05 17:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
There is an updated pull request by hazen2215 against master on the void-packages repository
https://github.com/hazen2215/void-packages gforth
https://github.com/void-linux/void-packages/pull/42876
gforth: fix build on musl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
A patch file from https://github.com/void-linux/void-packages/pull/42876.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gforth-42876.patch --]
[-- Type: text/x-diff, Size: 914 bytes --]
From 4c70759fab35b601b371bd281b8d3ccbb01ae719 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Mon, 20 Mar 2023 17:27:20 +0900
Subject: [PATCH] gforth: fix build on musl
---
srcpkgs/gforth/template | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gforth/template b/srcpkgs/gforth/template
index f0df03991086..053a4814dd8e 100644
--- a/srcpkgs/gforth/template
+++ b/srcpkgs/gforth/template
@@ -14,6 +14,8 @@ checksum=2f62f2233bf022c23d01c920b1556aa13eab168e3236b13352ac5e9f18542bb0
disable_parallel_build=yes
nocross="Configure script is picky: https://api.travis-ci.org/jobs/158049419/log.txt?deansi=true"
-case "${XBPS_TARGET_MACHINE}" in
- *-musl) broken="Tests fail, might just be a flushing problem";;
-esac
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+ # Tests fail, might just be a flushing problem
+ make_check=no
+ configure_args="--without-check"
+fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: gforth: fix build on musl
2023-03-20 8:33 [PR PATCH] gforth: fix build on musl hazen2215
` (3 preceding siblings ...)
2023-06-05 17:19 ` hazen2215
@ 2023-06-23 20:04 ` Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2023-06-23 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
There's a merged pull request on the void-packages repository
gforth: fix build on musl
https://github.com/void-linux/void-packages/pull/42876
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
^ permalink raw reply [flat|nested] 6+ messages in thread