Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#discussion_r1243918483

Comment:
Please add some context to the patch, like the source and what it tries to solve. You can put plain text for that at the start of the patch.

Re: [PR PATCH] [Updated] New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

There is an updated pull request by jason1987d against master on the void-packages repository

https://github.com/jason1987d/void-packages python3-finvizfinance
https://github.com/void-linux/void-packages/pull/44201

New package: python3-finvizfinance-0.14.5
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/44201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-finvizfinance-44201.patch --]
[-- Type: text/x-diff, Size: 2934 bytes --]

From d52489735c731b4d6979639829732049ddd2bedc Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Sun, 6 Nov 2022 17:06:40 -0600
Subject: [PATCH] New package: python3-finvizfinance-0.14.5

---
 .../patches/quote.py.patch                    | 30 +++++++++++++++++++
 srcpkgs/python3-finvizfinance/template        | 18 +++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 srcpkgs/python3-finvizfinance/patches/quote.py.patch
 create mode 100644 srcpkgs/python3-finvizfinance/template

diff --git a/srcpkgs/python3-finvizfinance/patches/quote.py.patch b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
new file mode 100644
index 000000000000..d40235cd184b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
@@ -0,0 +1,30 @@
+Wrap a test that was failing with exception handling in order to pass testing.
+--- a/finvizfinance/quote.py	2023-02-03 21:17:45.000000000 -0600
++++ b/finvizfinance/quote.py	2023-05-29 17:56:18.702135822 -0500
+@@ -133,12 +133,20 @@
+         table = self.soup.find("table", class_="fullview-title")
+         rows = table.findAll("tr")
+ 
+-        fundament_info["Company"] = rows[1].text
+-        (
+-            fundament_info["Sector"],
+-            fundament_info["Industry"],
+-            fundament_info["Country"],
+-        ) = rows[2].text.split(" | ")
++        try:
++            fundament_info["Company"] = rows[1].text
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[2].text.split(" | ")
++        except IndexError:
++            (_, fundament_info["Company"], _) = rows[0].text.split(' | ')
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[1].text.split(" | ")
+ 
+         fundament_table = self.soup.find("table", class_="snapshot-table2")
+         rows = fundament_table.findAll("tr")
diff --git a/srcpkgs/python3-finvizfinance/template b/srcpkgs/python3-finvizfinance/template
new file mode 100644
index 000000000000..7402fd3d1b8b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-finvizfinance'
+pkgname=python3-finvizfinance
+version=0.14.5
+revision=1
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3 python3-requests python3-BeautifulSoup4 python3-pandas python3-lxml"
+checkdepends="${depends} python3-pytest python3-pytest-mock"
+short_desc="FinViz API Python 3 Module"
+maintainer="Jason Elswick <jason@jasondavid.tv>"
+license="MIT"
+homepage="https://pypi.org/project/finvizfinance/"
+distfiles="${PYPI_SITE}/f/finvizfinance/finvizfinance-${version}.tar.gz"
+checksum=c97fe0e69d681d9108113aed943988561665d0d4dbd64ffa0b666a2899c25899
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by jason1987d on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#discussion_r1243950955

Comment:
Added.

Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#discussion_r1243969081

Comment:
Could you also link to https://github.com/lit26/finvizfinance/commit/ddd263736be278c8834242679c08c804d17ba1c0

Re: [PR PATCH] [Updated] New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

There is an updated pull request by jason1987d against master on the void-packages repository

https://github.com/jason1987d/void-packages python3-finvizfinance
https://github.com/void-linux/void-packages/pull/44201

New package: python3-finvizfinance-0.14.5
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):


A patch file from https://github.com/void-linux/void-packages/pull/44201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-finvizfinance-44201.patch --]
[-- Type: text/x-diff, Size: 3022 bytes --]

From 6f3242262b4c8165d6b586e504dd22c56fa49419 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Sun, 6 Nov 2022 17:06:40 -0600
Subject: [PATCH] New package: python3-finvizfinance-0.14.5

---
 .../patches/quote.py.patch                    | 31 +++++++++++++++++++
 srcpkgs/python3-finvizfinance/template        | 18 +++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 srcpkgs/python3-finvizfinance/patches/quote.py.patch
 create mode 100644 srcpkgs/python3-finvizfinance/template

diff --git a/srcpkgs/python3-finvizfinance/patches/quote.py.patch b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
new file mode 100644
index 000000000000..8fad457ba40b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/patches/quote.py.patch
@@ -0,0 +1,31 @@
+Wrap a test that was failing with exception handling in order to pass testing.
+https://github.com/lit26/finvizfinance/commit/ddd263736be278c8834242679c08c804d17ba1c0
+--- a/finvizfinance/quote.py	2023-02-03 21:17:45.000000000 -0600
++++ b/finvizfinance/quote.py	2023-05-29 17:56:18.702135822 -0500
+@@ -133,12 +133,20 @@
+         table = self.soup.find("table", class_="fullview-title")
+         rows = table.findAll("tr")
+ 
+-        fundament_info["Company"] = rows[1].text
+-        (
+-            fundament_info["Sector"],
+-            fundament_info["Industry"],
+-            fundament_info["Country"],
+-        ) = rows[2].text.split(" | ")
++        try:
++            fundament_info["Company"] = rows[1].text
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[2].text.split(" | ")
++        except IndexError:
++            (_, fundament_info["Company"], _) = rows[0].text.split(' | ')
++            (
++                fundament_info["Sector"],
++                fundament_info["Industry"],
++                fundament_info["Country"],
++            ) = rows[1].text.split(" | ")
+ 
+         fundament_table = self.soup.find("table", class_="snapshot-table2")
+         rows = fundament_table.findAll("tr")
diff --git a/srcpkgs/python3-finvizfinance/template b/srcpkgs/python3-finvizfinance/template
new file mode 100644
index 000000000000..7402fd3d1b8b
--- /dev/null
+++ b/srcpkgs/python3-finvizfinance/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-finvizfinance'
+pkgname=python3-finvizfinance
+version=0.14.5
+revision=1
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3 python3-requests python3-BeautifulSoup4 python3-pandas python3-lxml"
+checkdepends="${depends} python3-pytest python3-pytest-mock"
+short_desc="FinViz API Python 3 Module"
+maintainer="Jason Elswick <jason@jasondavid.tv>"
+license="MIT"
+homepage="https://pypi.org/project/finvizfinance/"
+distfiles="${PYPI_SITE}/f/finvizfinance/finvizfinance-${version}.tar.gz"
+checksum=c97fe0e69d681d9108113aed943988561665d0d4dbd64ffa0b666a2899c25899
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by jason1987d on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#discussion_r1244113543

Comment:
Now it's failing when it worked earlier and I'm not sure why.

Re: [PR REVIEW] New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by jason1987d on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#discussion_r1244113543

Comment:
Now it's failing when it worked earlier and I'm not sure why.

Re: New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by jason1987d on void-packages repository

https://github.com/void-linux/void-packages/pull/44201#issuecomment-1610113327

Comment:
There actually appears to be a fairly new bug that I hadn't encountered when using this a month ago. I have found another python3 module that handles finviz that has a more recent update that I will take a look on.

Re: [PR PATCH] [Closed]: New package: python3-finvizfinance-0.14.5

[jason1987d]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

There's a closed pull request on the void-packages repository

New package: python3-finvizfinance-0.14.5
https://github.com/void-linux/void-packages/pull/44201

Description:
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):