* [PR PATCH] remmina: compile with kwallet support
@ 2023-06-28 10:49 fgietzen
2023-06-29 10:50 ` [PR PATCH] [Updated] " fgietzen
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: fgietzen @ 2023-06-28 10:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
There is a new pull request by fgietzen against master on the void-packages repository
https://github.com/fgietzen/void-packages master
https://github.com/void-linux/void-packages/pull/44677
remmina: compile with kwallet support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
A patch file from https://github.com/void-linux/void-packages/pull/44677.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44677.patch --]
[-- Type: text/x-diff, Size: 1132 bytes --]
From 38f526a45ee27fabf86b8d0f051414bbc5747dc4 Mon Sep 17 00:00:00 2001
From: Fabian Gietzen <fabian.gietzen@web.de>
Date: Wed, 28 Jun 2023 12:31:54 +0200
Subject: [PATCH] remmina: compile with kwallet support
---
srcpkgs/remmina/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/remmina/template b/srcpkgs/remmina/template
index 657e392d1f01..5a5189f3e6e7 100644
--- a/srcpkgs/remmina/template
+++ b/srcpkgs/remmina/template
@@ -3,10 +3,10 @@ pkgname=remmina
version=1.4.31
revision=1
build_style=cmake
-configure_args="-DCMAKE_USE_PTHREADS_INIT=ON"
+configure_args="-DCMAKE_USE_PTHREADS_INIT=ON -DWITH_KF5WALLET=on"
hostmakedepends="glib-devel intltool pkg-config shared-mime-info"
makedepends="avahi-glib-libs-devel avahi-ui-libs-devel freerdp-devel
- gobject-introspection gstreamermm-devel json-glib-devel
+ gobject-introspection gstreamermm-devel json-glib-devel kwallet-devel
libgcrypt-devel libgnome-keyring-devel liblz4-devel libsasl-devel
libsecret-devel libsodium-devel libsoup3-devel libssh-devel libva-devel
libvncserver-devel libxkbfile-devel opus-devel phodav-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
@ 2023-06-29 10:50 ` fgietzen
2023-06-29 15:44 ` [PR REVIEW] " sgn
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: fgietzen @ 2023-06-29 10:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
There is an updated pull request by fgietzen against master on the void-packages repository
https://github.com/fgietzen/void-packages master
https://github.com/void-linux/void-packages/pull/44677
remmina: compile with kwallet support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
A patch file from https://github.com/void-linux/void-packages/pull/44677.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44677.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]
From 4494cb31f0dac73123f738d959f4c024f387ce7a Mon Sep 17 00:00:00 2001
From: Fabian Gietzen <fabian.gietzen@web.de>
Date: Wed, 28 Jun 2023 12:31:54 +0200
Subject: [PATCH] remmina: compile with kwallet support
---
srcpkgs/remmina/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/remmina/template b/srcpkgs/remmina/template
index 657e392d1f01..4e6720c2bfa2 100644
--- a/srcpkgs/remmina/template
+++ b/srcpkgs/remmina/template
@@ -3,10 +3,10 @@ pkgname=remmina
version=1.4.31
revision=1
build_style=cmake
-configure_args="-DCMAKE_USE_PTHREADS_INIT=ON"
-hostmakedepends="glib-devel intltool pkg-config shared-mime-info"
+configure_args="-DCMAKE_USE_PTHREADS_INIT=ON -DWITH_KF5WALLET=on"
+hostmakedepends="glib-devel intltool pkg-config shared-mime-info qt5-host-tools qt5-qmake"
makedepends="avahi-glib-libs-devel avahi-ui-libs-devel freerdp-devel
- gobject-introspection gstreamermm-devel json-glib-devel
+ gobject-introspection gstreamermm-devel json-glib-devel kwallet-devel
libgcrypt-devel libgnome-keyring-devel liblz4-devel libsasl-devel
libsecret-devel libsodium-devel libsoup3-devel libssh-devel libva-devel
libvncserver-devel libxkbfile-devel opus-devel phodav-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
2023-06-29 10:50 ` [PR PATCH] [Updated] " fgietzen
@ 2023-06-29 15:44 ` sgn
2023-06-29 16:25 ` [PR PATCH] [Updated] " fgietzen
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2023-06-29 15:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/44677#discussion_r1246820392
Comment:
```suggestion
revision=2
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
2023-06-29 10:50 ` [PR PATCH] [Updated] " fgietzen
2023-06-29 15:44 ` [PR REVIEW] " sgn
@ 2023-06-29 16:25 ` fgietzen
2023-06-29 16:26 ` [PR REVIEW] " fgietzen
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: fgietzen @ 2023-06-29 16:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
There is an updated pull request by fgietzen against master on the void-packages repository
https://github.com/fgietzen/void-packages master
https://github.com/void-linux/void-packages/pull/44677
remmina: compile with kwallet support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
- aarch64
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
A patch file from https://github.com/void-linux/void-packages/pull/44677.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44677.patch --]
[-- Type: text/x-diff, Size: 1272 bytes --]
From a431aa62a49d517185f81b5d1b34baf22c66f4c4 Mon Sep 17 00:00:00 2001
From: Fabian Gietzen <fabian.gietzen@web.de>
Date: Wed, 28 Jun 2023 12:31:54 +0200
Subject: [PATCH] remmina: compile with kwallet support
---
srcpkgs/remmina/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/remmina/template b/srcpkgs/remmina/template
index 657e392d1f01..a93936c96e0d 100644
--- a/srcpkgs/remmina/template
+++ b/srcpkgs/remmina/template
@@ -1,12 +1,12 @@
# Template file for 'remmina'
pkgname=remmina
version=1.4.31
-revision=1
+revision=2
build_style=cmake
-configure_args="-DCMAKE_USE_PTHREADS_INIT=ON"
-hostmakedepends="glib-devel intltool pkg-config shared-mime-info"
+configure_args="-DCMAKE_USE_PTHREADS_INIT=ON -DWITH_KF5WALLET=on"
+hostmakedepends="glib-devel intltool pkg-config shared-mime-info qt5-host-tools qt5-qmake"
makedepends="avahi-glib-libs-devel avahi-ui-libs-devel freerdp-devel
- gobject-introspection gstreamermm-devel json-glib-devel
+ gobject-introspection gstreamermm-devel json-glib-devel kwallet-devel
libgcrypt-devel libgnome-keyring-devel liblz4-devel libsasl-devel
libsecret-devel libsodium-devel libsoup3-devel libssh-devel libva-devel
libvncserver-devel libxkbfile-devel opus-devel phodav-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
` (2 preceding siblings ...)
2023-06-29 16:25 ` [PR PATCH] [Updated] " fgietzen
@ 2023-06-29 16:26 ` fgietzen
2023-07-04 16:34 ` sgn
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: fgietzen @ 2023-06-29 16:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by fgietzen on void-packages repository
https://github.com/void-linux/void-packages/pull/44677#discussion_r1246869685
Comment:
Oh my bad. I changed it.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
` (3 preceding siblings ...)
2023-06-29 16:26 ` [PR REVIEW] " fgietzen
@ 2023-07-04 16:34 ` sgn
2023-07-04 18:30 ` [PR PATCH] [Updated] " fgietzen
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2023-07-04 16:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/44677#issuecomment-1620518780
Comment:
Please split kwallet plugin into subpkg.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
` (4 preceding siblings ...)
2023-07-04 16:34 ` sgn
@ 2023-07-04 18:30 ` fgietzen
2023-07-04 18:38 ` fgietzen
2023-07-17 2:57 ` [PR PATCH] [Merged]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: fgietzen @ 2023-07-04 18:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
There is an updated pull request by fgietzen against master on the void-packages repository
https://github.com/fgietzen/void-packages master
https://github.com/void-linux/void-packages/pull/44677
remmina: compile with kwallet support
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
- aarch64
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
A patch file from https://github.com/void-linux/void-packages/pull/44677.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44677.patch --]
[-- Type: text/x-diff, Size: 1954 bytes --]
From 34008c103992754ef244610d94835eb37fd274f8 Mon Sep 17 00:00:00 2001
From: Fabian Gietzen <fabian.gietzen@web.de>
Date: Wed, 28 Jun 2023 12:31:54 +0200
Subject: [PATCH] remmina: compile with kwallet support
---
srcpkgs/remmina-kwallet | 1 +
srcpkgs/remmina/template | 16 ++++++++++++----
2 files changed, 13 insertions(+), 4 deletions(-)
create mode 120000 srcpkgs/remmina-kwallet
diff --git a/srcpkgs/remmina-kwallet b/srcpkgs/remmina-kwallet
new file mode 120000
index 000000000000..88b1c3eacfbf
--- /dev/null
+++ b/srcpkgs/remmina-kwallet
@@ -0,0 +1 @@
+remmina
\ No newline at end of file
diff --git a/srcpkgs/remmina/template b/srcpkgs/remmina/template
index 657e392d1f01..7c89e4e0e968 100644
--- a/srcpkgs/remmina/template
+++ b/srcpkgs/remmina/template
@@ -1,12 +1,12 @@
# Template file for 'remmina'
pkgname=remmina
version=1.4.31
-revision=1
+revision=2
build_style=cmake
-configure_args="-DCMAKE_USE_PTHREADS_INIT=ON"
-hostmakedepends="glib-devel intltool pkg-config shared-mime-info"
+configure_args="-DCMAKE_USE_PTHREADS_INIT=ON -DWITH_KF5WALLET=on"
+hostmakedepends="glib-devel intltool pkg-config shared-mime-info qt5-host-tools qt5-qmake"
makedepends="avahi-glib-libs-devel avahi-ui-libs-devel freerdp-devel
- gobject-introspection gstreamermm-devel json-glib-devel
+ gobject-introspection gstreamermm-devel json-glib-devel kwallet-devel
libgcrypt-devel libgnome-keyring-devel liblz4-devel libsasl-devel
libsecret-devel libsodium-devel libsoup3-devel libssh-devel libva-devel
libvncserver-devel libxkbfile-devel opus-devel phodav-devel
@@ -24,3 +24,11 @@ checksum=cfe9d4a6f2951d35533e5b2235f76640573c91f1be3bd8118637fbf68234500a
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
makedepends+=" libexecinfo-devel"
fi
+
+remmina-kwallet_package() {
+ short_desc+=" - kwallet plugin"
+ depends="${sourcepkg}>=${version}_${revision} kwallet"
+ pkg_install() {
+ vmove usr/lib/remmina/plugins/remmina-plugin-kwallet.so
+ }
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
` (5 preceding siblings ...)
2023-07-04 18:30 ` [PR PATCH] [Updated] " fgietzen
@ 2023-07-04 18:38 ` fgietzen
2023-07-17 2:57 ` [PR PATCH] [Merged]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: fgietzen @ 2023-07-04 18:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
New comment by fgietzen on void-packages repository
https://github.com/void-linux/void-packages/pull/44677#issuecomment-1620614133
Comment:
> Please split kwallet plugin into subpkg.
That makes sense.
I added an entry inspired by the example in the manual. Please let me know if something is missing there.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: remmina: compile with kwallet support
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
` (6 preceding siblings ...)
2023-07-04 18:38 ` fgietzen
@ 2023-07-17 2:57 ` sgn
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2023-07-17 2:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
There's a merged pull request on the void-packages repository
remmina: compile with kwallet support
https://github.com/void-linux/void-packages/pull/44677
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
- aarch64
### Description
Adds compile flag and dependency to support *KWallet* in Remmina so passwords can be stored.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-07-17 2:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-28 10:49 [PR PATCH] remmina: compile with kwallet support fgietzen
2023-06-29 10:50 ` [PR PATCH] [Updated] " fgietzen
2023-06-29 15:44 ` [PR REVIEW] " sgn
2023-06-29 16:25 ` [PR PATCH] [Updated] " fgietzen
2023-06-29 16:26 ` [PR REVIEW] " fgietzen
2023-07-04 16:34 ` sgn
2023-07-04 18:30 ` [PR PATCH] [Updated] " fgietzen
2023-07-04 18:38 ` fgietzen
2023-07-17 2:57 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).