* [PR PATCH] inkscape: fix update-check
@ 2023-07-05 11:27 Bnyro
2023-07-05 11:28 ` atk
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Bnyro @ 2023-07-05 11:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
There is a new pull request by Bnyro against master on the void-packages repository
https://github.com/Bnyro/void-packages inkscape
https://github.com/void-linux/void-packages/pull/44859
inkscape: fix update-check
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
The old Regex also detects development releases (1.3), although it's not an official release yet. (Current should be 1.2.2).
A patch file from https://github.com/void-linux/void-packages/pull/44859.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-inkscape-44859.patch --]
[-- Type: text/x-diff, Size: 560 bytes --]
From 0b3984bf3068b33285af4ec7784a298ba5c65911 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Wed, 5 Jul 2023 13:26:39 +0200
Subject: [PATCH] inkscape: fix update-check
---
srcpkgs/inkscape/update | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/inkscape/update b/srcpkgs/inkscape/update
index 2a649bb0bbef..0d1faee432dc 100644
--- a/srcpkgs/inkscape/update
+++ b/srcpkgs/inkscape/update
@@ -1,2 +1,2 @@
site="https://inkscape.org/release/"
-pattern='release/inkscape-\K[0-9.]+(?=/)'
+pattern='Inkscape \K[0-9.]+'
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: inkscape: fix update-check
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
@ 2023-07-05 11:28 ` atk
2023-07-05 12:50 ` mhmdanas
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: atk @ 2023-07-05 11:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
New comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621570051
Comment:
Thanks, I haven't had the time to fix this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: inkscape: fix update-check
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
2023-07-05 11:28 ` atk
@ 2023-07-05 12:50 ` mhmdanas
2023-07-05 12:51 ` Bnyro
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mhmdanas @ 2023-07-05 12:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621693980
Comment:
It's probably a good idea to mark PRs that just change "update" files as [ci skip], because there's no reason to rebuild the packages.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: inkscape: fix update-check
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
2023-07-05 11:28 ` atk
2023-07-05 12:50 ` mhmdanas
@ 2023-07-05 12:51 ` Bnyro
2023-07-05 12:57 ` mhmdanas
2023-07-08 18:25 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Bnyro @ 2023-07-05 12:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621696505
Comment:
True, makes sense.
It doesn't seem to rebuild the package though, seems to be detected automatically (CI only took 40s for each, but even that could be skipped)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: inkscape: fix update-check
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
` (2 preceding siblings ...)
2023-07-05 12:51 ` Bnyro
@ 2023-07-05 12:57 ` mhmdanas
2023-07-08 18:25 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: mhmdanas @ 2023-07-05 12:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/44859#issuecomment-1621704600
Comment:
Ah, I wasn't aware of that, I thought even changing the update file was enough to make CI rebuild the package. Good to know. :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: inkscape: fix update-check
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
` (3 preceding siblings ...)
2023-07-05 12:57 ` mhmdanas
@ 2023-07-08 18:25 ` Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2023-07-08 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
There's a merged pull request on the void-packages repository
inkscape: fix update-check
https://github.com/void-linux/void-packages/pull/44859
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
The old Regex also detects development releases (1.3), although it's not an official release yet. (Current should be 1.2.2).
cc @atk
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-08 18:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-05 11:27 [PR PATCH] inkscape: fix update-check Bnyro
2023-07-05 11:28 ` atk
2023-07-05 12:50 ` mhmdanas
2023-07-05 12:51 ` Bnyro
2023-07-05 12:57 ` mhmdanas
2023-07-08 18:25 ` [PR PATCH] [Merged]: " Duncaen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).